Modern Media Controls: Adding a poster attribute after page load does not show poster |
|||
Issue descriptionFor a preload=none video with no poster on page load, we show the default poster (grey). If a poster="..." attribute is then added to the video, the poster is hidden behind the default (grey) poster, since we don't update the video CSS class list to not have "use-default-poster"
,
Mar 16 2018
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33dd468c11d52696213d761254b1ec4d78829383 commit 33dd468c11d52696213d761254b1ec4d78829383 Author: Tommy Steimel <steimel@chromium.org> Date: Fri Mar 16 18:37:13 2018 Update media controls CSS classes when poster attribute is changed This CL adds 'poster' to the list of attributes that the MediaElementMutationCallback listens for. When changed, the CSS classes of the media controls are updated. This fixes a bug where a poster added after page load would not show up because it was hidden behind the default poster. Bug: 814956 Change-Id: I4b39e6995ddb35829d886e138fe8a1d573dd8036 Reviewed-on: https://chromium-review.googlesource.com/965589 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543767} [add] https://crrev.com/33dd468c11d52696213d761254b1ec4d78829383/third_party/WebKit/LayoutTests/media/controls/modern/add-poster-after-page-load.html [modify] https://crrev.com/33dd468c11d52696213d761254b1ec4d78829383/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
,
Mar 16 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by steimel@chromium.org
, Mar 7 2018