Re-connecting to VPN after correcting the required credentials/certificates fails. |
||||||||
Issue descriptionChrome Version: <From about:version: Google Chrome 65.0.3325.89> Chrome OS Version: <From about:version: Platform 10323.39.0> Chrome OS Platform: <Candy> Network info: <VPN> Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: 1) Configure and connect to openvpn service. 2) Disconnect and edit it with incorrect certificates/credentials. 3) Try to connect with incorrect certs/credentials. This should fail. 4) Click configure and revert to correct certs/credentials. Expected Result: On clicking connect button, OS should try connecting to the service. Actual Result: On, clicking the connect button, opens up the configure window instead of trying to connect to the service. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always. What is the impact to the user, and is there a workaround? If so, what is it? The workaround is to connect by going through the right bottom panel--> vpn instead of chrome://settings page. Feedback report --> https://listnr.corp.google.com/report/85101671237 II) Also, forgetting the private network and adding a new network, I see "Internal error" on the configuration page. Feedback report --> https://listnr.corp.google.com/report/85101816129 Should this be a stable blocker?
,
Feb 23 2018
OK, I think there may be a quick fix for this, but to confirm that it would work, please try the following: Steps 1-4 as above. 5) Refresh the page (ctrl-R) 6) Click 'connect' If I am right, that *should* connect successfully and my quick fix should work.
,
Feb 23 2018
The fix I have in mind is important regardless, so I will go ahead and get it reviewed.
,
Feb 23 2018
I cannot refresh and connect all the time (40-50 %). Sometimes, it still opens up the configure dialog. The configure dialog sets the CA cert to Default after refresh. Also, the save button does not become active, if group name is empty. I filed a another feedback report https://listnr.corp.google.com/report/85102350857 Another thing, I noticed was key icon next to wifi icon does not show up, while reconnecting. This is also not always reproducible. https://listnr.corp.google.com/report/85102342005
,
Feb 23 2018
The configure dialog sets the CA cert to Default after refresh. >> This also does not happen with all the VPN's. I will check, if any particular pattern is causing this.
,
Feb 23 2018
Issues not directly related to this one should please be filed as separate bugs.
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8107ad2808629ec1ba051351336823da29a76bc7 commit 8107ad2808629ec1ba051351336823da29a76bc7 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Feb 28 02:34:29 2018 Settings: Network config: refresh properties after configure After network properties are configured they need to be refreshed so that the 'Connectable' (and other) properties are updated. BUG= 814939 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I586e08671ecd77f91c5084f3b726012d9c447c7f Reviewed-on: https://chromium-review.googlesource.com/938741 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#539668} [modify] https://crrev.com/8107ad2808629ec1ba051351336823da29a76bc7/chrome/browser/resources/settings/internet_page/internet_config.html [modify] https://crrev.com/8107ad2808629ec1ba051351336823da29a76bc7/chrome/browser/resources/settings/internet_page/internet_config.js
,
Feb 28 2018
I have one other partial fix for this pending that should resolve most of these issues. Since 65 is heading to stable tomorrow I will plan to fix this in 66. As mentioned before, it's a bit of an edge case, and there are workarounds.
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cf247600f9ac97acde5ccf81c9634c1144ee0a0 commit 6cf247600f9ac97acde5ccf81c9634c1144ee0a0 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Mar 02 21:06:05 2018 Network config: Explicitly show save or connect Using the configured and saved state of a network to determine whether to show 'Save' or 'Connect' was not always correct; instead let the UI determine which button to show. Also includes a minor improvement to the error messaging. Bug: 814939 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifb9a854826a3e4f45c17cb22ef03ed6b23c6f58c Reviewed-on: https://chromium-review.googlesource.com/943922 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#540624} [modify] https://crrev.com/6cf247600f9ac97acde5ccf81c9634c1144ee0a0/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html [modify] https://crrev.com/6cf247600f9ac97acde5ccf81c9634c1144ee0a0/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.js [modify] https://crrev.com/6cf247600f9ac97acde5ccf81c9634c1144ee0a0/chrome/browser/resources/settings/internet_page/internet_config.html [modify] https://crrev.com/6cf247600f9ac97acde5ccf81c9634c1144ee0a0/chrome/browser/resources/settings/internet_page/internet_config.js [modify] https://crrev.com/6cf247600f9ac97acde5ccf81c9634c1144ee0a0/chrome/browser/resources/settings/internet_page/internet_detail_page.js [modify] https://crrev.com/6cf247600f9ac97acde5ccf81c9634c1144ee0a0/chrome/browser/resources/settings/internet_page/internet_page.js [modify] https://crrev.com/6cf247600f9ac97acde5ccf81c9634c1144ee0a0/chromeos/network/network_connection_handler_impl.cc [modify] https://crrev.com/6cf247600f9ac97acde5ccf81c9634c1144ee0a0/ui/webui/resources/cr_components/chromeos/network/network_config.js
,
Mar 2 2018
,
Mar 3 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a4513a2270fc3824b3f62cc973c64fc2b410aa7 commit 0a4513a2270fc3824b3f62cc973c64fc2b410aa7 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Mar 05 23:01:33 2018 Network config: Explicitly show save or connect Using the configured and saved state of a network to determine whether to show 'Save' or 'Connect' was not always correct; instead let the UI determine which button to show. Also includes a minor improvement to the error messaging. TBR=stevenjb@chromium.org (cherry picked from commit 6cf247600f9ac97acde5ccf81c9634c1144ee0a0) Bug: 814939 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifb9a854826a3e4f45c17cb22ef03ed6b23c6f58c Reviewed-on: https://chromium-review.googlesource.com/943922 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540624} Reviewed-on: https://chromium-review.googlesource.com/949967 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#17} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/0a4513a2270fc3824b3f62cc973c64fc2b410aa7/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html [modify] https://crrev.com/0a4513a2270fc3824b3f62cc973c64fc2b410aa7/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.js [modify] https://crrev.com/0a4513a2270fc3824b3f62cc973c64fc2b410aa7/chrome/browser/resources/settings/internet_page/internet_config.html [modify] https://crrev.com/0a4513a2270fc3824b3f62cc973c64fc2b410aa7/chrome/browser/resources/settings/internet_page/internet_config.js [modify] https://crrev.com/0a4513a2270fc3824b3f62cc973c64fc2b410aa7/chrome/browser/resources/settings/internet_page/internet_detail_page.js [modify] https://crrev.com/0a4513a2270fc3824b3f62cc973c64fc2b410aa7/chrome/browser/resources/settings/internet_page/internet_page.js [modify] https://crrev.com/0a4513a2270fc3824b3f62cc973c64fc2b410aa7/chromeos/network/network_connection_handler_impl.cc [modify] https://crrev.com/0a4513a2270fc3824b3f62cc973c64fc2b410aa7/ui/webui/resources/cr_components/chromeos/network/network_config.js |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by steve...@chromium.org
, Feb 22 2018Status: Assigned (was: Untriaged)