AppBannerManagerBrowserTest.ExperimentalFlowWebAppBannerCancelled is Flaky |
||||
Issue descriptionFindit has detected a flake at test AppBannerManagerBrowserTest.ExperimentalFlowWebAppBannerCancelled. Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I86409406bec56012a62c831ad57b799a8bf45547 Regression range: https://crrev.com/e91c195b4e4b86e89e950b993ea691c276aba981..35bfb10373c5b34c193ad9a7c569d6aa429028fc?pretty=fuller Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy3QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKmAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI2Mjg3L211c19icm93c2VyX3Rlc3RzL1FYQndRbUZ1Ym1WeVRXRnVZV2RsY2tKeWIzZHpaWEpVWlhOMExrVjRjR1Z5YVcxbGJuUmhiRVpzYjNkWFpXSkJjSEJDWVc1dVpYSkRZVzVqWld4c1pXUT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA If this result was incorrect, apply the label Findit-Incorrect-Result, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
,
Feb 23 2018
Found the cause - a racy navigation in JavaScript. Should be a straightforward fix.
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0d257e2981bd146615e72964db5d7d1ee4f4d51 commit c0d257e2981bd146615e72964db5d7d1ee4f4d51 Author: Dominick Ng <dominickn@chromium.org> Date: Fri Feb 23 03:54:35 2018 Deflake AppBannerManagerBrowserTest.ExperimentalFlowWebAppBannerCancelled. This test was flaky because the banner cancellation code also contained a navigation in JavaScript to trigger the C++ callbacks for cancellation. This navigation is necessary for some cancellation tests, but not for others. Deflake the test by removing the JavaScript navigation in this test, where it isn't needed, and leave it in the tests which do need it. BUG= 814928 Change-Id: I6171da41e7c8a7cdc1cd5368371b1fbeeef14d61 Reviewed-on: https://chromium-review.googlesource.com/933561 Reviewed-by: Matt Giuca <mgiuca@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#538691} [modify] https://crrev.com/c0d257e2981bd146615e72964db5d7d1ee4f4d51/chrome/browser/banners/app_banner_manager_browsertest.cc [modify] https://crrev.com/c0d257e2981bd146615e72964db5d7d1ee4f4d51/chrome/test/data/banners/main.js
,
Feb 24 2018
Removing from the sheriff queue. Waiting for Dominick to mark as fixed.
,
Feb 25 2018
No more flakes: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=AppBannerManagerBrowserTest.ExperimentalFlowWebAppBannerCancelled Closing as Fixed.
,
Feb 27 2018
Findit identified the culprit r538253 with confidence 100.0% in the config "chromium.memory / Linux Chromium OS ASan LSan Tests (1)" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy3QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKmAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI2Mjg3L211c19icm93c2VyX3Rlc3RzL1FYQndRbUZ1Ym1WeVRXRnVZV2RsY2tKeWIzZHpaWEpVWlhOMExrVjRjR1Z5YVcxbGJuUmhiRVpzYjNkWFpXSkJjSEJDWVc1dVpYSkRZVzVqWld4c1pXUT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgCDA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Flake Analyzer is in alpha version. Feedback is welcome using component Tools>Test>FindIt>Flakiness ! |
||||
►
Sign in to add a comment |
||||
Comment 1 by dominickn@chromium.org
, Feb 22 2018