New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814928 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: ----



Sign in to add a comment

AppBannerManagerBrowserTest.ExperimentalFlowWebAppBannerCancelled is Flaky

Project Member Reported by Findit, Feb 22 2018

Issue description

I'm looking into this.
Components: UI>Browser>WebAppInstalls
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: dominickn@chromium.org
Status: Assigned (was: Available)
Found the cause - a racy navigation in JavaScript. Should be a straightforward fix.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0d257e2981bd146615e72964db5d7d1ee4f4d51

commit c0d257e2981bd146615e72964db5d7d1ee4f4d51
Author: Dominick Ng <dominickn@chromium.org>
Date: Fri Feb 23 03:54:35 2018

Deflake AppBannerManagerBrowserTest.ExperimentalFlowWebAppBannerCancelled.

This test was flaky because the banner cancellation code also contained
a navigation in JavaScript to trigger the C++ callbacks for
cancellation. This navigation is necessary for some cancellation tests,
but not for others.

Deflake the test by removing the JavaScript navigation in this test,
where it isn't needed, and leave it in the tests which do need it.

BUG= 814928 

Change-Id: I6171da41e7c8a7cdc1cd5368371b1fbeeef14d61
Reviewed-on: https://chromium-review.googlesource.com/933561
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538691}
[modify] https://crrev.com/c0d257e2981bd146615e72964db5d7d1ee4f4d51/chrome/browser/banners/app_banner_manager_browsertest.cc
[modify] https://crrev.com/c0d257e2981bd146615e72964db5d7d1ee4f4d51/chrome/test/data/banners/main.js

Labels: -Sheriff-Chromium
Removing from the sheriff queue. Waiting for Dominick to mark as fixed.
Project Member

Comment 6 by Findit, Feb 27 2018

Findit identified the culprit r538253 with confidence 100.0% in the config "chromium.memory / Linux Chromium OS ASan LSan Tests (1)"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy3QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKmAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI2Mjg3L211c19icm93c2VyX3Rlc3RzL1FYQndRbUZ1Ym1WeVRXRnVZV2RsY2tKeWIzZHpaWEpVWlhOMExrVjRjR1Z5YVcxbGJuUmhiRVpzYjNkWFpXSkJjSEJDWVc1dVpYSkRZVzVqWld4c1pXUT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgCDA

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Flake Analyzer is in alpha version.
Feedback is welcome using component Tools>Test>FindIt>Flakiness !

Sign in to add a comment