New issue
Advanced search Search tips

Issue 814917 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Cros splitscreen - Crash when dragging a window around in overview mode

Project Member Reported by x...@chromium.org, Feb 22 2018

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) In tablet overview mode, tap on a window item and drag it around but do not snap the window
(2) Release the tap

What is the expected result?
Window item should return to its previous position in window grid

What happens instead?
Chrome crashes

Call stack:

#0  ui::Layer::GetTargetOpacity () at ../../ui/compositor/layer.cc:524
#1  0x00005a3f11c5555d in ash::WindowSelectorItem::CaptionContainerView::AnimateLayerOpacity () at ../../ash/wm/overview/window_selector_item.cc:601
#2  0x00005a3f11c56ba0 in SetCloseButtonVisibility () at ../../ash/wm/overview/window_selector_item.cc:518
#3  OnSelectorItemDragEnded (this=0x3c5ddf39da80)
    at ../../ash/wm/overview/window_selector_item.cc:795
#4  ResetDraggedWindowGesture (this=0x3c5ddf39da80)
    at ../../ash/wm/overview/window_selector_item.cc:936
#5  ash::(anonymous namespace)::ShieldButton::OnGestureEvent (this=<optimized out>, 
    event=0x3c5de10b5b60) at ../../ash/wm/overview/window_selector_item.cc:242
#6  0x00005a3f10377292 in DispatchEvent () at ../../ui/events/event_dispatcher.cc:191
#7  ui::EventDispatcher::ProcessEvent (this=0x7ffc17b47a60, target=0x3c5de1058c28, 
    event=0x3c5de10b5b60) at ../../ui/events/event_dispatcher.cc:139
#8  0x00005a3f1037709c in DispatchEventToTarget (this=0x3c5de1c4d768, 
    target=0x3c5de1058c28, event=0x3c5de10b5b60)
    at ../../ui/events/event_dispatcher.cc:86
#9  ui::EventDispatcherDelegate::DispatchEvent (this=0x3c5de1c4d768, 
    target=0x3c5de1058c28, event=0x3c5de10b5b60)
    at ../../ui/events/event_dispatcher.cc:58
#10 0x00005a3f130be66f in ui::EventProcessor::OnEventFromSource (this=0x3c5de1c4d768, 
    event=0x3c5de1e8ec40) at ../../ui/events/event_processor.cc:57
#11 0x00005a3f10377ab4 in DeliverEventToSink (this=0x3c5ddcdcf148, 
    event=0x3c5de1e8ec40) at ../../ui/events/event_source.cc:73
#12 ui::EventSource::SendEventToSink (this=0x3c5ddcdcf148, event=<optimized out>)
    at ../../ui/events/event_source.cc:51
#13 0x00005a3f10377292 in DispatchEvent (this=0x7ffc17b47bf0, handler=0x3c5ddef959c8, 
    event=<optimized out>) at ../../ui/events/event_dispatcher.cc:191
#14 ui::EventDispatcher::ProcessEvent (this=0x7ffc17b47bf0, target=0x3c5ddefe4520, 
    event=0x3c5de1e8ec40) at ../../ui/events/event_dispatcher.cc:139
#15 0x00005a3f1037709c in DispatchEventToTarget (this=0x3c5ddc65b640, 
    target=0x3c5ddefe4520, event=0x3c5de1e8ec40)
    at ../../ui/events/event_dispatcher.cc:86

Seems caused by https://chromium-review.googlesource.com/c/chromium/src/+/911849. Sammie, could you take a look?

 
Status: Started (was: Untriaged)
Issue 816713 has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/218a9396dd8525895abb20bc3ab86f4cf6140f51

commit 218a9396dd8525895abb20bc3ab86f4cf6140f51
Author: Sammie Quon <sammiequon@google.com>
Date: Tue Feb 27 20:00:22 2018

overview: Fix crash in old ui when dragging item.

Crash was caused when trying to animate layer which only exist in new ui.

Test: manual
Bug:  814917 
Change-Id: I95079d32a50c18cd6039e0d451ffee6fc6efc899
Reviewed-on: https://chromium-review.googlesource.com/934965
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539531}
[modify] https://crrev.com/218a9396dd8525895abb20bc3ab86f4cf6140f51/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/218a9396dd8525895abb20bc3ab86f4cf6140f51/ash/wm/overview/window_selector_item.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on CrOS version: 10451.0.0, 66.0.3358.0 cave, scarlet- dru devices.

Sign in to add a comment