New issue
Advanced search Search tips

Issue 814916 link

Starred by 1 user
Status: Fixed
Owner:
cblume@chromium.org
Closed: Feb 2018
Cc:
ericrk@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Refactor surface property sync

Project Member Reported by cblume@chromium.org, Feb 22 2018 
The exact* same code shows up in RWHVA::
OnDeviceScaleFactorChanged()
WasResized()
InternalSetBounds()

That code can be refactored out.


*There is one tiny difference, notifying the host of the resize or not. But that can be a parameter to the refactored function.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ba1fb3878f789f89267893d1175d4f2911c55a0

commit 6ba1fb3878f789f89267893d1175d4f2911c55a0
Author: Chris Blume <cblume@chromium.org>
Date: Mon Feb 26 18:06:24 2018

Refactor surface property sync

The exact* same code shows up in RWHVA::
OnDeviceScaleFactorChanged()
WasResized()
InternalSetBounds()

This patch refactors that code out to its own function.

*There is one tiny difference, notifying the host of the resize or not.

Bug:  814916 
Change-Id: I9336d476a904930cd6a700ee0700d7685000c00c
Reviewed-on: https://chromium-review.googlesource.com/932830
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539199}
[modify] https://crrev.com/6ba1fb3878f789f89267893d1175d4f2911c55a0/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/6ba1fb3878f789f89267893d1175d4f2911c55a0/content/browser/renderer_host/render_widget_host_view_aura.h

Comment 2 by cblume@chromium.org, Feb 27 2018

Status: Fixed (was: Started)
►

Sign in to add a comment