New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814915 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Temporary RunFlakeSwarmingTaskPipeline

Project Member Reported by lijeffrey@chromium.org, Feb 22 2018

Issue description

New asynchronous pipeline for running swarming tasks is not ready yet. Create a temporary one that uses the old pipelines to unblock testing of the new Flake Analyzer pipelines
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4bd769da5e1b96e35313a1256f50a1bbace38361

commit 4bd769da5e1b96e35313a1256f50a1bbace38361
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon Feb 26 19:13:35 2018

[Findit] Flake Analyzer - Implementing temporary RunFlakeSwarmingTaskPipeline

This is by no means a permanent solution, but rather just to hook up old
pipelines to unblock testing the other new pipeline flow until the new
asynchronous run swarming task pipeline is ready.

Soon:
1. model/flake/flake_swarming_task.py will be deprecated entirely
2. TriggerFlakeSwarmingTaskPipeline will be deprecated
3. ProcessFlakeSwarmingTaskResultPipeline will be deprecated
4. A new asynchronous pipeline for triggering swarming tasks will take over
   all responsibilities for triggering and waiting for swarming tasks to
   complete, with this pipeline becoming responsible for flake swarming task-
   specific operations only.

Bug:  814915 
Change-Id: I314e1ff6efea5e88c702922936bb8f54e70c4239
Reviewed-on: https://chromium-review.googlesource.com/932751
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>

[modify] https://crrev.com/4bd769da5e1b96e35313a1256f50a1bbace38361/appengine/findit/pipelines/flake_failure/run_flake_swarming_task_pipeline.py
[modify] https://crrev.com/4bd769da5e1b96e35313a1256f50a1bbace38361/appengine/findit/pipelines/flake_failure/test/determine_approximate_pass_rate_pipeline_test.py
[add] https://crrev.com/4bd769da5e1b96e35313a1256f50a1bbace38361/appengine/findit/pipelines/flake_failure/test/run_flake_swarming_task_pipeline_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/17de0ffb56319b69123eacbe03f2ab9e2b56d240

commit 17de0ffb56319b69123eacbe03f2ab9e2b56d240
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon Feb 26 20:01:48 2018

Revert "[Findit] Flake Analyzer - Implementing temporary RunFlakeSwarmingTaskPipeline"

This reverts commit 4bd769da5e1b96e35313a1256f50a1bbace38361.

Reason for revert: There may be a flaky test here causing Findit's python tests to fail in CQ

Original change's description:
> [Findit] Flake Analyzer - Implementing temporary RunFlakeSwarmingTaskPipeline
> 
> This is by no means a permanent solution, but rather just to hook up old
> pipelines to unblock testing the other new pipeline flow until the new
> asynchronous run swarming task pipeline is ready.
> 
> Soon:
> 1. model/flake/flake_swarming_task.py will be deprecated entirely
> 2. TriggerFlakeSwarmingTaskPipeline will be deprecated
> 3. ProcessFlakeSwarmingTaskResultPipeline will be deprecated
> 4. A new asynchronous pipeline for triggering swarming tasks will take over
>    all responsibilities for triggering and waiting for swarming tasks to
>    complete, with this pipeline becoming responsible for flake swarming task-
>    specific operations only.
> 
> Bug:  814915 
> Change-Id: I314e1ff6efea5e88c702922936bb8f54e70c4239
> Reviewed-on: https://chromium-review.googlesource.com/932751
> Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
> Reviewed-by: Brandon Wylie <wylieb@chromium.org>

TBR=stgao@chromium.org,robertocn@chromium.org,lijeffrey@chromium.org,chanli@chromium.org,wylieb@chromium.org

Change-Id: If32fa991c71ac65a8225b15f1ee1b10fd64c7627
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  814915 
Reviewed-on: https://chromium-review.googlesource.com/938181
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/17de0ffb56319b69123eacbe03f2ab9e2b56d240/appengine/findit/pipelines/flake_failure/run_flake_swarming_task_pipeline.py
[modify] https://crrev.com/17de0ffb56319b69123eacbe03f2ab9e2b56d240/appengine/findit/pipelines/flake_failure/test/determine_approximate_pass_rate_pipeline_test.py
[delete] https://crrev.com/dc69e3c1f2585115ad3f7a81fdbfeebc971515e6/appengine/findit/pipelines/flake_failure/test/run_flake_swarming_task_pipeline_test.py

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/630d126e16fb605c68abc1d1847fd47d5f428242

commit 630d126e16fb605c68abc1d1847fd47d5f428242
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon Feb 26 22:02:47 2018

Reland "[Findit] Flake Analyzer - Implementing temporary RunFlakeSwarmingTaskPipeline"

This is a reland of 4bd769da5e1b96e35313a1256f50a1bbace38361.

Original change's description:
> [Findit] Flake Analyzer - Implementing temporary RunFlakeSwarmingTaskPipeline
> 
> This is by no means a permanent solution, but rather just to hook up old
> pipelines to unblock testing the other new pipeline flow until the new
> asynchronous run swarming task pipeline is ready.
> 
> Soon:
> 1. model/flake/flake_swarming_task.py will be deprecated entirely
> 2. TriggerFlakeSwarmingTaskPipeline will be deprecated
> 3. ProcessFlakeSwarmingTaskResultPipeline will be deprecated
> 4. A new asynchronous pipeline for triggering swarming tasks will take over
>    all responsibilities for triggering and waiting for swarming tasks to
>    complete, with this pipeline becoming responsible for flake swarming task-
>    specific operations only.
> 
> Bug:  814915 
> Change-Id: I314e1ff6efea5e88c702922936bb8f54e70c4239
> Reviewed-on: https://chromium-review.googlesource.com/932751
> Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
> Reviewed-by: Brandon Wylie <wylieb@chromium.org>

Bug:  814915 
Change-Id: I6ef29ae08315af5039319586edb8150f34c8a49f
Reviewed-on: https://chromium-review.googlesource.com/938304
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/630d126e16fb605c68abc1d1847fd47d5f428242/appengine/findit/pipelines/flake_failure/run_flake_swarming_task_pipeline.py
[modify] https://crrev.com/630d126e16fb605c68abc1d1847fd47d5f428242/appengine/findit/pipelines/flake_failure/test/determine_approximate_pass_rate_pipeline_test.py
[add] https://crrev.com/630d126e16fb605c68abc1d1847fd47d5f428242/appengine/findit/pipelines/flake_failure/test/run_flake_swarming_task_pipeline_test.py

Status: Fixed (was: Assigned)

Sign in to add a comment