New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814909 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

clean up metrics in gpu pipeline

Project Member Reported by yiyix@chromium.org, Feb 22 2018

Issue description

Investigating all the compositing metrics in the GPU pipeline. complete list: 
https://docs.google.com/spreadsheets/d/1kW6GUpeNr9SaU6nT2mA-Om8vQ3DdP4ZMO2YlIW0-RUk/edit#gid=0

Clean up the duplicated ones and update the inaccurate ones. 
 

Comment 1 by yiyix@chromium.org, Feb 22 2018

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/147188b711f774dc60279a88d3842b2f3624d292

commit 147188b711f774dc60279a88d3842b2f3624d292
Author: yiyix <yiyix@chromium.org>
Date: Fri Feb 23 04:51:03 2018

viz: Remove duplicated metrics in RasterTaskType

Metrics listed in RasterTaskType record 1. for both gpu and software raster,
2. for gpu raster and 3. for software rater. The metric 1 provided duplicated
information as metrics 2 and 3. Note that the only metrics in RasterTaskType
record information for both gpu and software rasterization are
RasterTask.RasterPixelsPerMs and RasterTask.RasterUs.

Bug: 814909
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I6215b09227234b845100a7222c175d12e5624ce9
Reviewed-on: https://chromium-review.googlesource.com/932627
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538703}
[modify] https://crrev.com/147188b711f774dc60279a88d3842b2f3624d292/cc/tiles/tile_manager.cc
[modify] https://crrev.com/147188b711f774dc60279a88d3842b2f3624d292/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6c7b426118467b13144e0abb54e91770eae5360

commit e6c7b426118467b13144e0abb54e91770eae5360
Author: yiyix <yiyix@chromium.org>
Date: Fri Mar 09 18:34:28 2018

VIZ: Adding the missing unit to viz metrics

Added the missing unit to metrics in
Compositing.SurfaceAggregator.SurfaceDrawQuad.*.

Bug: 814909
Change-Id: Id140c4ddf3cdfc606de6373c586273f7d3a9f144
Reviewed-on: https://chromium-review.googlesource.com/956885
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542178}
[modify] https://crrev.com/e6c7b426118467b13144e0abb54e91770eae5360/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e36928e77dc79a6aaa532ea9a13ebd87f415e0a

commit 7e36928e77dc79a6aaa532ea9a13ebd87f415e0a
Author: yiyix <yiyix@chromium.org>
Date: Tue Jul 31 04:50:26 2018

graphic metrics: add metrics to measure BeginFrame travel time

Add metrics to measure the amount of time it takes for the BeginFrame
to travel to the Client from the DisplayCompositor.

Bug:814909

related design doc:
https://docs.google.com/document/d/1XIaAPkajbML0s0neajasWzvt856dUjF_1zAWO5KykCQ/edit

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6a13b5fcdbfc458e2d2dc84312e2e37459c11ac4
Reviewed-on: https://chromium-review.googlesource.com/1146337
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579313}
[modify] https://crrev.com/7e36928e77dc79a6aaa532ea9a13ebd87f415e0a/cc/mojo_embedder/async_layer_tree_frame_sink.cc
[modify] https://crrev.com/7e36928e77dc79a6aaa532ea9a13ebd87f415e0a/tools/metrics/histograms/histograms.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02564469c5a37896f8d46feaf283521152a55eb4

commit 02564469c5a37896f8d46feaf283521152a55eb4
Author: yiyix <yiyix@chromium.org>
Date: Tue Sep 11 21:13:55 2018

graphic metrics: add metrics to measure SubmitCompositorFrameAfterBeginFrame

Add metrics to measure the amount of time it takes to prepare
CompositorFrame on the client side:
GraphicsPipeline.(Browser|Renderer).SubmitCompositorFrameAfterBeginFrame.

Bug:814909

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic81532c8bec28b43ec1fa20ff3634be0fbf5f84a
Reviewed-on: https://chromium-review.googlesource.com/1154630
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590476}
[modify] https://crrev.com/02564469c5a37896f8d46feaf283521152a55eb4/cc/mojo_embedder/async_layer_tree_frame_sink.cc
[modify] https://crrev.com/02564469c5a37896f8d46feaf283521152a55eb4/cc/mojo_embedder/async_layer_tree_frame_sink.h
[modify] https://crrev.com/02564469c5a37896f8d46feaf283521152a55eb4/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f53e53277f925c7ba970e1614b573d31a746acc8

commit f53e53277f925c7ba970e1614b573d31a746acc8
Author: Fady Samuel <fsamuel@chromium.org>
Date: Wed Sep 12 16:34:41 2018

GraphicsPipeline Reporting: Don't report missed BeginFrames

Don't report GraphicsPipeline.*.ReceivedBeginFrame UMA for missed BeginFrames.
Missed BeginFrames use the frame time of the last received BeginFrame. If the
client hasn't been updating in a while then that last BeginFrame could've been
received arbitrarily long ago, skewing ReceivedBeginFrame times significantly
upward.

Bug: 814909
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1ff2426818a50c26f11d2691d8d2c1ba5b6d2919
Reviewed-on: https://chromium-review.googlesource.com/1221695
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590716}
[modify] https://crrev.com/f53e53277f925c7ba970e1614b573d31a746acc8/cc/mojo_embedder/async_layer_tree_frame_sink.cc

Sign in to add a comment