Layout Test http/tests/credentialmanager/credentialscontainer-create-from-nested-frame.html is flaky |
||||
Issue descriptionThe following layout test is flaky: http/tests/credentialmanager/credentialscontainer-create-from-nested-frame.html Dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=webkit_layout_tests&tests=http%2Ftests%2Fcredentialmanager%2Fcredentialscontainer-create-from-nested-frame.html On the failed runs there is an extra line at the beginning of the output: CONSOLE ERROR: Uncaught (in promise) SecurityError: Effective domain is not a valid domain.
,
Feb 22 2018
,
Feb 22 2018
Transferring owner from earlier issue
,
Feb 25 2018
Security checks should not be flaky, so this is quite concerning. Given that I already have a Mac workstation, I will try to reproduce this locally tomorrow.
,
Feb 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92631643373387137e05a8c4880e8b50426dae33 commit 92631643373387137e05a8c4880e8b50426dae33 Author: Balazs Engedy <engedy@chromium.org> Date: Mon Feb 26 16:38:49 2018 Prevent spurious WebAuthn tests running on http://127.0.0.1 origins. Public-key credentials can only be accessed through the WebAuthn API by origins that have a valid effective domain (not an IP address, among other requirements). Corresponding layout tests therefore are served on the origin `https://subdomain.example.test:8443`, which is implemented by means of the test redirecting itself by setting `document.location` to a URL under this origin. However, setting `document.location` merely schedules a navigation, and JS execution continues for a short time in the original document. This occasionally resulted in some tests ending up being executed under the original http://127.0.0.1 origin, at race with the navigation. This resulted in uncaught SecurityErrors and console errors, which, in turn, made the the tests flaky. This CL prevents this by stalling test execution in the original document by scheduling a promise_test that never completes. Bug: 814907 Change-Id: I531f20c286dc4ba04f1820c9cf49d0a0e00a11ce Reviewed-on: https://chromium-review.googlesource.com/937501 Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#539156} [modify] https://crrev.com/92631643373387137e05a8c4880e8b50426dae33/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/92631643373387137e05a8c4880e8b50426dae33/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html [modify] https://crrev.com/92631643373387137e05a8c4880e8b50426dae33/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-from-nested-frame.html [modify] https://crrev.com/92631643373387137e05a8c4880e8b50426dae33/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html [modify] https://crrev.com/92631643373387137e05a8c4880e8b50426dae33/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-from-nested-frame.html
,
Feb 26 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Feb 22 2018