WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/922686

Hi,

This window is for Chromium bugs reporting. Note that this is not a localization related.

Looping in Engineering Team for review.

Regards!

This isn't infra because it's not an infra-owned or infra-specific tool (e.g. something in depot_tools or the infra repos). I don't really know what it is, although UI>Localization sure sounds the most relevant. What is that for if not code and tools related to localization?

NOt infra, I think it was added automatically.
Engineering Team has been loop in. If this is Google related issue, then they will response.

Supposed to be this window is for chromium or chrome browser reporting issue only.

Regards!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac34055c631e859dd860a63441770f60aa5cc3d4

commit ac34055c631e859dd860a63441770f60aa5cc3d4
Author: Mustafa Emre Acer <meacer@chromium.org>
Date: Thu Mar 08 22:07:44 2018

Add a tool to upload translation screenshots to content addressed Cloud Storage

This tool scans for any screenshots (png only) associated with grd files and uploads them to Google Cloud Storage using upload_to_google_storage.py.

upload_to_google_storage.py is a tool that maintains content addressed files. It stores files with their sha1 hashes as filenames.

The storage bucket name used in the tool is tentative.

For details, see the design doc at http://go/chrome-translation-screenshots#heading=h.cyt0azox2105

Change-Id: Ide06aa679489a65887df9c58948c8adde12d3eba
Bug:  814901 
Reviewed-on: https://chromium-review.googlesource.com/922686
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541898}
[modify] https://crrev.com/ac34055c631e859dd860a63441770f60aa5cc3d4/tools/gritsettings/translation_expectations.pyl
[add] https://crrev.com/ac34055c631e859dd860a63441770f60aa5cc3d4/tools/translation/OWNERS
[add] https://crrev.com/ac34055c631e859dd860a63441770f60aa5cc3d4/tools/translation/PRESUBMIT.py
[add] https://crrev.com/ac34055c631e859dd860a63441770f60aa5cc3d4/tools/translation/README.md
[add] https://crrev.com/ac34055c631e859dd860a63441770f60aa5cc3d4/tools/translation/helper/__init__.py
[add] https://crrev.com/ac34055c631e859dd860a63441770f60aa5cc3d4/tools/translation/helper/translation_helper.py
[add] https://crrev.com/ac34055c631e859dd860a63441770f60aa5cc3d4/tools/translation/helper/translation_helper_unittest.py
[add] https://crrev.com/ac34055c631e859dd860a63441770f60aa5cc3d4/tools/translation/testdata/not_translated.grd
[add] https://crrev.com/ac34055c631e859dd860a63441770f60aa5cc3d4/tools/translation/testdata/part.grdp
[add] https://crrev.com/ac34055c631e859dd860a63441770f60aa5cc3d4/tools/translation/testdata/test.grd
[add] https://crrev.com/ac34055c631e859dd860a63441770f60aa5cc3d4/tools/translation/testdata/test_en-GB.xtb
[add] https://crrev.com/ac34055c631e859dd860a63441770f60aa5cc3d4/tools/translation/testdata/test_grd/IDS_TEST_STRING1.png
[add] https://crrev.com/ac34055c631e859dd860a63441770f60aa5cc3d4/tools/translation/testdata/translation_expectations.pyl
[add] https://crrev.com/ac34055c631e859dd860a63441770f60aa5cc3d4/tools/translation/upload_screenshots.py
[add] https://crrev.com/ac34055c631e859dd860a63441770f60aa5cc3d4/tools/translation/upload_screenshots_unittest.py

As per comment #7, as the fix has already landed. Hence, removing Needs-TestConfirmation.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4181d4019a03e4366a1117a89d9d989734e4b6a

commit a4181d4019a03e4366a1117a89d9d989734e4b6a
Author: Mustafa Emre Acer <meacer@chromium.org>
Date: Thu Mar 22 17:45:17 2018

Translation screenshot uploader: Find images associated with grdp files

Screenshots can be added for both grd and grdp files. The current
upload tool only finds screenshots for grd files. This CL adds
support for grdp files and files added via <structure> tags.

Bug:  814901 
Change-Id: I2cb427b502e050c1b3ee6e39fa7bd94f26e54060
Reviewed-on: https://chromium-review.googlesource.com/974657
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545142}
[add] https://crrev.com/a4181d4019a03e4366a1117a89d9d989734e4b6a/tools/translation/testdata/part_grdp/IDS_PART_STRING2.png
[modify] https://crrev.com/a4181d4019a03e4366a1117a89d9d989734e4b6a/tools/translation/upload_screenshots.py
[modify] https://crrev.com/a4181d4019a03e4366a1117a89d9d989734e4b6a/tools/translation/upload_screenshots_unittest.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ae13f65040719dc7bb7e98a23c51aeaa5462e78

commit 0ae13f65040719dc7bb7e98a23c51aeaa5462e78
Author: Mustafa Emre Acer <meacer@chromium.org>
Date: Thu Mar 22 17:59:22 2018

Use production GCS bucket name for translation screenshots and exit properly

Bug:  814901 
Change-Id: Ie4cc59294b1301c19a22e587db8b59c3ad104bb2
Reviewed-on: https://chromium-review.googlesource.com/974364
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545147}
[modify] https://crrev.com/0ae13f65040719dc7bb7e98a23c51aeaa5462e78/tools/translation/upload_screenshots.py