Add a presubmit for translation screenshots |
|||||||
Issue descriptionTranslation screenshots project will ask developers to upload screenshots of UI changes. Add a presubmit that: - Determines which UI strings are added/modified/removed - Checks if the CL contains images (more accurately, fingerprints of the images uploaded to Google Cloud Storage) - If not, asks the developer to upload the images and add their fingerprints to the CL
,
Feb 23 2018
Hi, This window is for Chromium bugs reporting. Note that this is not a localization related. Looping in Engineering Team for review. Regards!
,
Feb 23 2018
,
Feb 23 2018
,
Feb 23 2018
Not sure there's really a component for presubmit changes. Maybe client>chrome.
,
Mar 14 2018
Removing 'Needs-TestConfirmation' label as this issue is Infra related and out of scope of triaging at TE end. Also this issue is being worked on by Dev. Thanks..
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29bf6ac99c02e9ce0519fb886322e2266c7e2968 commit 29bf6ac99c02e9ce0519fb886322e2266c7e2968 Author: Mustafa Emre Acer <meacer@chromium.org> Date: Mon Jul 30 21:42:14 2018 Add presubmit checks for translation screenshots This CL adds a new presubmit check to verify that new or modified translation strings have associated screenshots. It does this by parsing the modified grd/grdp file, loading the messages and comparing them with old messages. It then checks whether the corresponding screenshot file exists. See go/chrome-translation-screenshots for design details. Change-Id: I981b3a95b66e2df8eee1d2b48223251fa0ff03a7 Bug: 814899 Reviewed-on: https://chromium-review.googlesource.com/872199 Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#579182} [modify] https://crrev.com/29bf6ac99c02e9ce0519fb886322e2266c7e2968/PRESUBMIT.py [modify] https://crrev.com/29bf6ac99c02e9ce0519fb886322e2266c7e2968/PRESUBMIT_test.py
,
Aug 3
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mea...@chromium.org
, Feb 22 2018