New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814891 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Change moblab ID generation to not depend on a USB ethernet dongle

Project Member Reported by haddowk@chromium.org, Feb 22 2018

Issue description

The moblab id currently uses the non USB ethernet port as a prefix for every moblab-id.

Moblab-id's change on every powerwash by design, but we need a stable prefix that survives powerwash so we can join up data from the same physical moblab.

To get a long term stable identifier for a moblab - use the serial number rather than a mac address.

sudo vpd -g "mlb_serial_number"

Seems to be the most reliable way to get a serial number on guado and fizz

 
Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/7fc2d93a9f7c6c73fdd8d087b80eee1c69aa97dd

commit 7fc2d93a9f7c6c73fdd8d087b80eee1c69aa97dd
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri Mar 02 06:12:01 2018

[moblab] Add ability of apache to call vpd command.

Required to get the serial number of the device on the UI and
in RPC calls.

TEST=build and ran on moblab
BUG= chromium:814891 

Change-Id: Ia4f6a45ef2d414a962e48e52558b3978bdce5d10
Reviewed-on: https://chromium-review.googlesource.com/944613
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/7fc2d93a9f7c6c73fdd8d087b80eee1c69aa97dd/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-9999.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a4b55dd2b1387e41544c64c4793992b906272234

commit a4b55dd2b1387e41544c64c4793992b906272234
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri Mar 02 21:25:13 2018

[moblab] Change the persistent id for moblab from mac to serial.

As next gen moblab have two nics we can no longer use thei
ethernet device type to find a consistent mac address.

Use the device serial number in place of the mac address.

CQ-DEPEND=CL:944613
BUG= chromium:814891 
TEST=build and tested on moblab

Change-Id: I76284984c287054146a336a8972e206f4fe6b224
Reviewed-on: https://chromium-review.googlesource.com/944807
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/a4b55dd2b1387e41544c64c4793992b906272234/frontend/afe/moblab_rpc_interface.py
[modify] https://crrev.com/a4b55dd2b1387e41544c64c4793992b906272234/site_utils/cloud_console_client_unittest.py
[modify] https://crrev.com/a4b55dd2b1387e41544c64c4793992b906272234/client/common_lib/utils.py
[modify] https://crrev.com/a4b55dd2b1387e41544c64c4793992b906272234/site_utils/cloud_console_client.py
[modify] https://crrev.com/a4b55dd2b1387e41544c64c4793992b906272234/frontend/client/src/autotest/moblab/wizard/ConfigWizard.java
[modify] https://crrev.com/a4b55dd2b1387e41544c64c4793992b906272234/frontend/client/src/autotest/moblab/rpc/VersionInfo.java
[modify] https://crrev.com/a4b55dd2b1387e41544c64c4793992b906272234/client/common_lib/utils_unittest.py

Status: Fixed (was: Assigned)

Sign in to add a comment