New issue
Advanced search Search tips

Issue 814890 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

33kb regression in resource_sizes (MonochromePublic.apk) at 537684:537684

Project Member Reported by agrieve@chromium.org, Feb 22 2018

Issue description

Caused by “[bigint] Add BigInt64Array, BigUint64Array”

v8 Commit: bd0b32f5458024b6bee6b7e0af569c4101a9cba3

Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=537684

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Here's the supersize diff output:

Section Legend: t=.text, r=.rodata, R=.data.rel.ro, d=.data, b=.bss, p=.pak.translations, P=.pak.nontranslated, o=.other
Index | Running Total | Section@Address | Δ PSS (Δ size_without_padding) | Path
------------------------------------------------------------
~ 0)      20460 (60.6%) o@0x0        20460 (1364284->1384744) {{no path}}
               assets/snapshot_blob_32.bin
~ 1)      19258 (57.0%) o@0x0        -1202 (8894->7692) {{no path}}
               ELF file overhead
+ 2)      19870 (58.9%) t@0x1496d98  612 (0->612)       v8/src/code-stub-assembler.cc
               v8::internal::CodeStubAssembler::EmitElementStore
- 3)      19310 (57.2%) t@0x0        -560 (560->0)      v8/src/code-stub-assembler.cc
               v8::internal::CodeStubAssembler::EmitElementStore
~ 4)      19702 (58.4%) t@0x14d86d0  392 (2528->2920)   v8/src/compiler/js-builtin-reducer.cc
               v8::internal::compiler::JSBuiltinReducer::ReduceTypedArrayToStringTag
+ 5)      20066 (59.4%) t@0x1594278  364 (0->364)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::SliceWithResultImpl
+ 6)      20430 (60.5%) t@0x1594bbe  364 (0->364)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::SliceWithResultImpl
+ 7)      20771 (61.5%) t@0x1722574  341 (0->341)       third_party/android_ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libc++_static.a/algorithm.o
               std::__ndk1::__sort<> (num_aliases=2)
+ 8)      21112 (62.5%) t@0x1722574  341 (0->341)       v8/src/runtime/runtime-typedarray.cc
               std::__ndk1::__sort<> (num_aliases=2)
+ 9)      21452 (63.5%) t@0x171cc24  340 (0->340)       v8/src/runtime/runtime-test.cc
               v8::internal::Stats_Runtime_HasFixedBigInt64Elements
+ 10)     21792 (64.6%) t@0x171ca5c  340 (0->340)       v8/src/runtime/runtime-test.cc
               v8::internal::Stats_Runtime_HasFixedBigUint64Elements
+ 11)     22084 (65.4%) t@0x16c724c  292 (0->292)       v8/src/runtime/runtime-bigint.cc
               v8::internal::Stats_Runtime_ToBigInt
+ 12)     22368 (66.3%) t@0x1594704  284 (0->284)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::CopyElementsHandleSlow
+ 13)     22652 (67.1%) t@0x1595008  284 (0->284)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::CopyElementsHandleSlow
~ 14)     22420 (66.4%) t@0x1614760  -232 (6068->5836)  v8/src/isolate.cc
               v8::internal::Isolate::Init
~ 15)     22640 (67.1%) t@0x1461ca0  220 (20572->20792) v8/src/bootstrapper.cc
               v8::internal::Genesis::InitializeGlobal
+ 16)     22859 (67.7%) t@0xe237ac   219 (0->219)       v8/src/runtime/runtime-typedarray.cc
               std::__ndk1::__sort<> (num_aliases=3)
+ 17)     23075 (68.4%) t@0x15940da  216 (0->216)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::CollectValuesOrEntriesImpl
+ 18)     23291 (69.0%) t@0x1594a20  216 (0->216)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::CollectValuesOrEntriesImpl
+ 19)     23505 (69.6%) t@0x1580924  214 (0->214)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::CopyElementsFromTypedArray (num_aliases=2)
+ 20)     23719 (70.3%) t@0x1580924  214 (0->214)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::CopyElementsFromTypedArray (num_aliases=2)
~ 21)     23899 (70.8%) t@0x16a3078  180 (8616->8796)   v8/src/profiler/heap-snapshot-generator.cc
               v8::internal::V8HeapExplorer::ExtractContextReferences
+ 22)     24077 (71.3%) t@0x1594470  178 (0->178)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::IncludesValueImpl
+ 23)     24255 (71.9%) t@0x1594db6  178 (0->178)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::IncludesValueImpl
+ 24)     24429 (72.4%) t@0x14ace40  174 (0->174)       v8/src/compiler/code-assembler.cc
               v8::internal::compiler::CodeAssembler::CallRuntimeImpl<>
+ 25)     24597 (72.9%) R@0x2a5738c  168 (0->168)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<> [vtable]
+ 26)     24765 (73.4%) R@0x2a57434  168 (0->168)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<> [vtable]
+ 27)     24929 (73.8%) t@0x15941b2  164 (0->164)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::AddElementsToKeyAccumulatorImpl
+ 28)     25093 (74.3%) t@0x1594af8  164 (0->164)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::AddElementsToKeyAccumulatorImpl
+ 29)     25257 (74.8%) t@0x1594660  164 (0->164)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::CopyElementsHandleImpl
+ 30)     25421 (75.3%) t@0x1594f64  164 (0->164)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::CopyElementsHandleImpl
+ 31)     25585 (75.8%) t@0x1594820  164 (0->164)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::CreateListFromArrayLikeImpl
+ 32)     25749 (76.3%) t@0x1595124  164 (0->164)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::CreateListFromArrayLikeImpl
~ 33)     25905 (76.7%) t@0x1467b64  156 (508->664)     v8/src/bootstrapper.cc
               v8::internal::Genesis::InitializeGlobal_harmony_bigint
~ 34)     26045 (77.2%) t@0x15dcd28  140 (5608->5748)   v8/src/heap/object-stats.cc
               v8::internal::ObjectStats::PrintJSON
+ 35)     26185 (77.6%) t@0x15943e4  140 (0->140)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::FillImpl
+ 36)     26325 (78.0%) t@0x1594d2a  140 (0->140)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::FillImpl
+ 37)     26465 (78.4%) t@0x1594522  140 (0->140)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::IndexOfValueImpl
+ 38)     26605 (78.8%) t@0x1594e68  140 (0->140)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::IndexOfValueImpl
+ 39)     26740 (79.2%) t@0x1722a1c  135 (0->134)       third_party/android_ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libc++_static.a/algorithm.o
               std::__ndk1::__insertion_sort_incomplete<> (num_aliases=2)
+ 40)     26875 (79.6%) t@0x1722a1c  135 (0->134)       v8/src/runtime/runtime-typedarray.cc
               std::__ndk1::__insertion_sort_incomplete<> (num_aliases=2)
+ 41)     27003 (80.0%) r@0x46b5f6   128 (0->128)       v8/src/elements.cc
               string literal
+ 42)     27130 (80.4%) r@0x46b676   127 (0->127)       v8/src/elements.cc
               string literal
~ 43)     27250 (80.7%) t@0x16a6284  120 (9904->10024)  v8/src/profiler/heap-snapshot-generator.cc
               v8::internal::V8HeapExplorer::GetStrongGcSubrootName
~ 44)     27370 (81.1%) R@0x2a5f4d8  120 (22120->22240) v8/src/runtime/runtime.cc
               v8::internal::kIntrinsicFunctions
+ 45)     27486 (81.4%) t@0x1664c54  116 (0->116)       v8/src/objects/bigint.cc
               v8::internal::BigInt::FromInt64
+ 46)     27602 (81.8%) t@0x1593faa  116 (0->116)       v8/src/elements.cc
               v8::internal::ElementsAccessorBase<>::GrowCapacity
+ 47)     27718 (82.1%) t@0x15948f6  116 (0->116)       v8/src/elements.cc
               v8::internal::ElementsAccessorBase<>::GrowCapacity
+ 48)     27834 (82.5%) t@0x171cbb0  116 (0->116)       v8/src/runtime/runtime-test.cc
               v8::internal::Runtime_HasFixedBigInt64Elements
+ 49)     27950 (82.8%) t@0x171c9e8  116 (0->116)       v8/src/runtime/runtime-test.cc
               v8::internal::Runtime_HasFixedBigUint64Elements
~ 50)     28062 (83.1%) t@0x15de60c  112 (4844->4956)   v8/src/heap/object-stats.cc
               v8::internal::ObjectStats::Dump
+ 51)     28174 (83.5%) t@0x15945ae  112 (0->112)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::LastIndexOfValueImpl
+ 52)     28286 (83.8%) t@0x1594ef4  112 (0->112)       v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::LastIndexOfValueImpl
+ 53)     28388 (84.1%) t@0x1593d60  102 (0->96)        v8/src/elements.cc
               v8::internal::FixedTypedArray<>::FromHandle
+ 54)     28485 (84.4%) r@0x4724db   97 (0->97)         v8/src/bootstrapper.cc
               string literal
+ 55)     28581 (84.7%) r@0x47253c   96 (0->96)         v8/src/bootstrapper.cc
               string literal
~ 56)     28677 (84.9%) R@0x2a5415c  96 (4128->4224)    v8/src/counters.cc
               v8::internal::Counters::Counters::kStatsCounters
~ 57)     28769 (85.2%) t@0x1720384  92 (104->196)      v8/src/runtime/runtime-typedarray.cc
               v8::internal::Runtime_TypedArraySlice
+ 58)     28856 (85.5%) t@0xe23c20   86 (0->86)         v8/src/runtime/runtime-typedarray.cc
               std::__ndk1::__insertion_sort_incomplete<> (num_aliases=3)
+ 59)     28940 (85.7%) t@0x16c71f8  84 (0->84)         v8/src/runtime/runtime-bigint.cc
               v8::internal::Runtime_ToBigInt
~ 60)     29024 (86.0%) t@0x1720448  84 (312->396)      v8/src/runtime/runtime-typedarray.cc
               v8::internal::Stats_Runtime_TypedArraySlice
+ 61)     29106 (86.2%) t@0x1664d12  82 (0->82)         v8/src/objects/bigint.cc
               v8::internal::MutableBigInt::GetRawBits
~ 62)     29026 (86.0%) t@0x15908b0  -80 (328->248)     v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::IncludesValueImpl
~ 63)     28946 (85.7%) t@0x1591bd0  -80 (328->248)     v8/src/elements.cc
               v8::internal::TypedElementsAccessor<>::IncludesValueImpl
+ 64)     29024 (86.0%) t@0x1722914  78 (0->78)         third_party/android_ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libc++_static.a/algorithm.o
               std::__ndk1::__sort5<> (num_aliases=2)
+ 65)     29102 (86.2%) t@0x1722914  78 (0->78)         v8/src/runtime/runtime-typedarray.cc
               std::__ndk1::__sort5<> (num_aliases=2)



It's not clear to me whether or not this increase was expected.
Please have a look and either:

Close as “Won't Fix” with a short justification, or
Land a revert / fix-up.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Feb 22 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=814890

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=ff07e1eaa0c7694134eacaa6c62d125286ff11719c837ba33c57113c9c90c95b


Bot(s) for this bug's original alert(s):

Android Builder
Status: WontFix (was: Assigned)
This adds two new types of TypedArrays, and that does not come for free.

Sign in to add a comment