Feedback should contain client logs so that we can understand what is going on on the client.
Two more things to do: 1. Collect host OS and host OS version. 2. Add "report this error" button (link?) to the connection view.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a4d806633c24d631d1a417f23fe44b4f0149a06 commit 8a4d806633c24d631d1a417f23fe44b4f0149a06 Author: Yuwei Huang <yuweih@chromium.org> Date: Sat Feb 24 06:20:47 2018 [CRD iOS] Store logs in memory The iOS logger by default will only write logs to OSLog. However, there is no API for us to retrieve logs sent to OSLog. This CL implements a log handler to store logs in memory before they get printed out. Bug: 814863 Change-Id: Ic7f30df45f3879370e2e9d93ef771f10df4dbeb3 Reviewed-on: https://chromium-review.googlesource.com/933364 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#538998} [modify] https://crrev.com/8a4d806633c24d631d1a417f23fe44b4f0149a06/remoting/client/BUILD.gn [add] https://crrev.com/8a4d806633c24d631d1a417f23fe44b4f0149a06/remoting/client/in_memory_log_handler.cc [add] https://crrev.com/8a4d806633c24d631d1a417f23fe44b4f0149a06/remoting/client/in_memory_log_handler.h [modify] https://crrev.com/8a4d806633c24d631d1a417f23fe44b4f0149a06/remoting/ios/app/main.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/19abb80ec94f949368a78987c6f5fd257b59f584 commit 19abb80ec94f949368a78987c6f5fd257b59f584 Author: Yuwei Huang <yuweih@chromium.org> Date: Sat Feb 24 11:25:25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50ce2272c150a05fd4177cf894f0ae2dad894304 commit 50ce2272c150a05fd4177cf894f0ae2dad894304 Author: Yuwei Huang <yuweih@chromium.org> Date: Wed Feb 28 01:41:33 2018 [CRD iOS] Collecting in-session data for telemetry and feedback This CL makes the iOS app track these fields for telemetry: * Connection type * Previous session state It also makes ChromotingSession export a FeedbackData from current telemetry data, to be attached to the feedback report. Bug: 814863 Change-Id: Iab32eb5da6748a0e3b7f6d251fa2d7c926c01392 Reviewed-on: https://chromium-review.googlesource.com/939102 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#539635} [modify] https://crrev.com/50ce2272c150a05fd4177cf894f0ae2dad894304/remoting/base/chromoting_event.cc [modify] https://crrev.com/50ce2272c150a05fd4177cf894f0ae2dad894304/remoting/base/chromoting_event.h [modify] https://crrev.com/50ce2272c150a05fd4177cf894f0ae2dad894304/remoting/client/BUILD.gn [modify] https://crrev.com/50ce2272c150a05fd4177cf894f0ae2dad894304/remoting/client/chromoting_session.cc [modify] https://crrev.com/50ce2272c150a05fd4177cf894f0ae2dad894304/remoting/client/chromoting_session.h [modify] https://crrev.com/50ce2272c150a05fd4177cf894f0ae2dad894304/remoting/client/client_telemetry_logger.cc [modify] https://crrev.com/50ce2272c150a05fd4177cf894f0ae2dad894304/remoting/client/client_telemetry_logger.h [add] https://crrev.com/50ce2272c150a05fd4177cf894f0ae2dad894304/remoting/client/feedback_data.cc [add] https://crrev.com/50ce2272c150a05fd4177cf894f0ae2dad894304/remoting/client/feedback_data.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82ede4ddc1044ad96837b2bcfc8e8108df2d1abf commit 82ede4ddc1044ad96837b2bcfc8e8108df2d1abf Author: Yuwei Huang <yuweih@chromium.org> Date: Thu Mar 01 02:08:54 2018 [CRD iOS] Pass FeedbackData to HelpAndFeedback This CL passes feedback data created from ChromotingSession to the HelpAndFeedback instance, so that it can be later attached to the feedback report. This CL is coupled with an internal CL: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/578187 Bug: 814863 Change-Id: I83c41ec7850ab5bd6852e54438ab120aab65656c Reviewed-on: https://chromium-review.googlesource.com/940265 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#539987} [modify] https://crrev.com/82ede4ddc1044ad96837b2bcfc8e8108df2d1abf/remoting/client/chromoting_session.cc [modify] https://crrev.com/82ede4ddc1044ad96837b2bcfc8e8108df2d1abf/remoting/client/chromoting_session.h [modify] https://crrev.com/82ede4ddc1044ad96837b2bcfc8e8108df2d1abf/remoting/client/jni/jni_client.cc [modify] https://crrev.com/82ede4ddc1044ad96837b2bcfc8e8108df2d1abf/remoting/ios/app/app_delegate.h [modify] https://crrev.com/82ede4ddc1044ad96837b2bcfc8e8108df2d1abf/remoting/ios/app/help_and_feedback.h [modify] https://crrev.com/82ede4ddc1044ad96837b2bcfc8e8108df2d1abf/remoting/ios/app/help_and_feedback.mm [modify] https://crrev.com/82ede4ddc1044ad96837b2bcfc8e8108df2d1abf/remoting/ios/app/host_view_controller.mm [modify] https://crrev.com/82ede4ddc1044ad96837b2bcfc8e8108df2d1abf/remoting/ios/app/settings/remoting_settings_view_controller.h [modify] https://crrev.com/82ede4ddc1044ad96837b2bcfc8e8108df2d1abf/remoting/ios/app/settings/remoting_settings_view_controller.mm [modify] https://crrev.com/82ede4ddc1044ad96837b2bcfc8e8108df2d1abf/remoting/ios/session/remoting_client.h [modify] https://crrev.com/82ede4ddc1044ad96837b2bcfc8e8108df2d1abf/remoting/ios/session/remoting_client.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/032869b7cb4286c3a88bb0a0e22b2638d06da869 commit 032869b7cb4286c3a88bb0a0e22b2638d06da869 Author: Yuwei Huang <yuweih@google.com> Date: Thu Mar 01 04:38:53 2018
Comment 1 by yuweih@chromium.org
, Feb 23 2018