New issue
Advanced search Search tips

Issue 814861 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 773928



Sign in to add a comment

New Print Preview UI should handle ideographic commas in the page range field.

Project Member Reported by thestig@chromium.org, Feb 22 2018

Issue description

AKA port fix for  bug 806165  to new Print Preview UI.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93071987c2a2fd241ffcc5d0b9130318a231e06e

commit 93071987c2a2fd241ffcc5d0b9130318a231e06e
Author: rbpotter <rbpotter@chromium.org>
Date: Tue May 08 21:32:50 2018

Print Preview Componentization: Allow other commas

- Allow alternative commas in the Print Preview UI for the pages field
- Migrate tests for pages syntax
- Fixes to match behavior of current UI (i.e. show error for 2 commas
  in a row, 0 is invalid syntax instead of out of bounds).

Bug:  814860 ,  814861 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ied57eaf87b68cd712fe50970a37a71401c977a0c
Reviewed-on: https://chromium-review.googlesource.com/1048468
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556965}
[modify] https://crrev.com/93071987c2a2fd241ffcc5d0b9130318a231e06e/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/93071987c2a2fd241ffcc5d0b9130318a231e06e/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/93071987c2a2fd241ffcc5d0b9130318a231e06e/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[add] https://crrev.com/93071987c2a2fd241ffcc5d0b9130318a231e06e/chrome/test/data/webui/print_preview/pages_settings_test.js

Status: Fixed (was: Assigned)

Sign in to add a comment