New issue
Advanced search Search tips

Issue 814860 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Task

Blocking:
issue 773928



Sign in to add a comment

[Print Preview componentization]: Migrate tests

Project Member Reported by rbpotter@chromium.org, Feb 22 2018

Issue description

Existing print preview unit/browser tests should be migrated to test the new UI.
 
Blocking: 773928
Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/256d8bced2090252eb5524fb302716c17c4b513b

commit 256d8bced2090252eb5524fb302716c17c4b513b
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Apr 17 21:29:00 2018

Print Preview Componentization: Migrate color tests, update color

Bug:  814860 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibe97fb4ccc820b72b67c8311b5ac5749ddb39d8d
Reviewed-on: https://chromium-review.googlesource.com/1014275
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551482}
[modify] https://crrev.com/256d8bced2090252eb5524fb302716c17c4b513b/chrome/browser/resources/print_preview/new/model.js
[modify] https://crrev.com/256d8bced2090252eb5524fb302716c17c4b513b/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ec812e80fb67cfa3b48f920959b6a1b5b6036b5

commit 3ec812e80fb67cfa3b48f920959b6a1b5b6036b5
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Apr 18 19:28:50 2018

Print Preview Componentization: Migrate header footer tests

Add a HeaderFooter test to verify that the header footer option appears
and disappears correctly for different margin and paper size settings.
Migrated from tests in print_preview_tests.js.

Bug:  814860 
Change-Id: I18012eb26ccd261b94a88f70ef24746e872910ba
Reviewed-on: https://chromium-review.googlesource.com/1013301
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551780}
[modify] https://crrev.com/3ec812e80fb67cfa3b48f920959b6a1b5b6036b5/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/3ec812e80fb67cfa3b48f920959b6a1b5b6036b5/chrome/test/data/webui/print_preview/settings_section_test.js

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8acf6974f2a495906184dfa6ddaa079edcbf279

commit e8acf6974f2a495906184dfa6ddaa079edcbf279
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Apr 25 01:56:10 2018

Print Preview Componentization: Migrate preview area error tests

Migrate some tests for errors that appear in the Preview Area:
- No PDF plugin
- Invalid Settings
- Bad cloud print certificate

Bug:  814860 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia87708ef2bc326d794b3be0f6aa9adeb87e5a3c2
Reviewed-on: https://chromium-review.googlesource.com/1015850
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553416}
[modify] https://crrev.com/e8acf6974f2a495906184dfa6ddaa079edcbf279/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/e8acf6974f2a495906184dfa6ddaa079edcbf279/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/e8acf6974f2a495906184dfa6ddaa079edcbf279/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/e8acf6974f2a495906184dfa6ddaa079edcbf279/chrome/browser/resources/print_preview/new/preview_area.js
[add] https://crrev.com/e8acf6974f2a495906184dfa6ddaa079edcbf279/chrome/test/data/webui/print_preview/invalid_settings_browsertest.js
[modify] https://crrev.com/e8acf6974f2a495906184dfa6ddaa079edcbf279/chrome/test/data/webui/print_preview/native_layer_stub.js
[modify] https://crrev.com/e8acf6974f2a495906184dfa6ddaa079edcbf279/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/e8acf6974f2a495906184dfa6ddaa079edcbf279/chrome/test/data/webui/print_preview/plugin_stub.js
[modify] https://crrev.com/e8acf6974f2a495906184dfa6ddaa079edcbf279/chrome/test/data/webui/print_preview/preview_generation_test.js
[modify] https://crrev.com/e8acf6974f2a495906184dfa6ddaa079edcbf279/chrome/test/data/webui/print_preview/print_preview_test_utils.js
[modify] https://crrev.com/e8acf6974f2a495906184dfa6ddaa079edcbf279/chrome/test/data/webui/print_preview/print_preview_tests.js
[modify] https://crrev.com/e8acf6974f2a495906184dfa6ddaa079edcbf279/chrome/test/data/webui/print_preview/restore_state_test.js
[modify] https://crrev.com/e8acf6974f2a495906184dfa6ddaa079edcbf279/chrome/test/data/webui/print_preview/settings_section_test.js
[modify] https://crrev.com/e8acf6974f2a495906184dfa6ddaa079edcbf279/chrome/test/data/webui/print_preview/system_dialog_browsertest.js

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a87ac911486f07d63bde9d37aed8e5e56ac95a71

commit a87ac911486f07d63bde9d37aed8e5e56ac95a71
Author: Reid Kleckner <rnk@chromium.org>
Date: Wed Apr 25 16:23:52 2018

Revert "Print Preview Componentization: Migrate preview area error tests"

This reverts commit e8acf6974f2a495906184dfa6ddaa079edcbf279.

Reason for revert: Tests do not pass in official build configuration.

Google internal official bot link:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/83286

Externally visible clang ToT bot configured the same way:
https://ci.chromium.org/buildbot/chromium.clang/ToTWin64/1359

Original change's description:
> Print Preview Componentization: Migrate preview area error tests
> 
> Migrate some tests for errors that appear in the Preview Area:
> - No PDF plugin
> - Invalid Settings
> - Bad cloud print certificate
> 
> Bug:  814860 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: Ia87708ef2bc326d794b3be0f6aa9adeb87e5a3c2
> Reviewed-on: https://chromium-review.googlesource.com/1015850
> Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553416}

TBR=dpapad@chromium.org,rbpotter@chromium.org

Change-Id: I1431bd7e9c3bf612ecb979893b1ea1914134c7ad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  814860 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1028331
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553596}
[modify] https://crrev.com/a87ac911486f07d63bde9d37aed8e5e56ac95a71/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/a87ac911486f07d63bde9d37aed8e5e56ac95a71/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/a87ac911486f07d63bde9d37aed8e5e56ac95a71/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/a87ac911486f07d63bde9d37aed8e5e56ac95a71/chrome/browser/resources/print_preview/new/preview_area.js
[delete] https://crrev.com/22ae932e849e899e818ac3a28f060f7d19b76a42/chrome/test/data/webui/print_preview/invalid_settings_browsertest.js
[modify] https://crrev.com/a87ac911486f07d63bde9d37aed8e5e56ac95a71/chrome/test/data/webui/print_preview/native_layer_stub.js
[modify] https://crrev.com/a87ac911486f07d63bde9d37aed8e5e56ac95a71/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/a87ac911486f07d63bde9d37aed8e5e56ac95a71/chrome/test/data/webui/print_preview/plugin_stub.js
[modify] https://crrev.com/a87ac911486f07d63bde9d37aed8e5e56ac95a71/chrome/test/data/webui/print_preview/preview_generation_test.js
[modify] https://crrev.com/a87ac911486f07d63bde9d37aed8e5e56ac95a71/chrome/test/data/webui/print_preview/print_preview_test_utils.js
[modify] https://crrev.com/a87ac911486f07d63bde9d37aed8e5e56ac95a71/chrome/test/data/webui/print_preview/print_preview_tests.js
[modify] https://crrev.com/a87ac911486f07d63bde9d37aed8e5e56ac95a71/chrome/test/data/webui/print_preview/restore_state_test.js
[modify] https://crrev.com/a87ac911486f07d63bde9d37aed8e5e56ac95a71/chrome/test/data/webui/print_preview/settings_section_test.js
[modify] https://crrev.com/a87ac911486f07d63bde9d37aed8e5e56ac95a71/chrome/test/data/webui/print_preview/system_dialog_browsertest.js

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb

commit f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Apr 25 23:31:01 2018

Reland Print Preview Componentization: Migrate preview area error tests

Original change: https://crrev.com/c/1015850

Chromium and Google Chrome show different messages when the PDF plugin
is missing in Print Preview. Modify the test to accept either message,
to fix official build failures.

Bug:  814860 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1672512db0c50bbf2e95ae6c9798dca82e4ee71c
Reviewed-on: https://chromium-review.googlesource.com/1028566
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553820}
[modify] https://crrev.com/f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb/chrome/browser/resources/print_preview/new/preview_area.html
[modify] https://crrev.com/f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb/chrome/browser/resources/print_preview/new/preview_area.js
[add] https://crrev.com/f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb/chrome/test/data/webui/print_preview/invalid_settings_browsertest.js
[modify] https://crrev.com/f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb/chrome/test/data/webui/print_preview/native_layer_stub.js
[modify] https://crrev.com/f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb/chrome/test/data/webui/print_preview/plugin_stub.js
[modify] https://crrev.com/f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb/chrome/test/data/webui/print_preview/preview_generation_test.js
[modify] https://crrev.com/f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb/chrome/test/data/webui/print_preview/print_preview_test_utils.js
[modify] https://crrev.com/f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb/chrome/test/data/webui/print_preview/print_preview_tests.js
[modify] https://crrev.com/f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb/chrome/test/data/webui/print_preview/restore_state_test.js
[modify] https://crrev.com/f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb/chrome/test/data/webui/print_preview/settings_section_test.js
[modify] https://crrev.com/f5243dcdb929dd8779f1aae6a2ab8234d5a0d2eb/chrome/test/data/webui/print_preview/system_dialog_browsertest.js

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffad29c88f5c4ec3495ccd2c98844afd4e49b0f7

commit ffad29c88f5c4ec3495ccd2c98844afd4e49b0f7
Author: rbpotter <rbpotter@chromium.org>
Date: Mon Apr 30 17:30:45 2018

Print Preview Componentization: Migrate destination tests

Migrate tests that validate automatic printer selection logic for
various scenarios.

Bug:  814860 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia926f9431d587ffea95b86352b6cee4a3a35283b
Reviewed-on: https://chromium-review.googlesource.com/1026167
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554803}
[modify] https://crrev.com/ffad29c88f5c4ec3495ccd2c98844afd4e49b0f7/chrome/browser/resources/print_preview/data/destination_store.js
[add] https://crrev.com/ffad29c88f5c4ec3495ccd2c98844afd4e49b0f7/chrome/test/data/webui/print_preview/destination_select_test.js
[modify] https://crrev.com/ffad29c88f5c4ec3495ccd2c98844afd4e49b0f7/chrome/test/data/webui/print_preview/native_layer_stub.js
[modify] https://crrev.com/ffad29c88f5c4ec3495ccd2c98844afd4e49b0f7/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/ffad29c88f5c4ec3495ccd2c98844afd4e49b0f7/chrome/test/data/webui/print_preview/preview_generation_test.js
[modify] https://crrev.com/ffad29c88f5c4ec3495ccd2c98844afd4e49b0f7/chrome/test/data/webui/print_preview/print_preview_destination_search_test.js
[modify] https://crrev.com/ffad29c88f5c4ec3495ccd2c98844afd4e49b0f7/chrome/test/data/webui/print_preview/print_preview_test_utils.js
[modify] https://crrev.com/ffad29c88f5c4ec3495ccd2c98844afd4e49b0f7/chrome/test/data/webui/print_preview/print_preview_tests.js
[modify] https://crrev.com/ffad29c88f5c4ec3495ccd2c98844afd4e49b0f7/chrome/test/data/webui/print_preview/restore_state_test.js
[modify] https://crrev.com/ffad29c88f5c4ec3495ccd2c98844afd4e49b0f7/chrome/test/data/webui/print_preview/settings_section_test.js
[modify] https://crrev.com/ffad29c88f5c4ec3495ccd2c98844afd4e49b0f7/chrome/test/data/webui/print_preview/system_dialog_browsertest.js

Project Member

Comment 8 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e25040a988fe63f3daaf7ec3d5e7fd5cbfa99675

commit e25040a988fe63f3daaf7ec3d5e7fd5cbfa99675
Author: rbpotter <rbpotter@chromium.org>
Date: Wed May 02 01:25:44 2018

Print Preview Componentization: Migrate PrinterList test

Add a test for the destinations dialog that verifies destinations are
correctly displayed in the destinations lists, like the PrinterList
test for the old UI.

Bug:  814860 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib90a78d1bacc263f00e5dc0090c17c2c3a94ec6c
Reviewed-on: https://chromium-review.googlesource.com/1037543
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555271}
[modify] https://crrev.com/e25040a988fe63f3daaf7ec3d5e7fd5cbfa99675/chrome/browser/resources/print_preview/new/destination_dialog.html
[add] https://crrev.com/e25040a988fe63f3daaf7ec3d5e7fd5cbfa99675/chrome/test/data/webui/print_preview/destination_dialog_test.js
[modify] https://crrev.com/e25040a988fe63f3daaf7ec3d5e7fd5cbfa99675/chrome/test/data/webui/print_preview/destination_select_test.js
[modify] https://crrev.com/e25040a988fe63f3daaf7ec3d5e7fd5cbfa99675/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/e25040a988fe63f3daaf7ec3d5e7fd5cbfa99675/chrome/test/data/webui/print_preview/print_preview_test_utils.js

Project Member

Comment 10 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa1b1a37829c23c75b605c0654655d82792ff0fe

commit fa1b1a37829c23c75b605c0654655d82792ff0fe
Author: rbpotter <rbpotter@chromium.org>
Date: Fri May 04 04:48:07 2018

Print Preview Componentization: Migrate InitIssuesOneRequest test

Migrate the test that verifies only one printer is fetched at startup,
even when there are multiple recent destinations.

Bug:  814860 
Change-Id: Ia4da53b322b86191b64f5510cfa8260affe2e5f5
Reviewed-on: https://chromium-review.googlesource.com/1042541
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555987}
[modify] https://crrev.com/fa1b1a37829c23c75b605c0654655d82792ff0fe/chrome/test/data/webui/print_preview/destination_select_test.js
[modify] https://crrev.com/fa1b1a37829c23c75b605c0654655d82792ff0fe/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js

Project Member

Comment 11 by bugdroid1@chromium.org, May 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c16a297fd414dc6fa4ff14ba03c8582fe72fd9b

commit 7c16a297fd414dc6fa4ff14ba03c8582fe72fd9b
Author: rbpotter <rbpotter@chromium.org>
Date: Sat May 05 03:34:47 2018

Print Preview Componentization: migrate advanced settings tests

Migrate the AdvancedSettings1Option and AdvancedSettings2Options tests.

Bug:  814860 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9f70fd4bc556bfa7a208822ab0a981a1ac258bca
Reviewed-on: https://chromium-review.googlesource.com/1040877
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556303}
[add] https://crrev.com/7c16a297fd414dc6fa4ff14ba03c8582fe72fd9b/chrome/test/data/webui/print_preview/advanced_dialog_test.js
[modify] https://crrev.com/7c16a297fd414dc6fa4ff14ba03c8582fe72fd9b/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/7c16a297fd414dc6fa4ff14ba03c8582fe72fd9b/chrome/test/data/webui/print_preview/print_preview_test_utils.js
[modify] https://crrev.com/7c16a297fd414dc6fa4ff14ba03c8582fe72fd9b/chrome/test/data/webui/print_preview/print_preview_tests.js

Project Member

Comment 12 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16372ffee6bc91926fd1ada4e054d5e37996611d

commit 16372ffee6bc91926fd1ada4e054d5e37996611d
Author: rbpotter <rbpotter@chromium.org>
Date: Mon May 07 17:26:19 2018

Print Preview Componentization: Migrate custom margins test

Bug:  814860 
Change-Id: Ica207aa29700305633c47eab0705ca9bb8b48333
Reviewed-on: https://chromium-review.googlesource.com/1042497
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556481}
[add] https://crrev.com/16372ffee6bc91926fd1ada4e054d5e37996611d/chrome/test/data/webui/print_preview/custom_margins_test.js
[modify] https://crrev.com/16372ffee6bc91926fd1ada4e054d5e37996611d/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js

Project Member

Comment 13 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45af1b259e91419cb8c94c4651de61b6597ec353

commit 45af1b259e91419cb8c94c4651de61b6597ec353
Author: rbpotter <rbpotter@chromium.org>
Date: Tue May 08 19:31:44 2018

Print Preview Componentization: Migrate destination search tests

Bug:  814860 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I355e20c884a47e6d95f08f13a2ec47bc0c77c9da
Reviewed-on: https://chromium-review.googlesource.com/1042824
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556926}
[modify] https://crrev.com/45af1b259e91419cb8c94c4651de61b6597ec353/chrome/browser/resources/print_preview/new/destination_dialog.js
[add] https://crrev.com/45af1b259e91419cb8c94c4651de61b6597ec353/chrome/test/data/webui/print_preview/destination_search_test.js
[modify] https://crrev.com/45af1b259e91419cb8c94c4651de61b6597ec353/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js

Project Member

Comment 14 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93071987c2a2fd241ffcc5d0b9130318a231e06e

commit 93071987c2a2fd241ffcc5d0b9130318a231e06e
Author: rbpotter <rbpotter@chromium.org>
Date: Tue May 08 21:32:50 2018

Print Preview Componentization: Allow other commas

- Allow alternative commas in the Print Preview UI for the pages field
- Migrate tests for pages syntax
- Fixes to match behavior of current UI (i.e. show error for 2 commas
  in a row, 0 is invalid syntax instead of out of bounds).

Bug:  814860 ,  814861 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ied57eaf87b68cd712fe50970a37a71401c977a0c
Reviewed-on: https://chromium-review.googlesource.com/1048468
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556965}
[modify] https://crrev.com/93071987c2a2fd241ffcc5d0b9130318a231e06e/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/93071987c2a2fd241ffcc5d0b9130318a231e06e/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/93071987c2a2fd241ffcc5d0b9130318a231e06e/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[add] https://crrev.com/93071987c2a2fd241ffcc5d0b9130318a231e06e/chrome/test/data/webui/print_preview/pages_settings_test.js

Status: Fixed (was: Available)
Closing this as fixed since all tests for the old UI, with the exception of unit tests for some functions that no longer exist, have now been re-written for the new UI. There are also additional tests that have been added for the new UI, and we will continue adding additional coverage, but that effort can be tracked as part of 773928 and/or the launch bug.

Sign in to add a comment