New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 814856 link

Starred by 1 user
Status: Fixed
Owner:
mahmadi@chromium.org
Closed: Apr 2018
Cc:
rouslan@chromium.org
rfeng@chromium.org
█ anna.gye...@shopify.com
ma...@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Odd iOS payment flows

Project Member Reported by rouslan@chromium.org, Feb 22 2018 
On Chrome iOS, the edit flow seems a bit off:
- Choose shipping address 
- EDIT 
- Choose the address to edit
- Edit and hit DONE
- Taken back to list of all addresses
    - If you click one now, it goes back to edit view
    - So you need to hit DONE again
- Back on the list, you need to hit the address you want

The edit flow for payment is also a bit odd (similar to above).

Comment 1 by mahmadi@chromium.org, Feb 25 2018

Cc: rfeng@chromium.org
rfeng@ what's the correct flow here?

Comment 2 by mahmadi@chromium.org, Mar 19 2018

Cc: anna.gye...@shopify.com

Comment 4 by mahmadi@chromium.org, Apr 11 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb

commit 1f11e3ef2d4010530d5b0744151ba03bb56bb1cb
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Apr 12 22:27:41 2018

[PR] Updates the edit flow in PaymentRequest UI

1. Exits 'edit' mode after saving or canceling changes to an address,
   credit card, or contact info.
2. Changes the label of the edit screen's 'Done' button to 'Save'.

TBR=sdefresne@

Bug:  814856 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie69697299e92d7f8a922104f84c002c37b5a442b
Reviewed-on: https://chromium-review.googlesource.com/1007865
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550388}
[modify] https://crrev.com/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb/components/components_strings.grd
[modify] https://crrev.com/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb/ios/chrome/browser/ui/payments/contact_info_selection_coordinator.mm
[modify] https://crrev.com/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb/ios/chrome/browser/ui/payments/payment_method_selection_coordinator.mm
[modify] https://crrev.com/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb/ios/chrome/browser/ui/payments/payment_request_edit_view_controller.h
[modify] https://crrev.com/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb/ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm
[modify] https://crrev.com/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb/ios/chrome/browser/ui/payments/payment_request_edit_view_controller_actions.h
[modify] https://crrev.com/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb/ios/chrome/browser/ui/payments/shipping_address_selection_coordinator.mm

Comment 6 by mahmadi@chromium.org, Apr 13 2018

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb

commit 1f11e3ef2d4010530d5b0744151ba03bb56bb1cb
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Apr 12 22:27:41 2018

[PR] Updates the edit flow in PaymentRequest UI

1. Exits 'edit' mode after saving or canceling changes to an address,
   credit card, or contact info.
2. Changes the label of the edit screen's 'Done' button to 'Save'.

TBR=sdefresne@

Bug:  814856 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie69697299e92d7f8a922104f84c002c37b5a442b
Reviewed-on: https://chromium-review.googlesource.com/1007865
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550388}
[modify] https://crrev.com/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb/components/components_strings.grd
[modify] https://crrev.com/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb/ios/chrome/browser/ui/payments/contact_info_selection_coordinator.mm
[modify] https://crrev.com/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb/ios/chrome/browser/ui/payments/payment_method_selection_coordinator.mm
[modify] https://crrev.com/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb/ios/chrome/browser/ui/payments/payment_request_edit_view_controller.h
[modify] https://crrev.com/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb/ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm
[modify] https://crrev.com/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb/ios/chrome/browser/ui/payments/payment_request_edit_view_controller_actions.h
[modify] https://crrev.com/1f11e3ef2d4010530d5b0744151ba03bb56bb1cb/ios/chrome/browser/ui/payments/shipping_address_selection_coordinator.mm
►

Sign in to add a comment