New issue
Advanced search Search tips

Issue 814851 link

Starred by 1 user
Status: Fixed
Owner:
majidvp@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 812410
issue 720080
issue 756539
Blocking:
issue 430155



Sign in to add a comment

Animation Worklet - WorkletAnimation should update its effect's timing

Project Member Reported by majidvp@chromium.org, Feb 22 2018 
WorkletAnimation has an effect but it does not update it. It should update it so that the effect timing is correct and it can correctly 
be added to EffectStack.

Furthermore, this ensures the effect driven by worklet animation has
accurate phase which is important for ElementAnimations::UpdateAnimationFlags logic.

Comment 1 by majidvp@chromium.org, Feb 22 2018

Blockedon: 812410 720080
Blocking: 430155
Labels: -Type-Bug Type-Feature
Owner: majidvp@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by majidvp@chromium.org, Feb 22 2018

Blockedon: 756539

Comment 3 by majidvp@chromium.org, Feb 26 2018

Components: Blink>Animation
Labels: Hotlist-ThreadedRendering
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80dca7a264752e490a16b0ae3022ccfb8b8c53f7

commit 80dca7a264752e490a16b0ae3022ccfb8b8c53f7
Author: Majid Valipour <majidvp@chromium.org>
Date: Wed Apr 25 21:22:48 2018

[animation-worklet] Worklet animation updates the effect time and style

Make WorkletAnimation implement AnimationEffectOwner interface which
enables it to attach to its effect and update its inherited time.

For now, we use "0" as inherited time of the effect but follow up
patches will instead use local time values that will be plumbed from
animation worklet instead.

TODO:
 - Plumb the time values from worklet and use that
 - WorkletAnimation should allow its effect to cancel and restart it.

Bug:  814851 
Change-Id: I8f0b9ff914130cdf73d0e9df41dec13ccc03bcf9
Reviewed-on: https://chromium-review.googlesource.com/902725
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553752}
[modify] https://crrev.com/80dca7a264752e490a16b0ae3022ccfb8b8c53f7/third_party/WebKit/LayoutTests/animations/resources/animation-test-helpers.js
[add] https://crrev.com/80dca7a264752e490a16b0ae3022ccfb8b8c53f7/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/worklet-animation-style-update-expected.txt
[add] https://crrev.com/80dca7a264752e490a16b0ae3022ccfb8b8c53f7/third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/worklet-animation-style-update.html
[modify] https://crrev.com/80dca7a264752e490a16b0ae3022ccfb8b8c53f7/third_party/blink/renderer/core/animation/animation_effect.h
[modify] https://crrev.com/80dca7a264752e490a16b0ae3022ccfb8b8c53f7/third_party/blink/renderer/core/animation/document_animations.cc
[modify] https://crrev.com/80dca7a264752e490a16b0ae3022ccfb8b8c53f7/third_party/blink/renderer/core/animation/keyframe_effect.cc
[modify] https://crrev.com/80dca7a264752e490a16b0ae3022ccfb8b8c53f7/third_party/blink/renderer/core/animation/worklet_animation_base.h
[modify] https://crrev.com/80dca7a264752e490a16b0ae3022ccfb8b8c53f7/third_party/blink/renderer/core/animation/worklet_animation_controller.cc
[modify] https://crrev.com/80dca7a264752e490a16b0ae3022ccfb8b8c53f7/third_party/blink/renderer/core/animation/worklet_animation_controller.h
[modify] https://crrev.com/80dca7a264752e490a16b0ae3022ccfb8b8c53f7/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc
[modify] https://crrev.com/80dca7a264752e490a16b0ae3022ccfb8b8c53f7/third_party/blink/renderer/modules/animationworklet/worklet_animation.h

Comment 5 by majidvp@chromium.org, May 15 2018

Status: Fixed (was: Assigned)
The remaining piece is to plumb the time values back to main thread which is tracked in  issue 756539
►

Sign in to add a comment