Build Output: Fix/suppress unchecked cast warning in NavigationInfoCaptureTriggerTest.java |
||||
Issue description
../../chrome/android/junit/src/org/chromium/chrome/browser/customtabs/NavigationInfoCaptureTriggerTest.java:130: warning: [unchecked] unchecked generic array creation for varargs parameter of type Callback<Tab>[]
clearInvocations(mDelegate); // Clears the mock so the verifies in the original test work.
^
../../chrome/android/junit/src/org/chromium/chrome/browser/customtabs/NavigationInfoCaptureTriggerTest.java:135: warning: [unchecked] unchecked generic array creation for varargs parameter of type Callback<Tab>[]
clearInvocations(mDelegate);
^
2 warnings
,
Feb 22 2018
I will fix this and prevent future regressions.
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edcfaefaf738c8afcc85bf96aad23a4902193297 commit edcfaefaf738c8afcc85bf96aad23a4902193297 Author: Peter Wen <wnwen@chromium.org> Date: Thu Feb 22 22:37:05 2018 Android: Make javac warnings into errors Prevent devs accidentally introducing unchecked warnings into chromium code. Bug: 814835 Change-Id: I5c50674a7aa0c315111499816dbd556c0293ab94 Reviewed-on: https://chromium-review.googlesource.com/932551 Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#538593} [modify] https://crrev.com/edcfaefaf738c8afcc85bf96aad23a4902193297/build/android/gyp/javac.py [modify] https://crrev.com/edcfaefaf738c8afcc85bf96aad23a4902193297/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/NavigationInfoCaptureTriggerTest.java
,
Feb 26 2018
,
May 17 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by wnwen@chromium.org
, Feb 22 2018