New issue
Advanced search Search tips

Issue 814832 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
thestig@chromium.org
dcheng@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 817151


Sign in to add a comment

Migrate //base/files/file_util.h APIs to use ScopedFD/FILE where appropriate

Project Member Reported by w...@chromium.org, Feb 22 2018 
These APIs pre-date the ScopedFD/FILE helpers, and should be updated to use them, so that calling code can be made simpler and less error-prone.

Comment 1 by thestig@chromium.org, Feb 22 2018 

In particular, ScopedFDCloseTraits::Free() is fancier and handles EBADF.

Comment 2 by w...@chromium.org, Feb 22 2018

Cc: dcheng@chromium.org
Also review whether any of the FILE-oriented file_util APIs, e.g. base::CreateAndOpenTemporaryFileInDir() can be replaced with fd-based calls, and the APIs removed.

Comment 3 by thestig@chromium.org, Feb 28 2018

Blockedon: 817151
►

Sign in to add a comment