New issue
Advanced search Search tips

Issue 814818 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

chromedriver_py_tests timing out on ToTMac

Project Member Reported by thakis@chromium.org, Feb 22 2018

Issue description

https://ci.chromium.org/buildbot/chromium.clang/ToTMac/1271

"shard #0 timed out, took too much time to complete" after one hour.


In the last green build on the bot, https://ci.chromium.org/buildbot/chromium.clang/ToTMac/522, it didn't run chromedriver_py_tests.


Looks like it got added here https://chromium.googlesource.com/chromium/src/+/22b2e391ee394ab52f981c7bd04c84d0bbe8e94c


johnchen, is it expected that these tests time out? Should we just remove them again from this bot?
 

Comment 1 by thakis@chromium.org, Feb 22 2018

(The bot does release component builds; maybe the tests are too slow in component builds?)

Comment 2 by thakis@chromium.org, Feb 23 2018

johnchen: ping? this is keeping our bot red
Taking a look.
This bot has a configuration (is_component_build = true, is_debug = false) that chromedriver_py_tests hasn't been tested against. I have a potential fix. Is there any way to try the fix on the bot before checking it in?

Comment 5 by thakis@chromium.org, Feb 23 2018

Not on the bot, but you could check locally I suppose. Just landing and watching the bot seems fine to me too.
I'll try to verify the fix locally and then check it in.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6c0ad8e8cdabe0b2c0160979f64c650e9dffc36

commit e6c0ad8e8cdabe0b2c0160979f64c650e9dffc36
Author: John Chen <johnchen@chromium.org>
Date: Fri Feb 23 20:34:52 2018

[ChromeDriver] Fix chromedriver_py_tests on Mac component build

Add a missing dependency that was causing chromedriver_py_tests to
fail on Mac when is_component_build=true.

Bug:  814818 
Change-Id: I923d6e96910255380669d5f02f3bc828feaa3396
Reviewed-on: https://chromium-review.googlesource.com/935287
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538881}
[modify] https://crrev.com/e6c0ad8e8cdabe0b2c0160979f64c650e9dffc36/chrome/test/chromedriver/BUILD.gn

Status: Verified (was: Unconfirmed)
The fix is checked in, and the builds are green starting with https://ci.chromium.org/buildbot/chromium.clang/ToTMac/1276.

Comment 9 by thakis@chromium.org, Feb 25 2018

Thanks!

Sign in to add a comment