New issue
Advanced search Search tips

Issue 814811 link

Starred by 2 users

Issue metadata

Status: Closed
Owner:
Closed: Jan 19
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 738275



Sign in to add a comment

URLRequestTest.NetworkDelegateProxyError flaked in net_unittests on Fuchsia

Project Member Reported by scottmg@chromium.org, Feb 22 2018

Issue description

https://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/14243

https://chromium-swarm.appspot.com/task?id=3bd41481f3196810&refresh=10&show_raw=1

[00348.963] 03946.03984> [ RUN      ] URLRequestTest.NetworkDelegateProxyError
[00348.964] 03946.03984> ../../net/url_request/url_request_unittest.cc:2417: Failure
[00348.964] 03946.03984> Value of: req->proxy_server().is_valid()
[00348.964] 03946.03984>   Actual: true
[00348.964] 03946.03984> Expected: false
[00348.965] 03946.03984> ../../net/url_request/url_request_unittest.cc:2418: Failure
[00348.965] 03946.03984> Expected equality of these values:
[00348.965] 03946.03984>   ERR_PROXY_CONNECTION_FAILED
[00348.965] 03946.03984>     Which is: -130
[00348.966] 03946.03984>   d.request_status()
[00348.966] 03946.03984>     Which is: -15
[00348.966] 03946.03984> ../../net/url_request/url_request_unittest.cc:2422: Failure
[00348.967] 03946.03984> Value of: network_delegate.last_error()
[00348.967] 03946.03984> Expected: net::ERR_PROXY_CONNECTION_FAILED
[00348.967] 03946.03984>   Actual: -15, net::ERR_SOCKET_NOT_CONNECTED
[00348.968] 03946.03984> [  FAILED  ] URLRequestTest.NetworkDelegateProxyError (74 ms)
[00348.968] 03946.03984> [5632/23698] URLRequestTest.NetworkDelegateProxyError (74 ms)


Bug 496743 has this disabled on iOS, but that might be a timeout, so potentially different.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee64cb049a460fe866bcefef1bb45d0f3c7f6869

commit ee64cb049a460fe866bcefef1bb45d0f3c7f6869
Author: Scott Graham <scottmg@chromium.org>
Date: Thu Feb 22 18:40:38 2018

fuchsia: Disable URLRequestTest.NetworkDelegateProxyError

Flaked at
https://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/14243.

TBR: wez@chromium.org
Bug:  814811 
Change-Id: Ifa1bab4ec93fdfb543a5e8349d17fa64f79f9559
Reviewed-on: https://chromium-review.googlesource.com/931901
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538498}
[modify] https://crrev.com/ee64cb049a460fe866bcefef1bb45d0f3c7f6869/testing/buildbot/filters/fuchsia.net_unittests.filter

Status: Untriaged (was: Unconfirmed)
Owner: w...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0b828e03a1867a858234b1688b64be84149be63

commit a0b828e03a1867a858234b1688b64be84149be63
Author: Wez <wez@chromium.org>
Date: Fri Jan 11 18:37:09 2019

[Fuchsia] Un-filter some tests that we expect should no longer be flaky.

Un-filter three tests which were flaking ~1 year ago:
- DiskCacheBackendTest.InvalidEntry5
- DiskCacheEntryTest.ExternalAsyncIONoBuffer
- URLRequestTest.NetworkDelegateProxyError

There have been substantial filesystem and network changes in the
platform, and we have enabled TestLauncher retries on the Fuchsia bots,
so these should be safe to start running.

Bug:  784448 ,  810521 ,  814811 
Change-Id: I7166ab60ee8a5a8dc7097c0969da8c7bc57878b8
Reviewed-on: https://chromium-review.googlesource.com/c/1405595
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622069}
[modify] https://crrev.com/a0b828e03a1867a858234b1688b64be84149be63/testing/buildbot/filters/fuchsia.net_unittests.filter

Comment 5 by w...@chromium.org, Jan 19 (4 days ago)

Status: Closed (was: Started)

Sign in to add a comment