New issue
Advanced search Search tips

Issue 814805 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Startup.BrowserMessageLoopStartTime temperature histograms broken since 66.0.3338.0

Project Member Reported by wittman@chromium.org, Feb 22 2018

Issue description

The counts for these histograms dropped to zero in 66.0.3338.0: https://uma.googleplex.com/timeline_v2?sid=f690fdba96ad6159eb5a88a4ead2a037

This looks to be due to 3560431c3b6c13dde19b92335fb8421d8f374800 which moved the collection onto a background task. Presumably this is not completing before the message loop start time histogram is recorded.
 
Thanks for reporting this, I'm looking at it now.
Cc: gab@chromium.org fdoray@chromium.org
Hum, at least we still have the Startup.BrowserMessageLoopStartHardFaultCount histogram, I didn't realized that we used a global variable to store the startup temperature in this function.

The proper way to fix this would probably be to use PostTaskWithTraitsAndReply to execute the rest of the RecordBrowserMainMessageLoopStart function only after the startup temperature has been measured, but this might affect more metrics. We could also refactor the code to make sure that delaying the reporting of the temperature metric doesn't get affected but I'm not sure if it's entirely worth it.

Gathering the page fault count in a background thread saves ~7.4ms at startup, which is nice but maybe nothing to fight for? I'll revert my CL for now.

Comment 3 by fdoray@chromium.org, Feb 22 2018

Also, reading the page fault count in a background thread may affect the value that we get, especially if we apply more strict policies on when background tasks can run.
Status: Fixed (was: Assigned)

Sign in to add a comment