New issue
Advanced search Search tips

Issue 814796 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Implement non-sample-accurate AudioParam

Project Member Reported by hongchan@chromium.org, Feb 22 2018

Issue description

Labels: -Pri-1 -M-66 Pri-2
Status: Available (was: Started)
Hold this change until there is an active PR.

Comment 2 by rtoy@chromium.org, Apr 3 2018

Summary: Implement non-sample-accurate AudioParam (was: Implement optimization like silent hint and non-sample-accurate AudioParam)
The silence hint will not happen in V1 (if at all).  The optimized AudioParam issue has been updated so it is part of the spec now.
Blocking: -469639
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccfa5609adc431413c57adf9ace86731a41b011d

commit ccfa5609adc431413c57adf9ace86731a41b011d
Author: Raymond Toy <rtoy@chromium.org>
Date: Tue Jul 10 23:34:32 2018

If AudioWorklet AudioParam is constant, make the array have length 1

If the AudioParam is constant over a rendering quantum, we're allowed
to set the parameter value array to have a length one to indicate that
the audio param is constant.

Make this so if the audio param is truly constant.

Bug:  814796 
Test: audioworklet-audioparam-size.https.html
Change-Id: Ib6e5805dbeb418ad3c202c9c79adc87bc93dad4a
Reviewed-on: https://chromium-review.googlesource.com/1097977
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573985}
[add] https://crrev.com/ccfa5609adc431413c57adf9ace86731a41b011d/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-audioparam-size.https.html
[modify] https://crrev.com/ccfa5609adc431413c57adf9ace86731a41b011d/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/processors/gain-processor.js
[add] https://crrev.com/ccfa5609adc431413c57adf9ace86731a41b011d/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/processors/param-size-processor.js
[modify] https://crrev.com/ccfa5609adc431413c57adf9ace86731a41b011d/third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope.cc

Status: Assigned (was: Available)
Owner: rtoy@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment