New issue
Advanced search Search tips

Issue 814777 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Disable sync consent for AD devices

Project Member Reported by rsorokin@chromium.org, Feb 22 2018

Issue description

It does not have sync because it does not have gaia account
 
Cc: rsorokin@chromium.org
 Issue 819983  has been merged into this issue.
Labels: M-67
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/000236dec2ccd6ab458fb2bfb307907b2a611ef4

commit 000236dec2ccd6ab458fb2bfb307907b2a611ef4
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Wed Mar 21 23:04:02 2018

Disable sync consent for non-Gaia users

Now it is displayed for Active Directory users even though sync does not
work for them.

BUG= chromium:814777 
TEST=manual

Change-Id: I34ca96cc84f6a630947d9224b954522fface1af1
Reviewed-on: https://chromium-review.googlesource.com/970912
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544891}
[modify] https://crrev.com/000236dec2ccd6ab458fb2bfb307907b2a611ef4/chrome/browser/chromeos/login/wizard_controller.cc

Labels: -M-67 Merge-Request-66 M-66
Requesting merge for that.
Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 22 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by josa...@google.com, Mar 23 2018

Labels: -Merge-Review-66 Merge-Approved-66
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 26 2018

Cc: alemate@chromium.org josa...@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 26 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79a7a33ff0b6df28feb08eecfe971941976fb196

commit 79a7a33ff0b6df28feb08eecfe971941976fb196
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Mon Mar 26 16:45:12 2018

Disable sync consent for non-Gaia users

Now it is displayed for Active Directory users even though sync does not
work for them.

BUG= chromium:814777 
TEST=manual

Change-Id: I34ca96cc84f6a630947d9224b954522fface1af1
Reviewed-on: https://chromium-review.googlesource.com/970912
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#544891}(cherry picked from commit 000236dec2ccd6ab458fb2bfb307907b2a611ef4)
Reviewed-on: https://chromium-review.googlesource.com/980992
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#433}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/79a7a33ff0b6df28feb08eecfe971941976fb196/chrome/browser/chromeos/login/wizard_controller.cc

Status: Verified (was: Fixed)
Verified fixed. Sync consent is not displaying for Active Directory users.

Chrome OS: 10452.44.0
Chrome: 66.0.3359.79
Device: Robo360

Sign in to add a comment