New issue
Advanced search Search tips

Issue 814735 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Adaptive Toolbar: Side swipe can be done from the bottom toolbar

Project Member Reported by gambard@chromium.org, Feb 22 2018

Issue description

It should be possible.
 
Labels: -Q1 Q2
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cde6b82abb3979d5c6bb00e8c33e356b5f72e2fb

commit cde6b82abb3979d5c6bb00e8c33e356b5f72e2fb
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Mar 12 14:28:29 2018

Add trigger for tab side swipe on bottom toolbar

This CL adds the possibility to trigger side swipe for tab by swiping
on the bottom toolbar.

Bug:  814735 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I94556de2237fc67ffd41f58a29c3df75f3a7130e
Reviewed-on: https://chromium-review.googlesource.com/957185
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542476}
[modify] https://crrev.com/cde6b82abb3979d5c6bb00e8c33e356b5f72e2fb/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/cde6b82abb3979d5c6bb00e8c33e356b5f72e2fb/ios/chrome/browser/ui/side_swipe/side_swipe_controller.h
[modify] https://crrev.com/cde6b82abb3979d5c6bb00e8c33e356b5f72e2fb/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm
[modify] https://crrev.com/cde6b82abb3979d5c6bb00e8c33e356b5f72e2fb/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm
[modify] https://crrev.com/cde6b82abb3979d5c6bb00e8c33e356b5f72e2fb/ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinatee.h
[modify] https://crrev.com/cde6b82abb3979d5c6bb00e8c33e356b5f72e2fb/ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinator_adaptor.mm
[modify] https://crrev.com/cde6b82abb3979d5c6bb00e8c33e356b5f72e2fb/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.mm
[modify] https://crrev.com/cde6b82abb3979d5c6bb00e8c33e356b5f72e2fb/ios/chrome/browser/ui/toolbar/public/primary_toolbar_coordinator.h
[modify] https://crrev.com/cde6b82abb3979d5c6bb00e8c33e356b5f72e2fb/ios/chrome/browser/ui/toolbar/public/side_swipe_toolbar_interacting.h
[modify] https://crrev.com/cde6b82abb3979d5c6bb00e8c33e356b5f72e2fb/ios/chrome/browser/ui/toolbar/public/toolbar_coordinating.h

Labels: -Q2 Q1
NextAction: 2018-03-14
Status: Fixed (was: Assigned)
The NextAction date has arrived: 2018-03-14

Comment 5 by cmasso@google.com, Mar 14 2018

NextAction: ----

Sign in to add a comment