New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814700 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

40.5% regression in system_health.memory_desktop at 537577:537618

Project Member Reported by alexclarke@chromium.org, Feb 22 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Feb 22 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=814700

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=ae859a00a00507086dad37696f2e1f9d92108257be4500340aafaaf31dc3b1db


Bot(s) for this bug's original alert(s):

chromium-rel-mac11-pro
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Feb 22 2018

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/12dea75f840000
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Feb 22 2018

😿 Pinpoint job stopped with an error.
https://chromeperf.appspot.com/job/15d1546f840000
Cc: tyoshino@chromium.org sullivan@chromium.org
Owner: yhirano@chromium.org
Status: Assigned (was: Untriaged)
Assigning to reviewer yhirano, since tyoshino is leaving the project: r537580, ""  caused a pretty significant memory regression on this test case. The job had an error, but it bisected to this CL. Can you take a look?
 Issue 814701  has been merged into this issue.
Cc: toyoshim@chromium.org hirosh...@chromium.org
Components: Blink>SecurityFeature>CORS Blink>Loader
 Issue 814699  has been merged into this issue.
Status: WontFix (was: Assigned)
The change was a security fix and we expected that it would introduce some regressions.

Cc: erikc...@chromium.org
cc-ing test owner erikchen FYI
Please clarify what you mean by "we expected that it would introduce some regressions.". 

We're observing a ~50MB regression in cc memory usage. It's possible that your CL is triggering some type of non-deterministic loading in WPR, causing more resources [images] to be loaded, and thus more memory usage. It's also possible that your CL has unintended [and unnecessary] side-effects that greatly increase memory usage.

Given the magnitude of the regression, the perf team would feel a lot better if you could spend some time investigating and/or explaining the magnitude of the regression.
As explained in  issue 799477  and issue 809350, reusing a resource that was fetched by another origin leads to a security issue. The CL stopped that, which means with the CL MemoryCache is less used.

Sign in to add a comment