Issue metadata
Sign in to add a comment
|
2.8%-3.4% regression in memory.desktop at 537107:537201 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Feb 22 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12b55a2f840000
,
Feb 22 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/12b55a2f840000
,
Feb 22 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/128e629f840000
,
Feb 22 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/128e629f840000
,
Feb 23 2018
📍 Pinpoint job started. https://chromeperf.appspot.com/job/16d22c20440000
,
Feb 23 2018
That's really weird, there clearly appears to be a regression according to the graph yet the bisect bot can't find it.
,
Feb 23 2018
📍 Couldn't reproduce a difference. https://chromeperf.appspot.com/job/16d22c20440000
,
Feb 23 2018
The link in #8 should have been: https://pinpoint-dot-chromeperf.appspot.com/job/16d22c20440000 (CL to fix just landed). +erikchen, any ideas why this wouldn't repro?
,
Feb 23 2018
I think the metric "reported_by_chrome:malloc:effective_size_avg" is fundamentally flawed. For a longer discussion see https://bugs.chromium.org/p/chromium/issues/detail?id=736506. [That discusses v8 effective_size, but the same arguments apply]. I'm in the process of rolling out heap profiling, which will give us more accurate numbers: https://chromium-review.googlesource.com/c/chromium/src/+/930041 And then we'll need to update the alerting to use shim_allocated_objects_size. If you think the CL in question may potentially cause problems, I'd recommend patching in the CL above and running locally to see if you get differences in shim_allocated_objects_size.
,
Feb 23 2018
Thanks, Erik! These regressions are small enough (and only on a few pages) that I think we can close this. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Feb 22 2018