Issue metadata
Sign in to add a comment
|
Regression : Bookmark bubble appears large in size than expected.
Reported by
avsha...@etouch.net,
Feb 22 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version : 66.0.3352.0 (Official Build) db148559378834dcddbc7066d6f899b5e227d426-refs/heads/master@{#538313} 64-bit OS : Mac(10.12.6, 10.13.1, 10.13.4), Linux(14.04 LTS) OS What steps will reproduce the problem? 1. Launch chrome, open NTP and click on ‘Bookmark’ icon in omnibox. 2. Observe the bookmark bubble. Actual Result : Bookmark bubble appears large in size than expected. Expected Result : Bookmark bubble should be of medium size. This is a regression issue broken in ‘M-66’ and providing the bisect using ‘per-revision’ script: Good build : 66.0.3350.0 (Revision : 537343) Bad build : 66.0.3352.0 (Revision : 538313) You are probably looking for a change made after 538290 (known good), but no later than 538291 (first known bad). Change Log URL: https://chromium.googlesource.com/chromium/src/+log/b142f92da8f9be5600b895a9789dd27b31c42fe9..9f49e26bfb4a5b033bdb837cd7c1331a0bf8bc3c Suspect : https://chromium.googlesource.com/chromium/src/+/9f49e26bfb4a5b033bdb837cd7c1331a0bf8bc3c @pbos : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note : 1. This issue is only observed on Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.4) OS. 2. Bookmark bubble appears in proper size on Windows(7,8,8.1,10) OS.
,
Feb 22 2018
Thanks. +srahim@ I believe this is because of the longer "Advanced" string for the extra button here that pushes the dialog size. Is there a shorter alternative I can use, or should I revert it back to "Edit..." (even though the heading is "Edit bookmark")? I think I prefer "Edit..." over "More...", do you have any better ideas?
,
Feb 23 2018
Per discussion with pbos, we agreed to keep "Edit bookmark" as the title and change the button to "More...", in the hopes that will fix the dialog size.
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78f791e933eff907433bf2a822301776aad38f4a commit 78f791e933eff907433bf2a822301776aad38f4a Author: Peter Boström <pbos@chromium.org> Date: Fri Feb 23 23:28:57 2018 Shorten more/advanced button in bookmark bubble Changing "Edit..." to "Advanced" caused layout problems, so moving to the shorter "More..." as "Edit..." conflicts with the "Edit bookmarks" title of the dialog. Bug: chromium:812362, chromium:814668 Change-Id: Id11a7c463c20c5a6508c863882a6f0be8d9f2b8d Reviewed-on: https://chromium-review.googlesource.com/935626 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#538942} [modify] https://crrev.com/78f791e933eff907433bf2a822301776aad38f4a/chrome/app/bookmarks_strings.grdp
,
Feb 23 2018
I think this should be fixed now. bettes@: This is an example where a small button string modification can resize a dialog so as the 3 buttons (extra, ok, cancel) don't fit within it at 320px width. When this happens the dialog upsizes to 448px which is a jump large enough to flag as a regression. This likely happens in localization for multiple languages on a regular basis. I think we should revisit snapping at all or snapping to width multiples of 32px. If it's not right to go from 320px to 448px in English it shouldn't be right in any other languages.
,
Feb 23 2018
+bsep@ FYI for #5.
,
Feb 26 2018
Update : Verified above issue on latest Canary #66.0.3355.0 build for Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS) OS and the issue seems fixed.Kindly review an attached screen cast. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by avsha...@etouch.net
, Feb 22 2018