Issue metadata
Sign in to add a comment
|
[Opera] Click events are not correctly transmitted
Reported by
yorena...@opera.com,
Feb 22 2018
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 OPR/51.0.2830.34 Steps to reproduce the problem: views::View that don't have a context menu controller still mark the click event as handled, forbidding further processing of this event. 1. click on a view that doesn't have a context menu controller What is the expected behavior? event processed further down What went wrong? event not processed further down Did this work before? Yes Does this work in other browsers? Yes Chrome version: 64.0.3282.140 Channel: n/a OS Version: Ubuntu 16.04 Flash Version: Broken by 3ada8cbd4218118a10e79d2a42ffd80870f7f1d3 (ui/views/widget/desktop_aura/window_event_filter.cc)
,
Feb 23 2018
Thanks for filing the issue! @Reporter: Could you please share a sample test file/URL which helps to triage the issue in a better way from ET end. Thanks!
,
Feb 23 2018
thomasanderson@ Please investigate as Opera claims your changed caused the issue.
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f40c23c5504c38ee3f73f61536165c1febeaf17 commit 3f40c23c5504c38ee3f73f61536165c1febeaf17 Author: Oliver Renault <yorenault@opera.com> Date: Fri Feb 23 18:48:33 2018 [Linux] Only mark event as handled when it is actually handled views::View that don't have a context menu controller still mark the click event as handled, forbidding further processing of this event. Bug: 814666 Change-Id: Ie9ab6e0f0e573a4d653a52995421ac1075c686fb Reviewed-on: https://chromium-review.googlesource.com/925269 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#538835} [modify] https://crrev.com/3f40c23c5504c38ee3f73f61536165c1febeaf17/ui/views/widget/desktop_aura/window_event_filter.cc
,
Feb 23 2018
,
Feb 26 2018
As per comment#2, we are unable to test this issue on chrome reported version 64.0.3282.140 without test file, hence unable to verify the issue. @Reporter/thomasanderson: Could you please share a sample test file/URL which helps us in verifying the fix. Also, can we remove Needs-Bisect label as the fix is already landed(as per comment#4) Thanks!
,
Feb 26 2018
AFAIK there is no repro in Chrome. This was only causing issues in Opera. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by krajshree@chromium.org
, Feb 22 2018