Issue metadata
Sign in to add a comment
|
Regression:Google app icons disappear on clicking on 'More' link .
Reported by
shruti.j...@etouch.net,
Feb 22 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version : 66.0.3352.0 (Official Build) db148559378834dcddbc7066d6f899b5e227d426-refs/heads/master@{#538313} (64-bit) OS : Mac(10.13.4) What steps will reproduce the problem? 1.Launch chrome, navigate to NTP. 2.Click on 'google apps' to display google properties list. 3.Now scroll through the list click on'more' link and observe. Actual Result :'Google apps' list disappears on clicking on 'more' link and it also disappears on scrolling down using touch pad. Expected Result :'Google apps' list should not disappear on clicking on 'more' link and it should not disappear on scrolling down using touch pad. This is a regression issue broken in ‘M-66’ and providing the bisect using ‘per-revision’ script: Good build : 66.0.3350.0 (Revision :537343) Bad build : 66.0.3352.0 (Revision :538313) You are probably looking for a change made after 537453 (known good), but no later than 537454 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/e282ebc6f0e5852cfc46ee688bae89a78d119270..0a9a5c311a1d3a298f952e495510bd6fe3faa2f6 Suspect:https://chromium.googlesource.com/chromium/src/+/0a9a5c311a1d3a298f952e495510bd6fe3faa2f6 @Xianzhu Wang:Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. NOTE: Issue is not seen on MAC(10.12.6,10.13.1),Linux (14.04 LTS) and Windows (7,8,8.1,10) OS. Thank You
,
Feb 22 2018
Adding release blocker label for this issue.Please increase/reduce priority or remove if not the case. Thank You!
,
Feb 22 2018
load balancing :)
,
Feb 23 2018
Tested the above issue on Chrome OS with latest M-66 version 66.0.3352.0/10430.0.0 dev channel Daisy,Kip,Reks and unable to reproduce the issue with the following steps 1.Launch chrome, navigated to NTP. 2.Clicked on 'google apps' to display google properties list. 3.Now scrolled through the list ,clicked on'more' link. Observed that it is working as expected i.e,'Google apps' list doesn't disappear on clicking on 'more' link and it doesn't disappear on scrolling down using touch pad. Attached the screencast for reference.. Thanks.
,
Feb 24 2018
I can reproduce on 66.0.3353.0 on mac. Investigating.
,
Feb 24 2018
Reduced test case:
<!doctype HTML>
<style>
#container {
height: 500px;
width: 250px;
overflow: scroll;
border-radius: 2px 2px 2px 2px;
}
</style>
<div id="container">
<div style="width:200px; height:200px; background-color:lightblue"></div>
<div style="width:200px; height:200px; background-color:lightgreen"></div>
<div style="width:200px; height:200px; background-color:gray"></div>
<div style="width:200px; height:200px; background-color:lightgray"></div>
</div>
Reproduces on both mac (with touchpad) and in devtools emulation for android.
,
Feb 27 2018
I can also reproduce this on Linux with --enable-prefer-compositing-to-lcd-text.
,
Feb 27 2018
Issue 816812 has been merged into this issue.
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/857b89fe4bb8843f8f8074a8545e5a51b22a9166 commit 857b89fe4bb8843f8f8074a8545e5a51b22a9166 Author: Vladimir Levin <vmpstr@chromium.org> Date: Wed Feb 28 18:05:03 2018 [SPv175] Ensure border radius clip mask layer contents are not scrolled. This patch ensures that when we paint the mask layer that is generated as a result of an inner border radius clip, we use the transform from LocalBorderBoxProperties, which does not include the scroll offset from the scrolled contents. R=chrishtr@chromium.org, trchen@chromium.org Bug: 814664 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4ba134134dda367e6ddc9d7005a6ff8ae7003426 Reviewed-on: https://chromium-review.googlesource.com/938319 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539879} [add] https://crrev.com/857b89fe4bb8843f8f8074a8545e5a51b22a9166/third_party/WebKit/LayoutTests/compositing/scroll-with-inner-clip-expected.png [add] https://crrev.com/857b89fe4bb8843f8f8074a8545e5a51b22a9166/third_party/WebKit/LayoutTests/compositing/scroll-with-inner-clip-expected.txt [add] https://crrev.com/857b89fe4bb8843f8f8074a8545e5a51b22a9166/third_party/WebKit/LayoutTests/compositing/scroll-with-inner-clip.html [add] https://crrev.com/857b89fe4bb8843f8f8074a8545e5a51b22a9166/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/scroll-with-inner-clip-expected.png [add] https://crrev.com/857b89fe4bb8843f8f8074a8545e5a51b22a9166/third_party/WebKit/LayoutTests/platform/mac-mac10.12/compositing/scroll-with-inner-clip-expected.png [add] https://crrev.com/857b89fe4bb8843f8f8074a8545e5a51b22a9166/third_party/WebKit/LayoutTests/virtual/disable-spv175/compositing/scroll-with-inner-clip-expected.png [modify] https://crrev.com/857b89fe4bb8843f8f8074a8545e5a51b22a9166/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
,
Mar 1 2018
For verification, this needs to use --enable-blink-features=SlimmingPaintV175, since it was disabled by default while I was working on the fix.
,
Mar 1 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-66; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-66 label, otherwise remove Merge-TBD label. Thanks.
,
Mar 1 2018
,
Mar 5 2018
Merge is not required since spv175 was disabled for 66 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shruti.j...@etouch.net
, Feb 22 2018