New issue
Advanced search Search tips

Issue 814643 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Ill in __RT_impl_Runtime_IterableToListCanBeElided

Project Member Reported by ClusterFuzz, Feb 22 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6139789582270464

Fuzzer: ochang_js_fuzzer
Job Type: linux_ubsan_vptr_d8
Platform Id: linux

Crash Type: Ill
Crash Address: 0x7f116f8a537e
Crash State:
  __RT_impl_Runtime_IterableToListCanBeElided
  v8::internal::Runtime_IterableToListCanBeElided
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_d8&range=51376:51377

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6139789582270464

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 22 2018

Labels: Test-Predator-Auto-Owner
Owner: petermarshall@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/81a3742a889db5db034b8345683cef49e95095ee ([typedarray] Port TypedArray.from to CSA.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: jgruber@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/aaa78c330ece3a1b43c6b6d2b38429a03e3f3c15

commit aaa78c330ece3a1b43c6b6d2b38429a03e3f3c15
Author: Peter Marshall <petermarshall@chromium.org>
Date: Thu Feb 22 10:23:32 2018

[typedarray] Fix IterableToList when Number has an iterator

IterableToListCanBeElided checked that the input was always a HeapObject
but this is not true when an iterator symbol is defined on the Number
prototype, meaning Smi and HeapNumber can also be passed in.

Added a regression test for the crash and some correctness tests for
smi and double input to TA.from.

Also factored out the tests in typedarray-from.js that modify global
state e.g. protector cells, so that one iteration of the top level
loop does not interfere with the next.

Bug:  chromium:814643 
Change-Id: I364d11f011faf8370446f905a35a945d47e4477f
Reviewed-on: https://chromium-review.googlesource.com/930962
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51461}
[modify] https://crrev.com/aaa78c330ece3a1b43c6b6d2b38429a03e3f3c15/src/runtime/runtime-object.cc
[modify] https://crrev.com/aaa78c330ece3a1b43c6b6d2b38429a03e3f3c15/test/mjsunit/es6/typedarray-from.js
[add] https://crrev.com/aaa78c330ece3a1b43c6b6d2b38429a03e3f3c15/test/mjsunit/regress/regress-814643.js

Project Member

Comment 4 by ClusterFuzz, Feb 23 2018

ClusterFuzz has detected this issue as fixed in range 51460:51461.

Detailed report: https://clusterfuzz.com/testcase?key=6139789582270464

Fuzzer: ochang_js_fuzzer
Job Type: linux_ubsan_vptr_d8
Platform Id: linux

Crash Type: Ill
Crash Address: 0x7f116f8a537e
Crash State:
  __RT_impl_Runtime_IterableToListCanBeElided
  v8::internal::Runtime_IterableToListCanBeElided
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_d8&range=51376:51377
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_d8&range=51460:51461

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6139789582270464

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Feb 23 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6139789582270464 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment