Issue metadata
Sign in to add a comment
|
Regression:Double arrow pointer is seen while rotating the display |
||||||||||||||||||||||
Issue descriptionChrome Version:66.0.3350.3/10427.0.0 dev-channel Daisy,Kip,Reks OS:Chrome OS What steps will reproduce the problem? (1)Recover Build >>In OOBE screen,from ubertray/Accessibility >>Enable and disable the Screen magnifier once. (2)Now Press Ctrl+Shift+Reload to rotate the display and observe double arrow pointer at a time Actual:Double arrow pointer is seen while rotating the display Expected:No such double arrow pointer at a time should be seen This is a Regression issue as same is working fine in 64.0.3282.167/10176.72.0 Stable Note: 1.Issue is not seen in Linux,Windows OS 2. Issue is also seen in M-65 beta @stevenjb: Please confirm the behavior.
,
Feb 22 2018
Is this limited to oobe?
,
Feb 22 2018
,
Feb 22 2018
could be that software cursor wasn't properly disabled?
,
Mar 6 2018
After screen magnification is updated, the kAccessibilityScreenMagnifierEnabled is updated here [1] in browser, but it is not enabled in ash [2] when cursor compositing is being updated. So the composited cursor is still enabled after screen magnification is disabled. Here is a simple fix: https://chromium-review.googlesource.com/c/chromium/src/+/951639 [1] https://cs.chromium.org/chromium/src/chrome/browser/chromeos/accessibility/magnification_manager.cc?sq=package:chromium&dr&l=176 [2] https://cs.chromium.org/chromium/src/ash/display/cursor_window_controller.cc?q=cursor_window_controller&dr=C&l=136
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47e352d1ef30ccd92db3dd6960264949538be4fc commit 47e352d1ef30ccd92db3dd6960264949538be4fc Author: Weidong Guo <weidongg@chromium.org> Date: Thu Mar 08 01:22:07 2018 Fix software cursor issue with screen magnification enabled After screen magnification is enabled/disabled, the preferences for the active profile have not been updated when the cursor compositing is being updated. Use MagnificationController::IsEnabled() instead. BUG= 814634 Change-Id: Id72c579bd3395ae2e9748858622df37086bc4220 Reviewed-on: https://chromium-review.googlesource.com/951639 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#541676} [modify] https://crrev.com/47e352d1ef30ccd92db3dd6960264949538be4fc/ash/display/cursor_window_controller.cc
,
Mar 8 2018
,
Mar 8 2018
,
Mar 9 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 12 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e02e8b58ffd939d54ae61fcf7b4eea21ac42c9b1 commit e02e8b58ffd939d54ae61fcf7b4eea21ac42c9b1 Author: Weidong Guo <weidongg@chromium.org> Date: Mon Mar 12 16:43:30 2018 Fix software cursor issue with screen magnification enabled After screen magnification is enabled/disabled, the preferences for the active profile have not been updated when the cursor compositing is being updated. Use MagnificationController::IsEnabled() instead. BUG= 814634 TBR=oshima@chromium.org Change-Id: Id72c579bd3395ae2e9748858622df37086bc4220 Reviewed-on: https://chromium-review.googlesource.com/951639 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#541676}(cherry picked from commit 47e352d1ef30ccd92db3dd6960264949538be4fc) Reviewed-on: https://chromium-review.googlesource.com/959201 Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#163} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/e02e8b58ffd939d54ae61fcf7b4eea21ac42c9b1/ash/display/cursor_window_controller.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rkalavakuntla@chromium.org
, Feb 22 2018