Issue metadata
Sign in to add a comment
|
Regression: BROWSE button for specifying your own driver is seen missing in Add printer overlay |
||||||||||||||||||||||
Issue descriptionChrome Version:66.0.3350.3/10427.0.0 dev-channel Daisy,Kip,Reks OS:Chrome OS What steps will reproduce the problem? (1)Launch chrome,go to chrome://settings/cupsPrinters page ->Add Printer (2)In select a printer manufacturer and model >>Observe BROWSE button for specifying your own driver Actual:BROWSE button for specifying your own driver is seen missing Expected:BROWSE button for specifying your own driver should be seen This is a Regression issue as same is working fine in 66.0.3344.0/10417.0.0 dev Note: Issue is not seen in Linux,Windows OS @xdai: Please confirm the behavior.
,
Feb 22 2018
Can we quickly determine if this is also impacting 64.0.3282.186 as a blocker?
,
Feb 22 2018
Unable to reproduce the issue on Chrome 64.0.3282.186/10176.74 -kip
,
Feb 23 2018
+David Is this possible that your change introduced this?
,
Feb 24 2018
Sorry for the late response. I don't think this is caused by my changes (crrev.com/c/887858, crrev.com/c/898432). I reverted these changes from a Chrome version built off of tip of tree (66.0.3354.0) and still see the same issue. The "Browse" button does not appear.
,
Mar 6 2018
,
Mar 7 2018
paper-input was recently updated to the 2.* version. That change landed in 66.0.3348.0. https://chromium.googlesource.com/chromium/src/+/dbf4d6cce495d5797ffde3fdd04006b3e4000e39
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49129683335bb8ab1a3d77dd4d7c363cc36f9c8c commit 49129683335bb8ab1a3d77dd4d7c363cc36f9c8c Author: Xiaoqian Dai <xdai@chromium.org> Date: Wed Mar 07 20:03:43 2018 CUPS: Fix the regression that BROWSE button is missing in Add Printer dialog. Bug: 814631 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8456707c5d72052e1dbda6a364d6b2c1d2a7ec8b Reviewed-on: https://chromium-review.googlesource.com/952084 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#541539} [modify] https://crrev.com/49129683335bb8ab1a3d77dd4d7c363cc36f9c8c/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html [modify] https://crrev.com/49129683335bb8ab1a3d77dd4d7c363cc36f9c8c/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html
,
Mar 7 2018
,
Mar 7 2018
,
Mar 8 2018
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3a5a01428d50e1a48fd820dee91820c6e15adf7 commit d3a5a01428d50e1a48fd820dee91820c6e15adf7 Author: Xiaoqian Dai <xdai@chromium.org> Date: Thu Mar 08 01:23:05 2018 [Merge to M66] CUPS: Fix the regression that BROWSE button is missing in Add Printer dialog. Bug: 814631 TBR=hcarmona@chromium.org (cherry picked from commit 49129683335bb8ab1a3d77dd4d7c363cc36f9c8c) Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8456707c5d72052e1dbda6a364d6b2c1d2a7ec8b Reviewed-on: https://chromium-review.googlesource.com/952084 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#541539} Reviewed-on: https://chromium-review.googlesource.com/954409 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#80} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/d3a5a01428d50e1a48fd820dee91820c6e15adf7/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html [modify] https://crrev.com/d3a5a01428d50e1a48fd820dee91820c6e15adf7/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kbleicher@chromium.org
, Feb 22 2018