The .png files can replace these:
https://codesearch.chromium.org/chromium/src/ash/resources/default_100_percent/cros/crostini/logo_crostini_terminal.png
https://codesearch.chromium.org/chromium/src/ash/resources/default_200_percent/cros/crostini/logo_crostini_terminal.png

Please keep the names the same, then they should just work.

re #1.
Why are the .png in codesearch 96px? Aren't we using 256px icon like other system apps?

Assets attached, in 128 and 256px variant. Let me know if you need other sizes, in which case I'll have to understand why we ship different sizes for some apps.

Deleted: Assets.zip 16.1 KB

Assets.zip 16.1 KB Download

shouldn't we have a source file (e.g. a svg) checked in that we can then prerender at different sizes ?

.svg tends to break with complex shadow rendering, this is why I used .png.
I can also provide a way bigger version, right now we don't go beyond 256px in the UI.

surely you have some other source material than just a png ?  is the shadow fade here really necessary at all ?  if throwing that away so svg can be used as a source format, i'd say go for it.  i'd be hard pressed to say most people would really even notice it ...

if png is necessary, then ideally, there would always be a "ridiculously" large source material that can be scaled/downsized to the desired resolution.  like a 1024x1024 or something.  taking the approach of "256px is the largest we need today" is only setting us up for trouble in the future :/.

only providing small images is something i frequently run into as i try to re-use the image in different or larger settings, and scaling up the largest asset at hand is just ugly.

>surely you have some other source material than just a png ?  is the shadow fade here really necessary at all ?  if throwing that away so svg can be used as a source format, i'd say go for it.  i'd be hard pressed to say most people would really even notice it ...

There is more than shadow, there are highlights, drop-shadow and 45° angle shadow. Not to draw too big of a parallel here but it's like saying all illustrations should be done in stick figure because it achieves the same thing and it's simpler. It's true but not necessarily desirable. That's why Android delivers large .pngs for product icons and drawable for simple flat system icons.

The reason why it's 256 max is because we support up to 2x and the deliverables specs for Webstore icon, which also are used for our current system icons is 128px. https://developer.chrome.com/webstore/images#iconsize.

I've added to this bug a big .png version as well as an .svg. If you can make the .svg look exactly like the .png once implemented in the system, I'd be more than happy to transition our icons to .svg.

Deleted: crostini-large.png 154 KB

	crostini-large.png 154 KB View Download

Deleted: crostini.svg 4.0 KB

crostini.svg 4.0 KB Download

James Cook is asking on this CL https://chromium-review.googlesource.com/c/chromium/src/+/938543 why this higher res is needed when he's "having trouble finding an "other system app" that uses 256px icons. I wonder if those 256px icons are used elsewhere. I'm pretty sure the app list actually displays icons at 48px and 96px."

Thanks Sebastien, this looks great!

Sorry, I somehow missed #8. @nverne, it does seem that Files.app has 128px & 256px icons [1]. The link in #7 also shows the Web Store recommends a 128px icon with padding so that the icon appears to be 96px. Do you have any concerns with checking in these icons?

[1] https://codesearch.chromium.org/chromium/src/ui/file_manager/file_manager/common/images/

Here's the final assets based on off-thread discussion:
https://drive.google.com/open?id=1sVbfIxAnGZO6mknxj9qXticd52vyeUaM

Single 192*192px .png, which is the format I'd like to go forward with in the future for system apps icons.

@tbuckley, putting together the proposal, I'll update you as soon as possible.

I've made a mistake in the inner's of the MD icon guidelines,
Corrected icon attached with slight increase in circle diameter.
So sorry for the back and forth.

Final assets updated here:
https://drive.google.com/file/d/1kRrJtFhNdb4l8_78U0mI0qvd8Hi5Ga9-/view?usp=sharing

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5eceb86cc386e03d195dfc55cfcc470d32eeee6e

commit 5eceb86cc386e03d195dfc55cfcc470d32eeee6e
Author: Nicholas Verne <nverne@chromium.org>
Date: Thu Mar 15 00:22:31 2018

Higher res crostini terminal logo.

Bug:  814626 
Change-Id: I8d4622c78b6e2404c7012f28319cbe8ca37690d9
Reviewed-on: https://chromium-review.googlesource.com/938543
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543250}
[modify] https://crrev.com/5eceb86cc386e03d195dfc55cfcc470d32eeee6e/ash/resources/default_100_percent/cros/crostini/logo_crostini_terminal.png
[delete] https://crrev.com/d3ee3f449c50603ba518f90e3f7752a3bebe37e6/ash/resources/default_200_percent/cros/crostini/logo_crostini_terminal.png

Icon has been delivered. Let me know if you need anything else from the design side.

Chrome: 72.0.3626.30
Chrome OS: 11316.36.0

Verify fix