New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814608 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 800876



Sign in to add a comment

Support running code coverage tool on iOS platform

Project Member Reported by liaoyuke@chromium.org, Feb 22 2018

Issue description

Support running code coverage tool on iOS platform
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0c8c2ff5118e0d87562a0fdcfb03497c373df8a

commit a0c8c2ff5118e0d87562a0fdcfb03497c373df8a
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Feb 28 20:14:10 2018

[Coverage] Support running code coverage tool on iOS platform

This CL supports running the code coverage tool on iOS platform and
removes the ios/tools/coverage.

Bug:  814608 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I135c9505a7f2aadc9cd71ca5f6b3893776aed116
Reviewed-on: https://chromium-review.googlesource.com/935195
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539940}
[modify] https://crrev.com/a0c8c2ff5118e0d87562a0fdcfb03497c373df8a/build/config/ios/BUILD.gn
[modify] https://crrev.com/a0c8c2ff5118e0d87562a0fdcfb03497c373df8a/build/config/ios/ios_sdk.gni
[modify] https://crrev.com/a0c8c2ff5118e0d87562a0fdcfb03497c373df8a/ios/build/tools/setup-gn.py
[delete] https://crrev.com/bc8d95c6aaef7e85d2546ad207d5820c657d5def/ios/tools/OWNERS
[delete] https://crrev.com/bc8d95c6aaef7e85d2546ad207d5820c657d5def/ios/tools/coverage/coverage.py
[delete] https://crrev.com/bc8d95c6aaef7e85d2546ad207d5820c657d5def/ios/tools/coverage/example.html
[delete] https://crrev.com/bc8d95c6aaef7e85d2546ad207d5820c657d5def/ios/tools/coverage/html_templates/footer.html
[delete] https://crrev.com/bc8d95c6aaef7e85d2546ad207d5820c657d5def/ios/tools/coverage/html_templates/header.html
[delete] https://crrev.com/bc8d95c6aaef7e85d2546ad207d5820c657d5def/ios/tools/coverage/html_templates/table.html
[modify] https://crrev.com/a0c8c2ff5118e0d87562a0fdcfb03497c373df8a/testing/gtest/BUILD.gn
[modify] https://crrev.com/a0c8c2ff5118e0d87562a0fdcfb03497c373df8a/tools/code_coverage/coverage.py

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b292683457817eb87122a16614a6af7f58b5b584

commit b292683457817eb87122a16614a6af7f58b5b584
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Fri Mar 02 17:34:29 2018

[Coverage] Reland disappeared changes.

In a previous CL, I screwed up while trying to rebase and accidentally
reverted all the changes that was meant to be landed. Please see:

https://chromium-review.googlesource.com/c/chromium/src/+/935195/10..11/tools/code_coverage/coverage.py

So, in this CL re-land those changes, sorry about the inconvenience!

Bug:  814608 

Change-Id: I5cb7a87d851aa4d97b05fde9a243677c07eb13d8
Reviewed-on: https://chromium-review.googlesource.com/945422
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540546}
[modify] https://crrev.com/b292683457817eb87122a16614a6af7f58b5b584/tools/code_coverage/coverage.py

Status: Fixed (was: Assigned)

Sign in to add a comment