New issue
Advanced search Search tips

Issue 814582 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 495204



Sign in to add a comment

`mb gen` doesn't work on win/cross bot

Project Member Reported by thakis@chromium.org, Feb 22 2018

Issue description

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2Flinux-win_cross-rel%2F44%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout

...
views_unittests
webkit_unit_tests
wm_unittests
wtf_unittests
zucchini_unittests
EOF
%
Traceback (most recent call last):
  File "/b/c/b/linux_win_cross_rel/src/tools/mb/mb.py", line 63, in Main
    ret = self.args.func()
  File "/b/c/b/linux_win_cross_rel/src/tools/mb/mb.py", line 286, in CmdGen
    return self.RunGNGen(vals)
  File "/b/c/b/linux_win_cross_rel/src/tools/mb/mb.py", line 767, in RunGNGen
    ', '.join(runtime_deps_targets))
MBErr: did not generate any of google_apis_unittests.runtime_deps
step returned non-zero exit code: 1



That's because:

thakis@thakis:~/src/chrome/src$ find out/Release/ -name '*google_apis_unittests*'
out/Release/google_apis_unittests.exe.runtime_deps


So it has a ".exe" in the file name.


Hmm, on Windows hosts the isolate list doesn't contain .exe either: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.win%2FWin_Builder%2F51296%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Flogs%2Fswarming-targets-file.txt%2F0


Not sure yet why this doesn't work
 

Comment 1 by thakis@chromium.org, Feb 22 2018

Aha, mb.py has this

      elif self.platform == 'win32':
        runtime_deps_targets = [target + '.exe.runtime_deps']
      else:
        runtime_deps_targets = [target + '.runtime_deps']
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d94b71a999ecc6f23abbc4452060d640dc0d788e

commit d94b71a999ecc6f23abbc4452060d640dc0d788e
Author: Nico Weber <thakis@chromium.org>
Date: Thu Feb 22 22:00:30 2018

Teach mb to be able to generate Windows GN files while running under Linux.

Bug:  814582 
Change-Id: I69b28df9f81dd5cb39dcd3b1616f1b0c70db8532
Reviewed-on: https://chromium-review.googlesource.com/930401
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538580}
[modify] https://crrev.com/d94b71a999ecc6f23abbc4452060d640dc0d788e/tools/mb/mb.py

Comment 4 by thakis@chromium.org, Feb 22 2018

Status: Fixed (was: Unconfirmed)

Sign in to add a comment