New issue
Advanced search Search tips

Issue 814576 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

gclient verify failure for chromeos devs

Project Member Reported by achuith@chromium.org, Feb 22 2018

Issue description

gclient verify fails thus:
achuith@achuithz620:~/code/chrome/src$ gclient verify
There are deps from not allowed hosts in file .DEPS.git
	src/chrome/android/profiles at https://chrome-infra-packages.appspot.com/chromium/afdo/profiles/android@version:3309
	src/third_party/accessibility_test_framework at https://chrome-infra-packages.appspot.com/chromium/third_party/accessibility-test-framework@version:2.1-cr0
	src/third_party/android_support_test_runner at https://chrome-infra-packages.appspot.com/chromium/third_party/android_support_test_runner@version:0.5-cr0
	src/third_party/android_system_sdk at https://chrome-infra-packages.appspot.com/chromium/third_party/android_system_sdk@version:27-cr0
	src/third_party/apk-patch-size-estimator at https://chrome-infra-packages.appspot.com/chromium/third_party/apk-patch-size-estimator@version:0.2-cr0
	src/third_party/bazel at https://chrome-infra-packages.appspot.com/chromium/third_party/bazel@version:0.10.0
	src/third_party/bouncycastle at https://chrome-infra-packages.appspot.com/chromium/third_party/bouncycastle@version:1.46-cr0
	src/third_party/byte_buddy at https://chrome-infra-packages.appspot.com/chromium/third_party/byte_buddy@version:1.4.17-cr0
	src/third_party/espresso at https://chrome-infra-packages.appspot.com/chromium/third_party/espresso@version:2.2.1-cr0
	src/third_party/gson at https://chrome-infra-packages.appspot.com/chromium/third_party/gson@version:2.8.0-cr0
	src/third_party/guava at https://chrome-infra-packages.appspot.com/chromium/third_party/guava@version:23.0-cr0
	src/third_party/hamcrest at https://chrome-infra-packages.appspot.com/chromium/third_party/hamcrest@version:1.3-cr0
	src/third_party/icu4j at https://chrome-infra-packages.appspot.com/chromium/third_party/icu4j@version:53.1-cr0
	src/third_party/intellij at https://chrome-infra-packages.appspot.com/chromium/third_party/intellij@version:12.0-cr0
	src/third_party/javax_inject at https://chrome-infra-packages.appspot.com/chromium/third_party/javax_inject@version:1-cr0
	src/third_party/objenesis at https://chrome-infra-packages.appspot.com/chromium/third_party/objenesis@version:2.4-cr0
	src/third_party/ow2_asm at https://chrome-infra-packages.appspot.com/chromium/third_party/ow2_asm@version:5.0.1-cr0
	src/third_party/robolectric at https://chrome-infra-packages.appspot.com/chromium/third_party/robolectric@version:3.5.1
	src/third_party/sqlite4java at https://chrome-infra-packages.appspot.com/chromium/third_party/sqlite4java@version:0.282-cr0
	src/third_party/xstream at https://chrome-infra-packages.appspot.com/chromium/third_party/xstream@version:1.4.8-cr0
allowed_hosts: android.googlesource.com, webrtc.googlesource.com, skia.googlesource.com, aomedia.googlesource.com, chrome-internal.googlesource.com, chromium.googlesource.com, boringssl.googlesource.com, pdfium.googlesource.com, swiftshader.googlesource.com
Error: dependencies from disallowed hosts; check your DEPS file.



gclient verify is used by PRESUBMIT.py here:
https://cs.chromium.org/chromium/src/PRESUBMIT.py?l=769

So any CL updating DEPS can't be uploaded by a chromeos dev.
 
Cc: dpranke@chromium.org
Owner: achuith@chromium.org
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/c/chromium/src/+/930330
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6a944c8eb38d761844c21b25d2137ef92dad3d7

commit f6a944c8eb38d761844c21b25d2137ef92dad3d7
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Thu Feb 22 21:56:04 2018

Roll src/third_party/chromite/ 7dd3b4e6d..c1049d910 (38 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/7dd3b4e6d7a6..c1049d910642

$ git log 7dd3b4e6d..c1049d910 --date=short --no-merges --format='%ad %ae %s'
2018-02-21 ihf pre-cq: replace lumpy with zako, change kevin to arcnext.
2018-02-21 dgarrett chromeos_config: Disable branch-util-tryjob artifacts.
2018-02-09 bhthompson Make eve-arcnext paladin important
2018-02-20 nxia use --ignore_locks when sync_chrome.
2018-02-17 manojgupta Fuzzer: Add custom stages for fuzzer builder.
2018-02-19 laszio afdo: clean gcc/gcov codes up, part2.
2018-02-15 nxia auth: set GetAccessToken to take **kwargs
2018-02-16 davidriley auto_updater: Handle slow reboots during verification better.
2018-02-17 pprabhu Revert "cbuildbot: (workaround) Bump up MoblabVMTestStage timeout."
2018-02-14 laszio afdo: update profiles from CWP
2018-02-12 manojgupta chromite: Add a stage to generate sysroot for the builds.
2018-02-17 chrome-bot Update config settings by config-updater.
2018-02-06 phobbs tree_status: Fix link to suite details
2018-02-14 laszio afdo: clean gcc/gcov codes up
2018-02-08 vapier cli.command: clarify IPv4/IPv6 syntax
2018-02-14 pprabhu lib: Use virtio scsi disks for both boot and external disk.
2018-01-19 pprabhu cbuildbot: Locally stage artifacts on devserver inside moblab.
2018-02-16 jkop moblabvm: Add some troubleshooting instructions
2018-02-14 pberny octopus: Add builder configuration.
2018-02-12 pprabhu lib: Delete unneeded image files from moblabvm workspace.
2018-02-13 pprabhu lib: Use virtio for moblabvm's external disk.
2018-02-15 pprabhu cli: Fix typos in README.
2018-02-15 pprabhu Add a README for moblabvm.
2018-02-15 dgarrett Revert "cbuildbot_run: Adjust GetVersion to use CIDB Id."
2018-02-14 achuith [cros_vm]: Use autoninja instead.
2018-02-13 manojgupta fuzzer: Switch fuzzer builds to full builders.
2018-01-16 dgarrett cbuildbot_run: Adjust GetVersion to use CIDB Id.
2017-11-13 deanliao [bisect] Deal with build/deploy/eval failure.
2018-02-13 chrome-bot Update config settings by config-updater.
2018-02-13 davidriley auto_updater: Increase time to allow device to reboot after quick provision.
2018-02-09 ejcaruso validation_pool: add sources under weave/
2018-02-07 vbendeb gob_util: print more sensible GOB error message
2018-01-24 pprabhu cbuildbot: Collect autotest tarball commands into one.
2018-02-08 iannucci [luci-auth] Replace all mentions of authutil with luci-auth.
2018-02-12 weigua Add rtanalytics user to audio group
2018-01-23 pprabhu lib: Add a contextmanager to mount moblab external disk in MoblabVm.
2018-02-09 dgarrett sync_chrome: Add support for revision HEAD.
2018-02-12 nxia git: make RemoteRef a namedtuple.

Created with:
  roll-dep src/third_party/chromite

Also add chrome-infra-packages.appspot.com to allowed_hosts

Bug: 762650, 814576 
Change-Id: I2bbe3974275d15a2fa508fd82f8b63debd770717
Reviewed-on: https://chromium-review.googlesource.com/930330
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538577}
[modify] https://crrev.com/f6a944c8eb38d761844c21b25d2137ef92dad3d7/DEPS

Comment 3 by mmoss@chromium.org, Feb 23 2018

Components: -Infra Infra>SDK
Status: Fixed (was: Started)

Sign in to add a comment