New issue
Advanced search Search tips

Issue 814574 link

Starred by 1 user
Status: Verified
Owner:
ioanap@chromium.org
Closed: Feb 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Export passwords... button not greyed out edit mode

Project Member Reported by ioanap@chromium.org, Feb 22 2018 
Chrome Version: 66
OS: iOS

Precondition: Have at least one password saved.

What steps will reproduce the problem?
(1) Open Chrome and navigate to Settings > Save Passwords.
(2) Tap Edit.

What is the expected result?
The Export passwords... button should be greyed out.

What happens instead?
The Export passwords... button is not greyed out.

Comment 1 by ioanap@chromium.org, Feb 22 2018

Labels: OS-iOS
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87c5f721cd1173d3d448f819d503ada58a80e125

commit 87c5f721cd1173d3d448f819d503ada58a80e125
Author: Ioana Pandele <ioanap@chromium.org>
Date: Tue Feb 27 16:09:11 2018

Disable Export Passwords button in edit mode

Bug:  814574 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I396ff63e3e0d94e635dcf88e2d6bf0b6061e3b10
Reviewed-on: https://chromium-review.googlesource.com/930471
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539443}
[modify] https://crrev.com/87c5f721cd1173d3d448f819d503ada58a80e125/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
[modify] https://crrev.com/87c5f721cd1173d3d448f819d503ada58a80e125/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm

Comment 3 by ioanap@chromium.org, Feb 28 2018

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c145105dccd0721b7e11ce51fbe7be6d36763a31

commit c145105dccd0721b7e11ce51fbe7be6d36763a31
Author: Ioana Pandele <ioanap@chromium.org>
Date: Wed Feb 28 16:36:56 2018

Don't update export button if export flag is disabled

This CL fixes a bug that causes a crash when the export feature is disabled.

Bug:  789122 ,  814574 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I19bca436ff86cb93b7b2fea786e8e4dfcb9dd4b9
Reviewed-on: https://chromium-review.googlesource.com/941123
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539848}
[modify] https://crrev.com/c145105dccd0721b7e11ce51fbe7be6d36763a31/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm

Comment 5 by ioanap@chromium.org, Mar 1 2018

Labels: M-66

Comment 6 by subhashi...@chromium.org, Mar 6 2018

Status: Verified (was: Fixed)
Verified in:

App Version: 67.0.3363.0 canary
Devices: iPhone 7, iPad Air, iPhone 8 Plus
iOS Versions: 10.3.3, 11.2.6, 11.3 beta 4

Export Passwords is disabled in Edit mode.
ExportPasswordsInEditMode.jpg
140 KB View Download
►

Sign in to add a comment