New issue
Advanced search Search tips

Issue 814562 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security

Blocking:
issue v8:7400



Sign in to add a comment

DCHECK failure in code->owner()->compiled_module()->owning_instance() == codemap()->instance() in

Project Member Reported by ClusterFuzz, Feb 22 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6079628364742656

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  code->owner()->compiled_module()->owning_instance() == codemap()->instance() in 
  v8::internal::wasm::ThreadImpl::CallWasmCode
  CallIndirectFunction
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=51426:51427

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6079628364742656

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 22 2018

Components: Blink>JavaScript>WebAssembly
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Feb 22 2018

Labels: Test-Predator-Auto-Owner
Owner: titzer@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/0c1b4c257b6bbb26d90d618b8bde556dae2a845d ([wasm] Move indirect function tables into the WasmContext).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Blocking: v8:7400
Cc: titzer@chromium.org
Labels: Pri-1
Owner: clemensh@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/537885e82946f03a323681ac0384cf7b7e5ec84b

commit 537885e82946f03a323681ac0384cf7b7e5ec84b
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Thu Feb 22 19:51:41 2018

[wasm][interpreter] Fix indirect calls to other instances

When calling a function through a function table, check whether the
instance of the called function differs from the current instance, and
in that case call the other function via a c-wasm-entry instead of
interpreting it.
The c-wasm-entry needs to pass the wasm context, so this CL changes
this to receive the wasm context as parameter instead of embedding the
context of the calling instance.

R=titzer@chromium.org

Bug:  chromium:814562 ,  v8:7400 
Change-Id: Iea93f270542169f8aac4f8c81aacec559c716368
Reviewed-on: https://chromium-review.googlesource.com/930966
Reviewed-by: Ben Titzer <titzer@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51485}
[modify] https://crrev.com/537885e82946f03a323681ac0384cf7b7e5ec84b/src/compiler/wasm-compiler.cc
[modify] https://crrev.com/537885e82946f03a323681ac0384cf7b7e5ec84b/src/compiler/wasm-compiler.h
[modify] https://crrev.com/537885e82946f03a323681ac0384cf7b7e5ec84b/src/wasm/wasm-code-wrapper.cc
[modify] https://crrev.com/537885e82946f03a323681ac0384cf7b7e5ec84b/src/wasm/wasm-code-wrapper.h
[modify] https://crrev.com/537885e82946f03a323681ac0384cf7b7e5ec84b/src/wasm/wasm-debug.cc
[modify] https://crrev.com/537885e82946f03a323681ac0384cf7b7e5ec84b/src/wasm/wasm-interpreter.cc
[modify] https://crrev.com/537885e82946f03a323681ac0384cf7b7e5ec84b/test/cctest/wasm/test-c-wasm-entry.cc
[modify] https://crrev.com/537885e82946f03a323681ac0384cf7b7e5ec84b/test/mjsunit/wasm/interpreter.js

Status: Fixed (was: Started)
Project Member

Comment 7 by ClusterFuzz, Feb 23 2018

ClusterFuzz has detected this issue as fixed in range 51484:51485.

Detailed report: https://clusterfuzz.com/testcase?key=6079628364742656

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  code->owner()->compiled_module()->owning_instance() == codemap()->instance() in 
  v8::internal::wasm::ThreadImpl::CallWasmCode
  CallIndirectFunction
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=51426:51427
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=51484:51485

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6079628364742656

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Feb 23 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6079628364742656 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Feb 24 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 1 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment