New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 814535 link

Starred by 2 users
Status: Verified
Owner:
calamity@chromium.org
Closed: Apr 2018
Cc:
hwi@chromium.org
alancutter@chromium.org
dhadd...@chromium.org
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

[desktop-pwas] Too narrow spacing for menu and permission icons

Project Member Reported by mgiuca@chromium.org, Feb 21 2018 
Chrome Version: 66.0.3344.0
OS: Chrome

- More spacing helps touch interactions.
- Spacing refinements should be explored by UX, e.g. more side spacing for 3-dot (frequently used)

Hwi: No clear guidance here. Should we wait for a proper spec?
page-action-padding.png
25.8 KB View Download

Comment 1 by hwi@chromium.org, Feb 24 2018

Cc: hwi@chromium.org
Owner: ----
Status: Available (was: Assigned)
01 spec - title bar - page action icons.png
22.8 KB View Download
02 spec - title bar - page action icons.png
19.4 KB View Download

Comment 2 by hwi@chromium.org, Feb 24 2018 

Details on c#1: The current spacing between buttons seem 2pt. Desired fix is to make them all 8pt (increase by 6pt).

Comment 3 by hwi@chromium.org, Feb 24 2018

Cc: -calamity@chromium.org
Owner: calamity@chromium.org
Status: Assigned (was: Available)

Comment 4 by mgiuca@chromium.org, Mar 26 2018

Labels: M-67

Comment 5 by mgiuca@chromium.org, Mar 27 2018

Labels: -Pri-3 Pri-2
Dropping to Pri-2 by UX request.

Comment 6 by calamity@chromium.org, Apr 4 2018 

CL at https://chromium-review.googlesource.com/c/chromium/src/+/994933.
h8niKu2590H.png
3.1 KB View Download

Comment 7 by mgiuca@chromium.org, Apr 6 2018

Labels: Pri-3
Pushing back to P3 (this is less urgent than the other P2s).
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d38f842882490fee34341b07df3a67e857f9917

commit 9d38f842882490fee34341b07df3a67e857f9917
Author: Christopher Lam <calamity@chromium.org>
Date: Wed Apr 11 07:38:54 2018

[desktop-pwas] Adjust padding of title bar buttons.

This CL makes all buttons in the title bar separated by 8px. It also
hides the BrowserActionsContainer when no actions are showing, and
forces the AppMenuButton to be 24x24.

Bug:  814535 
Change-Id: Ibfa3a87d8889f36b9e4c969f6b263d1cd48e05e5
Reviewed-on: https://chromium-review.googlesource.com/994933
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549812}
[modify] https://crrev.com/9d38f842882490fee34341b07df3a67e857f9917/chrome/browser/ui/layout_constants.cc
[modify] https://crrev.com/9d38f842882490fee34341b07df3a67e857f9917/chrome/browser/ui/layout_constants.h
[modify] https://crrev.com/9d38f842882490fee34341b07df3a67e857f9917/chrome/browser/ui/toolbar/toolbar_actions_bar.h
[modify] https://crrev.com/9d38f842882490fee34341b07df3a67e857f9917/chrome/browser/ui/views/frame/hosted_app_button_container.cc
[modify] https://crrev.com/9d38f842882490fee34341b07df3a67e857f9917/chrome/browser/ui/views/frame/hosted_app_menu_button.cc
[modify] https://crrev.com/9d38f842882490fee34341b07df3a67e857f9917/chrome/browser/ui/views/frame/hosted_app_menu_button.h

Comment 9 by mgiuca@chromium.org, Apr 11 2018

Status: Fixed (was: Assigned)

Comment 10 by mkarkada@chromium.org, May 10 2018

Cc: dhadd...@chromium.org
Status: Verified (was: Fixed)
Verified on M67 (10575.32.0, 67.0.3396.41).
►

Sign in to add a comment