Chrome Version: 66.0.3344.0 OS: Chrome - Find and Zoom popovers need to be slightly above the title bar. - Right-aligned to the 3-dot menu. - The 3-dot menu needs to be highlighted when they are open. As shown in mock.
Pushing back to P3 (this is less urgent than the other P2s).
67 has branched, moving bugs over to 68.
Bulk punting M68 PWA bugs to M69.
Reassigning to Alan (UI).
Issue 853379 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e35f205a1441afebe9987e606c7c876d5bfc4594 commit e35f205a1441afebe9987e606c7c876d5bfc4594 Author: Alan Cutter <alancutter@chromium.org> Date: Thu Jul 12 07:03:30 2018 Add find bar icon to hosted app windows This CL moves the find icon from LocationBarView into PageActionIconContainerView enabling the icon to appear in hosted app window title bars. This change also fixes the find icon getting nudged by crrev.com/108c0687254683b3beeaa32b6e0a86f2046a867e. Before 108c0687254683b3beeaa32b6e0a86f2046a867e: https://bugs.chromium.org/p/chromium/issues/attachment?aid=346964&signed_aid=IuPvufZswamla90tWW5FCg==&inline=1 Before CL: https://bugs.chromium.org/p/chromium/issues/attachment?aid=346965&signed_aid=Aiy5ATHUK4cWS64MyuRMdQ==&inline=1 After CL: https://bugs.chromium.org/p/chromium/issues/attachment?aid=346968&signed_aid=DR3vtzLR7tlPH3cEwibshQ==&inline=1 Bug: 788051, 814531 Change-Id: I5fa60cce484bd2553131582fc39e6737da34e967 Reviewed-on: https://chromium-review.googlesource.com/1054908 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574499} [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/find_bar/find_bar_controller.cc [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/location_bar/location_bar.h [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/page_action/page_action_icon_container.h [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/views/frame/browser_view_layout.cc [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/views/frame/hosted_app_button_container.cc [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/views/frame/hosted_app_button_container.h [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/views/frame/toolbar_button_provider.h [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/views/location_bar/find_bar_icon.cc [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/views/location_bar/find_bar_icon.h [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/views/location_bar/location_bar_view.h [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/views/page_action/page_action_icon_container_view.cc [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/views/page_action/page_action_icon_container_view.h [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/views/toolbar/toolbar_view.cc [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/browser/ui/views/toolbar/toolbar_view.h [modify] https://crrev.com/e35f205a1441afebe9987e606c7c876d5bfc4594/chrome/test/base/test_browser_window.h
Comment 1 by mgiuca@chromium.org
, Mar 26 2018