There is a lot of dead code remaining from the deprecation of Chrome Home. This issue will be used to track its removal.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d07c7943eca64cc7bd18d881d7053880f7777e4f commit d07c7943eca64cc7bd18d881d7053880f7777e4f Author: Matthew Jones <mdjones@chromium.org> Date: Thu Feb 22 21:04:15 2018 Remove areBrowserControlsAtBottom from FullscreenManager Since browser controls are never at the bottom of the screen, this patch removes the relevant method and its usages from FullscreenManager. The logic for bottom controls has not been removed as it will likely be needed for Chrome Duplex. BUG=814528 Change-Id: Ia0ea00d38c4908f71f00a5add027882281aae55f Reviewed-on: https://chromium-review.googlesource.com/930175 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#538562} [modify] https://crrev.com/d07c7943eca64cc7bd18d881d7053880f7777e4f/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/d07c7943eca64cc7bd18d881d7053880f7777e4f/chrome/android/java/src/org/chromium/chrome/browser/SwipeRefreshHandler.java [modify] https://crrev.com/d07c7943eca64cc7bd18d881d7053880f7777e4f/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java [modify] https://crrev.com/d07c7943eca64cc7bd18d881d7053880f7777e4f/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ToolbarSceneLayer.java [modify] https://crrev.com/d07c7943eca64cc7bd18d881d7053880f7777e4f/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java [modify] https://crrev.com/d07c7943eca64cc7bd18d881d7053880f7777e4f/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenManager.java [modify] https://crrev.com/d07c7943eca64cc7bd18d881d7053880f7777e4f/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba2757891a9408f2e39a938097d4bbc9ec9c67f8 commit ba2757891a9408f2e39a938097d4bbc9ec9c67f8 Author: Theresa <twellington@chromium.org> Date: Tue Feb 27 23:46:21 2018 Remove Chrome Home app menu icon row footer BUG=814528 Change-Id: Iffb128825b87b238d7e1d4ae7d49b40d2a2bb2ae Reviewed-on: https://chromium-review.googlesource.com/939531 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#539586} [delete] https://crrev.com/eea09d62ec0771b13b13b50092d62106ffe9cdfa/chrome/android/java/res/color/app_menu_button_tint.xml [delete] https://crrev.com/eea09d62ec0771b13b13b50092d62106ffe9cdfa/chrome/android/java/res/layout/icon_row_menu_footer.xml [modify] https://crrev.com/ba2757891a9408f2e39a938097d4bbc9ec9c67f8/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/ba2757891a9408f2e39a938097d4bbc9ec9c67f8/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java [delete] https://crrev.com/eea09d62ec0771b13b13b50092d62106ffe9cdfa/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuIconRowFooter.java [modify] https://crrev.com/ba2757891a9408f2e39a938097d4bbc9ec9c67f8/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java [modify] https://crrev.com/ba2757891a9408f2e39a938097d4bbc9ec9c67f8/chrome/android/java_sources.gni [modify] https://crrev.com/ba2757891a9408f2e39a938097d4bbc9ec9c67f8/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ImageViewTinterTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/188ac973cce1bb35de55e3339b92e9ba692b37ab commit 188ac973cce1bb35de55e3339b92e9ba692b37ab Author: Theresa <twellington@chromium.org> Date: Thu Mar 01 02:15:03 2018 Remove Chrome Home NTP concept Remove BottomSheetNewTabController and related logic BUG=814528 Change-Id: If02ad59bebdd6daeb45821807bfa11716cf2b361 Reviewed-on: https://chromium-review.googlesource.com/910007 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#539990} [delete] https://crrev.com/2912d2febd1a9ba9e8ce91770404a606f21bf960/chrome/android/java/res/layout/suggestions_bottom_sheet_logo.xml [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/res/menu/main_menu.xml [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/EmptyTabModel.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/EmptyTabModelObserver.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/IncognitoTabModel.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelObserver.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabWindowManager.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java [delete] https://crrev.com/2912d2febd1a9ba9e8ce91770404a606f21bf960/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNewTabController.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/java_sources.gni [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsSheetVisibilityChangeObserverTest.java [modify] https://crrev.com/188ac973cce1bb35de55e3339b92e9ba692b37ab/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/document/MockDocumentTabModel.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/498d05e073dab9c42eff58908613ef08718eb685 commit 498d05e073dab9c42eff58908613ef08718eb685 Author: Theresa <twellington@chromium.org> Date: Fri Mar 02 21:27:29 2018 Remove BottomToolbarPhone BUG=814528 Change-Id: I16d5629455b913695b1bad7febda519c51404b1d Reviewed-on: https://chromium-review.googlesource.com/941792 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#540631} [delete] https://crrev.com/968c8d22567e239273e50c3f7b63287df5099d49/chrome/android/java/res/drawable-hdpi/bottom_toolbar_top_line.png [delete] https://crrev.com/968c8d22567e239273e50c3f7b63287df5099d49/chrome/android/java/res/drawable-mdpi/bottom_toolbar_top_line.png [delete] https://crrev.com/968c8d22567e239273e50c3f7b63287df5099d49/chrome/android/java/res/drawable-xhdpi/bottom_toolbar_top_line.png [delete] https://crrev.com/968c8d22567e239273e50c3f7b63287df5099d49/chrome/android/java/res/drawable-xxhdpi/bottom_toolbar_top_line.png [delete] https://crrev.com/968c8d22567e239273e50c3f7b63287df5099d49/chrome/android/java/res/drawable/modern_bottom_toolbar_shadow.xml [delete] https://crrev.com/968c8d22567e239273e50c3f7b63287df5099d49/chrome/android/java/res/drawable/toolbar_handle_light.xml [modify] https://crrev.com/498d05e073dab9c42eff58908613ef08718eb685/chrome/android/java/res/values/dimens.xml [delete] https://crrev.com/968c8d22567e239273e50c3f7b63287df5099d49/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java [modify] https://crrev.com/498d05e073dab9c42eff58908613ef08718eb685/chrome/android/java/src/org/chromium/chrome/browser/toolbar/OWNERS [modify] https://crrev.com/498d05e073dab9c42eff58908613ef08718eb685/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java [modify] https://crrev.com/498d05e073dab9c42eff58908613ef08718eb685/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableBottomSheetContent.java [modify] https://crrev.com/498d05e073dab9c42eff58908613ef08718eb685/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/498d05e073dab9c42eff58908613ef08718eb685/chrome/android/java_sources.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b commit 3db4ae28e7b928b6e4a9cd4c65c921bb7908597b Author: Theresa <twellington@chromium.org> Date: Mon Mar 05 18:47:40 2018 Remove Chrome Home omnibox experiments Remove code for: - Chrome Home personalized omnibox experiment, originally added in https://chromium-review.googlesource.com/c/chromium/src/+/683295 - Clearing the URL on sheet open - Showing the Google 'G' when the URL is cleared BUG=814528 Change-Id: Ib08de4a00e9d33bc381f81220d67aad9c3cbf122 Reviewed-on: https://chromium-review.googlesource.com/939527 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#540881} [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/chrome/browser/about_flags.cc [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/chrome/browser/android/omnibox/autocomplete_controller_android.cc [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/chrome/browser/android/preferences/pref_service_bridge.cc [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/chrome/browser/flag_descriptions.h [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/components/omnibox/browser/omnibox_field_trial.cc [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/components/omnibox/browser/omnibox_field_trial.h [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/components/omnibox/browser/omnibox_field_trial_unittest.cc [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/components/omnibox/browser/omnibox_pref_names.cc [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/components/omnibox/browser/omnibox_pref_names.h [modify] https://crrev.com/3db4ae28e7b928b6e4a9cd4c65c921bb7908597b/components/omnibox/browser/zero_suggest_provider.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c20e491e2bec43defcaff35f325b431f4a746918 commit c20e491e2bec43defcaff35f325b431f4a746918 Author: Matthew Jones <mdjones@chromium.org> Date: Thu Mar 08 22:53:15 2018 Consolidate BottomSheet setters and clean up a bit This change removes two setters for the fullscreen manager and the tab model selector as they can be accessed in init from ChromeActivity. The height ratios of the sheet are now also referenced by their respective state. BUG=814528 Change-Id: I5a58a2ff367c7ad567d6b88b7bb8a3920632a57c Reviewed-on: https://chromium-review.googlesource.com/956342 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#541912} [modify] https://crrev.com/c20e491e2bec43defcaff35f325b431f4a746918/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/c20e491e2bec43defcaff35f325b431f4a746918/chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java [modify] https://crrev.com/c20e491e2bec43defcaff35f325b431f4a746918/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c commit 4354cf79a5706984a3e98f9d7c4f0cf9db89da3c Author: Theresa <twellington@chromium.org> Date: Mon Mar 12 16:55:04 2018 Remove BottomSheetContentController and related classes Remove BottomSheetContentController and all of the related classes/logic. The only type of bottom sheet content left is SuggestionsBottomSheetContent. There is a new ContextualSuggestionsManager that simply constructs and shows SuggestionsBottomSheetContent in the bottom sheet. This class will evolve soon. BUG=814528 Change-Id: I479deba21393b377dc228f1959624506754c502d Reviewed-on: https://chromium-review.googlesource.com/956722 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#542510} [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/BUILD.gn [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/res/color/bottom_nav_tint.xml [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/res/color/bottom_nav_tint_incognito.xml [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/res/drawable-hdpi/ic_home_grey600_24dp.png [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/res/drawable-mdpi/ic_home_grey600_24dp.png [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/res/drawable-xhdpi/ic_home_grey600_24dp.png [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/res/drawable-xxhdpi/ic_home_grey600_24dp.png [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/res/drawable-xxxhdpi/ic_home_grey600_24dp.png [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/res/layout/bottom_sheet_bottom_nav.xml [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/res/layout/bottom_sheet_nav_menu_item.xml [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/res/layout/main.xml [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/res/menu/bottom_sheet_nav_menu.xml [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSheetContent.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSheetContent.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/src/org/chromium/chrome/browser/download/OWNERS [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/src/org/chromium/chrome/browser/history/HistorySheetContent.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoBottomSheetContent.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java [add] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContextualSuggestionsManager.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNavigationItemView.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNavigationMenuView.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNavigationView.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetPaddingUtils.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/PlaceholderSheetContent.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableBottomSheetContent.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/java_sources.gni [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsSheetVisibilityChangeObserverTest.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetObserverTest.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/third_party/widget_bottomsheet_base/BUILD.gn [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/third_party/widget_bottomsheet_base/LICENSE [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/third_party/widget_bottomsheet_base/OWNERS [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/third_party/widget_bottomsheet_base/README.chromium [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationItemView.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationMenu.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationMenuView.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationPresenter.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationView.java [delete] https://crrev.com/6fa33db85ec93a61e1d64ea95296742e86ee418d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/ThemeUtils.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/browser/about_flags.cc [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/browser/flag_descriptions.h [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/test/android/BUILD.gn [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/chrome/test/android/javatests/src/org/chromium/chrome/test/BottomSheetTestRule.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/testing/variations/fieldtrial_testing_config.json [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/tools/android/eclipse/.classpath [modify] https://crrev.com/4354cf79a5706984a3e98f9d7c4f0cf9db89da3c/tools/metrics/actions/actions.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7660af561dbd468c78cbdbcc3d5e465a60812f54 commit 7660af561dbd468c78cbdbcc3d5e465a60812f54 Author: Pedro Amaral <amaralp@chromium.org> Date: Tue Mar 13 20:19:28 2018 Remove obsolete BottomSheet methods This change removes three methods from BottomSheet.java Bug: 814528 Change-Id: Ib03a1ce24e41a69dd8124daabe8355196e82d072 Reviewed-on: https://chromium-review.googlesource.com/956264 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#542895} [modify] https://crrev.com/7660af561dbd468c78cbdbcc3d5e465a60812f54/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/7660af561dbd468c78cbdbcc3d5e465a60812f54/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java [modify] https://crrev.com/7660af561dbd468c78cbdbcc3d5e465a60812f54/chrome/android/java/strings/android_chrome_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d3cdfe3ccb13f964aaba984777bdda79d20f670 commit 8d3cdfe3ccb13f964aaba984777bdda79d20f670 Author: Pedro Amaral <amaralp@chromium.org> Date: Fri Mar 16 01:15:08 2018 Removing velocity metrics Removing velocity metrics for opening the sheet since Chrome Home is deprecated. Bug: 814528 Change-Id: I45b173844f1efdbbbe6380c8f928dbe502a0840b Reviewed-on: https://chromium-review.googlesource.com/964988 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#543588} [modify] https://crrev.com/8d3cdfe3ccb13f964aaba984777bdda79d20f670/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java [modify] https://crrev.com/8d3cdfe3ccb13f964aaba984777bdda79d20f670/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0c9dcc268c4cae6e4d6b6c6ab184b9234f06c5a commit e0c9dcc268c4cae6e4d6b6c6ab184b9234f06c5a Author: Pedro Amaral <amaralp@chromium.org> Date: Fri Mar 16 22:00:09 2018 Remove Back Button Dismisses Chrome Pressing back button should only handle closing of the sheet and not dismissing Chrome. Bug: 814528 Change-Id: Iad2cafce82aa982b0645fb794a86b7a0e9d4ce36 Reviewed-on: https://chromium-review.googlesource.com/965275 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#543843} [modify] https://crrev.com/e0c9dcc268c4cae6e4d6b6c6ab184b9234f06c5a/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ceb01956bf531c6a14de8d2cd60270a67e7d9d0 commit 2ceb01956bf531c6a14de8d2cd60270a67e7d9d0 Author: Pedro Amaral <amaralp@chromium.org> Date: Fri Mar 16 23:36:35 2018 Remove unused SelectableListToolbarObserver interface This interface was never implemented so it's being removed. Bug: 814528 Change-Id: I24a7e51ac3d7575d91253ac097a5308e1fb22119 Reviewed-on: https://chromium-review.googlesource.com/956684 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#543869} [modify] https://crrev.com/2ceb01956bf531c6a14de8d2cd60270a67e7d9d0/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a90a69126139a579e6e1dca1123dab49090a68b commit 7a90a69126139a579e6e1dca1123dab49090a68b Author: Pedro Amaral <amaralp@chromium.org> Date: Mon Mar 19 21:57:29 2018 Removing ChromeHomeIphBubbleController Bug: 814528 Change-Id: I957587117090cfea68277964adabdf8464d77298 Reviewed-on: https://chromium-review.googlesource.com/967276 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#544178} [modify] https://crrev.com/7a90a69126139a579e6e1dca1123dab49090a68b/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/7a90a69126139a579e6e1dca1123dab49090a68b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/7a90a69126139a579e6e1dca1123dab49090a68b/chrome/android/java/src/org/chromium/chrome/browser/SwipeRefreshHandler.java [modify] https://crrev.com/7a90a69126139a579e6e1dca1123dab49090a68b/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java [delete] https://crrev.com/3c5a9f98d3809da6a12843660947f8cad3d7633d/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/ChromeHomeIphBubbleController.java [modify] https://crrev.com/7a90a69126139a579e6e1dca1123dab49090a68b/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/ChromeHomeIphMenuHeader.java [modify] https://crrev.com/7a90a69126139a579e6e1dca1123dab49090a68b/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/7a90a69126139a579e6e1dca1123dab49090a68b/chrome/android/java_sources.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/126e07f1b5cb066842dd6cebb441c2bea1c136f8 commit 126e07f1b5cb066842dd6cebb441c2bea1c136f8 Author: Pedro Amaral <amaralp@chromium.org> Date: Mon Mar 19 22:00:52 2018 Moved TouchRestrictingFrameLayout class to its own file. Bug: 814528 Change-Id: Id48a4a0d90579c68961752747c252338ff6c73c7 Reviewed-on: https://chromium-review.googlesource.com/967246 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#544180} [modify] https://crrev.com/126e07f1b5cb066842dd6cebb441c2bea1c136f8/chrome/android/java/res/layout/bottom_control_container.xml [modify] https://crrev.com/126e07f1b5cb066842dd6cebb441c2bea1c136f8/chrome/android/java/res/layout/bottom_sheet.xml [modify] https://crrev.com/126e07f1b5cb066842dd6cebb441c2bea1c136f8/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java [add] https://crrev.com/126e07f1b5cb066842dd6cebb441c2bea1c136f8/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/TouchRestrictingFrameLayout.java [modify] https://crrev.com/126e07f1b5cb066842dd6cebb441c2bea1c136f8/chrome/android/java_sources.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68664907a937dbee846a874756778e5be21b857b commit 68664907a937dbee846a874756778e5be21b857b Author: Pedro Amaral <amaralp@chromium.org> Date: Mon Mar 19 22:36:15 2018 Removed getViewsForPadding BottomSheetContent#getViewsForPadding() was never used so this CL removes it. Bug: 814528 Change-Id: I9f4113671a8b2784096e99d5d1bbcdd675a97550 Reviewed-on: https://chromium-review.googlesource.com/967093 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#544187} [modify] https://crrev.com/68664907a937dbee846a874756778e5be21b857b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java [modify] https://crrev.com/68664907a937dbee846a874756778e5be21b857b/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23b8f3b9a69af2ae57bd9e93535ad8f53bb98a69 commit 23b8f3b9a69af2ae57bd9e93535ad8f53bb98a69 Author: Pedro Amaral <amaralp@chromium.org> Date: Mon Mar 19 22:54:08 2018 Removed BottomSheetContent#isIncognitoThemedContent BottomSheetContent#isIncognitoThemedContent() always returns false so this CL removes it. Bug: 814528 Change-Id: I85ad1676fd9847b3055ee69dc196baee1882579e Reviewed-on: https://chromium-review.googlesource.com/967098 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#544196} [modify] https://crrev.com/23b8f3b9a69af2ae57bd9e93535ad8f53bb98a69/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java [modify] https://crrev.com/23b8f3b9a69af2ae57bd9e93535ad8f53bb98a69/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21a5a3f54a6e826c139beecca9b19d90fcec4895 commit 21a5a3f54a6e826c139beecca9b19d90fcec4895 Author: Pedro Amaral <amaralp@chromium.org> Date: Tue Mar 20 19:57:24 2018 Removed Dead StateChangeReasons Removed the elements: OMNIBOX_FOCUS, NEW_TAB, EXPAND_BUTTON, STARTUP from StateChangeReason enum. Also made the corresponding metrics obsolete. Bug: 814528 Change-Id: I56ec0cd3eefd2e61e2ed7f4e49cc4317989bf311 Reviewed-on: https://chromium-review.googlesource.com/963686 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#544497} [modify] https://crrev.com/21a5a3f54a6e826c139beecca9b19d90fcec4895/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/21a5a3f54a6e826c139beecca9b19d90fcec4895/chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java [modify] https://crrev.com/21a5a3f54a6e826c139beecca9b19d90fcec4895/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java [modify] https://crrev.com/21a5a3f54a6e826c139beecca9b19d90fcec4895/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetMetrics.java [modify] https://crrev.com/21a5a3f54a6e826c139beecca9b19d90fcec4895/tools/metrics/actions/actions.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4afd65f3aa4d7dc09535e62d8cafd1b0c641c9e7 commit 4afd65f3aa4d7dc09535e62d8cafd1b0c641c9e7 Author: Pedro Amaral <amaralp@chromium.org> Date: Tue Mar 20 21:40:21 2018 Removing CHROME_HOME_INACTIVITY_SHEET_EXPANSION feature Bug: 814528 Change-Id: Ie4b23d93a4ed341249edfa8c93b4c33b55286d1f Reviewed-on: https://chromium-review.googlesource.com/969606 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#544529} [modify] https://crrev.com/4afd65f3aa4d7dc09535e62d8cafd1b0c641c9e7/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/4afd65f3aa4d7dc09535e62d8cafd1b0c641c9e7/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f39c18862539edee9ec533743219dc73e2f2317e commit f39c18862539edee9ec533743219dc73e2f2317e Author: Theresa <twellington@chromium.org> Date: Wed Mar 21 18:18:07 2018 Delete ContextualSuggestions prototypes, SuggestionsBottomSheetContent Remove dead code associated with old prototypes for the contextual suggestions carousel and bottom sheet content section. Also remove SuggestionsBottomSheetContent and associated resources. Adds a new flag for ContextualSuggestionsBottomSheet to replace the removed flags. BUG=822842,814528 Change-Id: Ie76371cbb0528f3759e8f85eba90148b2e4e61b7 Reviewed-on: https://chromium-review.googlesource.com/967274 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544773} [delete] https://crrev.com/6fc882137ffd39d10274310cd74c6cd81dff90d0/chrome/android/java/res/layout/contextual_suggestions_card.xml [delete] https://crrev.com/6fc882137ffd39d10274310cd74c6cd81dff90d0/chrome/android/java/res/layout/suggestions_bottom_sheet_content.xml [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ItemViewType.java [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NodeVisitor.java [delete] https://crrev.com/6fc882137ffd39d10274310cd74c6cd81dff90d0/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContextualSuggestionsCardViewHolder.java [delete] https://crrev.com/6fc882137ffd39d10274310cd74c6cd81dff90d0/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContextualSuggestionsManager.java [delete] https://crrev.com/6fc882137ffd39d10274310cd74c6cd81dff90d0/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContextualSuggestionsSection.java [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBinder.java [delete] https://crrev.com/6fc882137ffd39d10274310cd74c6cd81dff90d0/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java [delete] https://crrev.com/6fc882137ffd39d10274310cd74c6cd81dff90d0/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsCarousel.java [delete] https://crrev.com/6fc882137ffd39d10274310cd74c6cd81dff90d0/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsCarouselAdapter.java [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/android/java_sources.gni [delete] https://crrev.com/6fc882137ffd39d10274310cd74c6cd81dff90d0/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/ContextualSuggestionsTest.java [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [delete] https://crrev.com/6fc882137ffd39d10274310cd74c6cd81dff90d0/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/SuggestionsCarouselTest.java [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/browser/about_flags.cc [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/browser/flag_descriptions.h [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/browser/ntp_snippets/contextual_content_suggestions_service_factory.cc [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/chrome/browser/ui/webui/snippets_internals_ui.cc [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/testing/variations/fieldtrial_testing_config.json [modify] https://crrev.com/f39c18862539edee9ec533743219dc73e2f2317e/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2b9d5d605d90c6d162a77c50d8ae761d4bdf6eb commit c2b9d5d605d90c6d162a77c50d8ae761d4bdf6eb Author: Pedro Amaral <amaralp@chromium.org> Date: Thu Mar 22 21:38:38 2018 Removing ChromeHomeIphMenuHeader Bug: 814528 Change-Id: Iae714ffb132c70548036409f5af536d3980064c6 Reviewed-on: https://chromium-review.googlesource.com/967422 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#545259} [delete] https://crrev.com/e09df9251bdc1f717aa76df1629a04143971a15e/chrome/android/java/res/layout/chrome_home_iph_header.xml [delete] https://crrev.com/e09df9251bdc1f717aa76df1629a04143971a15e/chrome/android/java/res/layout/chrome_home_menu_header_icon.xml [modify] https://crrev.com/c2b9d5d605d90c6d162a77c50d8ae761d4bdf6eb/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/c2b9d5d605d90c6d162a77c50d8ae761d4bdf6eb/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [delete] https://crrev.com/e09df9251bdc1f717aa76df1629a04143971a15e/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/ChromeHomeIphMenuHeader.java [modify] https://crrev.com/c2b9d5d605d90c6d162a77c50d8ae761d4bdf6eb/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/c2b9d5d605d90c6d162a77c50d8ae761d4bdf6eb/chrome/android/java_sources.gni [modify] https://crrev.com/c2b9d5d605d90c6d162a77c50d8ae761d4bdf6eb/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java [modify] https://crrev.com/c2b9d5d605d90c6d162a77c50d8ae761d4bdf6eb/components/feature_engagement/public/feature_constants.cc [modify] https://crrev.com/c2b9d5d605d90c6d162a77c50d8ae761d4bdf6eb/components/feature_engagement/public/feature_constants.h [modify] https://crrev.com/c2b9d5d605d90c6d162a77c50d8ae761d4bdf6eb/components/feature_engagement/public/feature_list.cc [modify] https://crrev.com/c2b9d5d605d90c6d162a77c50d8ae761d4bdf6eb/components/feature_engagement/public/feature_list.h [modify] https://crrev.com/c2b9d5d605d90c6d162a77c50d8ae761d4bdf6eb/testing/variations/fieldtrial_testing_config.json [modify] https://crrev.com/c2b9d5d605d90c6d162a77c50d8ae761d4bdf6eb/tools/metrics/actions/actions.xml [modify] https://crrev.com/c2b9d5d605d90c6d162a77c50d8ae761d4bdf6eb/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2493198a6f52c7e64818839f940d8168c79c0213 commit 2493198a6f52c7e64818839f940d8168c79c0213 Author: Matthew Jones <mdjones@chromium.org> Date: Mon Apr 02 16:59:12 2018 Remove unused methods and vars from BottomSheet Bug: 814528 Change-Id: I3abfcf7c13e95964ad4d21488e2fad82c96dd4c7 Reviewed-on: https://chromium-review.googlesource.com/987619 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#547453} [modify] https://crrev.com/2493198a6f52c7e64818839f940d8168c79c0213/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsBottomSheetContent.java [modify] https://crrev.com/2493198a6f52c7e64818839f940d8168c79c0213/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9a12970577e675f231d82a59ef3cdf8f84ab7c8 commit f9a12970577e675f231d82a59ef3cdf8f84ab7c8 Author: Theresa <twellington@chromium.org> Date: Tue Apr 17 20:45:13 2018 [EoC] Cleanup find toolbar and ViewShiftingActionBarDelegate Cleanup more left-over code from Chrome Home: - Don't use BottomSheet for ViewShiftingActionBarDelegate so that copy-paste action bar pushes down top toolbar instead - Revert changes that disabled hiding the keyboard during find in page when there is a bottom sheet BUG=833606,833608,814528 Change-Id: I9f2a1262c5ffba20902e1b438cb6175a48363680 Reviewed-on: https://chromium-review.googlesource.com/1015283 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#551466} [modify] https://crrev.com/f9a12970577e675f231d82a59ef3cdf8f84ab7c8/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java [modify] https://crrev.com/f9a12970577e675f231d82a59ef3cdf8f84ab7c8/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java [modify] https://crrev.com/f9a12970577e675f231d82a59ef3cdf8f84ab7c8/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbarManager.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c39265a19faea5f304be7aee48ada626730724ad commit c39265a19faea5f304be7aee48ada626730724ad Author: Theresa <twellington@chromium.org> Date: Thu Apr 19 18:28:13 2018 [EoC] Enable app menu item translation For Chrome Home, we disabled the app menu item translation animation when showing the menu. Since we conditioned this behavior on ChromeActivity#getBottomSheet() != null, the app menu item translation animation was incorrectly disabled for EoC. BUG=833610,814528 Change-Id: I6225f7d490cc41d57b5efc6a8ffe26b706cccbbb Reviewed-on: https://chromium-review.googlesource.com/1015160 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#552091} [modify] https://crrev.com/c39265a19faea5f304be7aee48ada626730724ad/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java [modify] https://crrev.com/c39265a19faea5f304be7aee48ada626730724ad/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java [modify] https://crrev.com/c39265a19faea5f304be7aee48ada626730724ad/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ea9a086d4f54c702ec9a38e55fb3eb8bbc2401b commit 9ea9a086d4f54c702ec9a38e55fb3eb8bbc2401b Author: Pedro Amaral <amaralp@chromium.org> Date: Fri May 04 22:02:25 2018 Removing isChromeHomeEnabled() from LayoutManagerChromePhone Bug: 814528 Change-Id: I8713c31da41812150105d15489e9eebdfb88a244 Reviewed-on: https://chromium-review.googlesource.com/1043391 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#556214} [modify] https://crrev.com/9ea9a086d4f54c702ec9a38e55fb3eb8bbc2401b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/189732da5461349f64c41abd41df1c1f81a82336 commit 189732da5461349f64c41abd41df1c1f81a82336 Author: Pedro Amaral <amaralp@chromium.org> Date: Fri May 04 22:07:10 2018 Removing isChromeHomeEnabled() logic in ChromeTabbedActivity Bug: 814528 Change-Id: I5a272f73c3289e7d574d9ef4c508844d88248a1b Reviewed-on: https://chromium-review.googlesource.com/1043329 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#556216} [delete] https://crrev.com/9831ecc703d4316100735d9ed9a86702d3a34652/chrome/android/java/res/layout/bottom_control_container.xml [modify] https://crrev.com/189732da5461349f64c41abd41df1c1f81a82336/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/189732da5461349f64c41abd41df1c1f81a82336/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/189732da5461349f64c41abd41df1c1f81a82336/chrome/android/java/strings/android_chrome_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c10b0007bd1262abb824ab919613d32a2aae0409 commit c10b0007bd1262abb824ab919613d32a2aae0409 Author: Pedro Amaral <amaralp@chromium.org> Date: Sat May 05 00:59:26 2018 Removed ChromeHomeFeedbackSource Bug: 814528 Change-Id: I1474a77352fd493eaf7635d0d76955cad9ad4608 Reviewed-on: https://chromium-review.googlesource.com/1045512 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#556280} [delete] https://crrev.com/54ef03d39a3d507f46ecc34fabe86fbc0f54c663/chrome/android/java/src/org/chromium/chrome/browser/feedback/ChromeHomeFeedbackSource.java [modify] https://crrev.com/c10b0007bd1262abb824ab919613d32a2aae0409/chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java [modify] https://crrev.com/c10b0007bd1262abb824ab919613d32a2aae0409/chrome/android/java_sources.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ea60d806c02ff9a88bbf367fc4f3cc441a5f9ed commit 3ea60d806c02ff9a88bbf367fc4f3cc441a5f9ed Author: Pedro Amaral <amaralp@chromium.org> Date: Tue May 08 19:03:19 2018 Remove isChromeHomeEnabed() logic from ToolbarSceneLayer Bug: 814528 Change-Id: Ib98362502ec42cfa19de522ee40493d949295bc5 Reviewed-on: https://chromium-review.googlesource.com/1045486 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#556909} [modify] https://crrev.com/3ea60d806c02ff9a88bbf367fc4f3cc441a5f9ed/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ToolbarSceneLayer.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b89fa0aa0e74b55ade861d6ba4abc49128c7533d commit b89fa0aa0e74b55ade861d6ba4abc49128c7533d Author: Pedro Amaral <amaralp@chromium.org> Date: Tue May 08 20:21:46 2018 Remove Chrome Home menu item expand sheet Bug: 814528 Change-Id: I7fa5b0cd8dc9df2071d54cf51e5c88356096f49b Reviewed-on: https://chromium-review.googlesource.com/1043164 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#556944} [modify] https://crrev.com/b89fa0aa0e74b55ade861d6ba4abc49128c7533d/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/b89fa0aa0e74b55ade861d6ba4abc49128c7533d/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/b89fa0aa0e74b55ade861d6ba4abc49128c7533d/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java [modify] https://crrev.com/b89fa0aa0e74b55ade861d6ba4abc49128c7533d/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java [modify] https://crrev.com/b89fa0aa0e74b55ade861d6ba4abc49128c7533d/chrome/browser/about_flags.cc [modify] https://crrev.com/b89fa0aa0e74b55ade861d6ba4abc49128c7533d/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/b89fa0aa0e74b55ade861d6ba4abc49128c7533d/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/b89fa0aa0e74b55ade861d6ba4abc49128c7533d/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/b89fa0aa0e74b55ade861d6ba4abc49128c7533d/chrome/browser/flag_descriptions.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8052054a333bc4e3330f2794d513152f2e078aa9 commit 8052054a333bc4e3330f2794d513152f2e078aa9 Author: Pedro Amaral <amaralp@chromium.org> Date: Tue May 08 23:32:08 2018 Removing isChromeHomeEnabled() logic from tab stacks Bug: 814528 Change-Id: Ifb3138411966d4abe4b6bc05b5b520a6e3787db0 Reviewed-on: https://chromium-review.googlesource.com/1045425 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#557007} [modify] https://crrev.com/8052054a333bc4e3330f2794d513152f2e078aa9/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayoutBase.java [modify] https://crrev.com/8052054a333bc4e3330f2794d513152f2e078aa9/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/Stack.java [modify] https://crrev.com/8052054a333bc4e3330f2794d513152f2e078aa9/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimationLandscape.java [modify] https://crrev.com/8052054a333bc4e3330f2794d513152f2e078aa9/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackAnimationPortrait.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/155b4d54a5be98d886cf852ff0d14a3fbfce9b7d commit 155b4d54a5be98d886cf852ff0d14a3fbfce9b7d Author: Theresa <twellington@chromium.org> Date: Thu May 10 16:26:43 2018 Remove obsolete Chrome Home feature flags Remove a handful of feature flags that are no longer used. BUG=814528 Change-Id: Iaee99938d9aeac35c32477b590534a0359d62b12 Reviewed-on: https://chromium-review.googlesource.com/1053305 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#557550} [modify] https://crrev.com/155b4d54a5be98d886cf852ff0d14a3fbfce9b7d/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/155b4d54a5be98d886cf852ff0d14a3fbfce9b7d/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SiteSection.java [modify] https://crrev.com/155b4d54a5be98d886cf852ff0d14a3fbfce9b7d/chrome/android/javatests/src/org/chromium/chrome/browser/FeaturesAnnotationsTest.java [modify] https://crrev.com/155b4d54a5be98d886cf852ff0d14a3fbfce9b7d/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/155b4d54a5be98d886cf852ff0d14a3fbfce9b7d/chrome/browser/about_flags.cc [modify] https://crrev.com/155b4d54a5be98d886cf852ff0d14a3fbfce9b7d/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/155b4d54a5be98d886cf852ff0d14a3fbfce9b7d/chrome/browser/android/chrome_feature_list.h [modify] https://crrev.com/155b4d54a5be98d886cf852ff0d14a3fbfce9b7d/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/155b4d54a5be98d886cf852ff0d14a3fbfce9b7d/chrome/browser/flag_descriptions.h [modify] https://crrev.com/155b4d54a5be98d886cf852ff0d14a3fbfce9b7d/chrome/test/android/BUILD.gn [delete] https://crrev.com/290fa6c74fa7e70c9d3aabdf57cb8dedf8e09b88/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/ChromeHome.java [modify] https://crrev.com/155b4d54a5be98d886cf852ff0d14a3fbfce9b7d/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/Features.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/136c698d863366978c7b2c5bd6947218f37b35b4 commit 136c698d863366978c7b2c5bd6947218f37b35b4 Author: Theresa <twellington@chromium.org> Date: Fri Oct 19 00:00:15 2018 Remove BottomSheet code from toolbar/ and omnibox/ BUG=814528 Change-Id: Iacdefc02c01d04079d7c1d62368bd7aaabaf2e8c Reviewed-on: https://chromium-review.googlesource.com/c/1289707 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#600973} [modify] https://crrev.com/136c698d863366978c7b2c5bd6947218f37b35b4/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBar.java [modify] https://crrev.com/136c698d863366978c7b2c5bd6947218f37b35b4/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/136c698d863366978c7b2c5bd6947218f37b35b4/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java [modify] https://crrev.com/136c698d863366978c7b2c5bd6947218f37b35b4/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsList.java [modify] https://crrev.com/136c698d863366978c7b2c5bd6947218f37b35b4/chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java [modify] https://crrev.com/136c698d863366978c7b2c5bd6947218f37b35b4/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java [modify] https://crrev.com/136c698d863366978c7b2c5bd6947218f37b35b4/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java [modify] https://crrev.com/136c698d863366978c7b2c5bd6947218f37b35b4/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModel.java [modify] https://crrev.com/136c698d863366978c7b2c5bd6947218f37b35b4/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/LocationBarLayoutTest.java [modify] https://crrev.com/136c698d863366978c7b2c5bd6947218f37b35b4/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarModelTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cf3506a6ca8ee5b61efb98a26afff6a4b9e9448 commit 6cf3506a6ca8ee5b61efb98a26afff6a4b9e9448 Author: Theresa <twellington@chromium.org> Date: Mon Oct 22 17:43:52 2018 Fix LocationBarLayout#getUrlContainerMarginEnd BUG=897592,814528 Change-Id: I2c9adf2ff533446c10be19d12ec3c83a8b1e0323 Reviewed-on: https://chromium-review.googlesource.com/c/1294131 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#601637} [modify] https://crrev.com/6cf3506a6ca8ee5b61efb98a26afff6a4b9e9448/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
Comment 1 by bugdroid1@chromium.org
, Feb 22 2018