New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814523 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

deploy_server_local logic for 'tko' update action is wrong

Reported by jrbarnette@chromium.org, Feb 21 2018

Issue description

In site_utils/deploy_server_local.py, there's logic for
"determine whether a given action needs to run based on
what directories changed."  There's a dictionary that maps
certain actions to the associated directories:

# A dict to map update_commands defined in config file to repos or files that
# decide whether need to update these commands. E.g. if no changes under
# frontend repo, no need to update afe.
COMMANDS_TO_REPOS_DICT = {'afe': 'frontend/',
                          'tko': 'tko/'}


That dict is wrong.  These are the commands associated with
the 'afe' and 'tko' actions:
[UPDATE_COMMANDS]
afe: AUTOTEST_REPO/utils/compile_gwt_clients.py -c autotest.AfeClient
tko: AUTOTEST_REPO/utils/compile_gwt_clients.py -c autotest.TkoClient

Those commands compile the java code under "frontend/client".  So
both commands should be declared as dependent either on "frontend/"
or "frontend/client/".

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1b72e7f93638ad201901fc254ab5b8714a0d0e9c

commit 1b72e7f93638ad201901fc254ab5b8714a0d0e9c
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Thu Feb 22 06:27:00 2018

[autotest] Fix deploy action dependencies.

Certain local deployment actions are only run when changes are made
in specific subdirectories.  The subdirectories for the 'afe' and
'tko' actions were both specified wrong.  This change fixes them.

BUG= chromium:814523 
TEST=None

Change-Id: Ifd3c78472115fb969b83e7f0f78711e6dc467d5a
Reviewed-on: https://chromium-review.googlesource.com/930129
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Shuqian Zhao <shuqianz@chromium.org>

[modify] https://crrev.com/1b72e7f93638ad201901fc254ab5b8714a0d0e9c/site_utils/deploy_server_local.py

Status: Fixed (was: Started)

Sign in to add a comment