New issue
Advanced search Search tips

Issue 814515 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make the "Android Devices" subsection in a bot's page configurable for other devices

Project Member Reported by bpastene@chromium.org, Feb 21 2018

Issue description

See https://chromium-swarm-dev.appspot.com/bot?id=build1-a1--build2-a1

That bot's controlling a chromeos device, but the table that describes its device is labelled as "Android Devices". What makes that table render? Is it the "devices" field in the bot's state dict?

What would it take to get that to say "ChromeOS Devices" for cros bots and "Android Devices" for android bots? Also, how are the "Battery", "Avg Temp", and "State" fields populated? I'd like to fill those out for the cros bots too if I can.

Pri3 since these are still experimental bots; no rush.
 

Comment 1 by kjlubick@google.com, Feb 22 2018

> What makes that table render? Is it the "devices" field in the bot's state dict?

Yes.  It's hardcoded atm to say "Android Devices" [1]

Here's a skia ChromeOS bot for comparison: https://chromium-swarm.appspot.com/bot?id=skia-rpi-111  It seems that we should agree on a set of dimensions for ChromeOS bots to be consistent.

> What would it take to get that to say "ChromeOS Devices" for cros bots and "Android Devices" for android bots? Also, how are the "Battery", "Avg Temp", and "State" fields populated?

Not much.  Assuming we can agree on a consistent set of metrics that we care about for ChromeOS devices, we can get them populated as well.

let device = Any value in the devices object in the state object.
Battery -> looks for device.battery.level, returns it
Avg Temp -> looks for device.temp object and averages the values
State -> looks for device.state and returns it

We don't have to stick to battery, temp, state for ChromeOS, the could be different things entirely if that would be more useful for you.


[1] https://chromium.googlesource.com/infra/luci/luci-py/+/master/appengine/swarming/ui/res/imp/botpage/device-summary.html#54

Sign in to add a comment