New issue
Advanced search Search tips

Issue 814512 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Modern Media Controls: Hide overlay play button early when playback is started

Project Member Reported by steimel@chromium.org, Feb 21 2018

Issue description

Labels: -Pri-3 Pri-1
Cc: beccahughes@chromium.org
+beccahughes@ because I've seen a CL that's not too far from the bug description.
Cc: amyroberts@chromium.org
Amy, would it make sense to move this as a P2? The cost may outweigh the benefits here as we would need to handle multiple hiding logic and there are a few edge cases that are not specified in the video mock such as what happens if the user clicks on the video.
I'd be open to negotiating on a different P1 to get this in, this is a major polish item. Without it, either all the controls stick around too long and the play button obscures the video, or the scrubber controls disappear too quickly. 

Additionally, it's a standard pattern that YT, Netflix, etc all use, so I'm concerned that breaking from that norm would appear broken.

(examples for context https://photos.app.goo.gl/XX8s99MvBiZYZ5cN2)

LMK if you need detailed specs for the logic handling and edge case specifics. 
Owner: beccahughes@chromium.org
I'm actually not sure to understand the rationale.

YouTube doesn't show a play button overlay on desktop. It shows a quick play/pause animation but clicking anywhere on the video will trigger play/pause. They do not have the same issue we have with hiding the button that will be needed to pause the playback.

On mobile (native app), YouTube shows a play/pause button overlay but it does not hide it quickly. I did not measure the time but it's fairly similar to what we are doing today as far as I can tell.

Netflix never appears to have a play/pause button overlay, either on desktop or on their native application.

Moving to P2 but beccahughes has a CL up so we can either close this or land it today. Happy to jump in a VC if needed.
Labels: -Pri-1 Pri-2
Labels: -Pri-2 Pri-1
The rationale is more about the scrubber than the play button. In each of those examples, the scrubber remains onscreen for a few seconds after the video has begun to play. (YT doesn't have our exact issue since their button is integrated with the scrubber)

The idea is that in order to keep the scrubber on screen for a few seconds (and normalize with the examples in comment 4), we'll need to hide our play button. 

Bumping the priority back up, feel free to add time to my calendar if I can offer more clarification.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35938c276b40b2fc55afb8050673c1a8d163a2aa

commit 35938c276b40b2fc55afb8050673c1a8d163a2aa
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Apr 27 00:45:13 2018

Media Controls: Hide overlay play button early when playback

When playback starts immediately hide the play button.

BUG= 814512 

Change-Id: Id69c449f6830a5e6c6a0c2a332a72bf08cf88ae8
Reviewed-on: https://chromium-review.googlesource.com/1011215
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554228}
[add] https://crrev.com/35938c276b40b2fc55afb8050673c1a8d163a2aa/third_party/WebKit/LayoutTests/media/controls/modern/overlay-play-button-tap-to-hide.html
[modify] https://crrev.com/35938c276b40b2fc55afb8050673c1a8d163a2aa/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
[modify] https://crrev.com/35938c276b40b2fc55afb8050673c1a8d163a2aa/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.h
[modify] https://crrev.com/35938c276b40b2fc55afb8050673c1a8d163a2aa/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/35938c276b40b2fc55afb8050673c1a8d163a2aa/third_party/blink/renderer/modules/media_controls/media_controls_impl.h
[modify] https://crrev.com/35938c276b40b2fc55afb8050673c1a8d163a2aa/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

Labels: Merge-Request-67
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 27 2018

Labels: -Merge-Request-67 Merge-Reject-67 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M67 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: gov...@chromium.org
@govind - this is an important UI tweak for the media controls launching in M67.
Labels: -Merge-Reject-67 Merge-Request-67
How is the change listed at #9 looking canary?
Project Member

Comment 14 by sheriffbot@chromium.org, Apr 27 2018

Labels: -Merge-Request-67 Merge-Reject-67
The bug is marked as P3 or Feature. It should not be merged as M67 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Feature -Merge-Reject-67 Merge-Request-67 Type-Bug
Changing to "Type:bug" as sheriffbot continue to reject merge for "Type:Feature".
Project Member

Comment 16 by sheriffbot@chromium.org, Apr 27 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Reject
This looks good in canary
Labels: -Merge-Review-67 Merge-Approved-67
Approving merge to M67 branch 3396 based on comments #12 and #18. Please merge. Thank you.
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 27 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb11cf1d4b67c01c458dba9cad5746faa3cba57a

commit eb11cf1d4b67c01c458dba9cad5746faa3cba57a
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Apr 27 21:59:50 2018

Media Controls: Hide overlay play button early when playback

When playback starts immediately hide the play button.

BUG= 814512 

Change-Id: Id69c449f6830a5e6c6a0c2a332a72bf08cf88ae8
Reviewed-on: https://chromium-review.googlesource.com/1011215
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#554228}(cherry picked from commit 35938c276b40b2fc55afb8050673c1a8d163a2aa)
Reviewed-on: https://chromium-review.googlesource.com/1033497
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#363}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[add] https://crrev.com/eb11cf1d4b67c01c458dba9cad5746faa3cba57a/third_party/WebKit/LayoutTests/media/controls/modern/overlay-play-button-tap-to-hide.html
[modify] https://crrev.com/eb11cf1d4b67c01c458dba9cad5746faa3cba57a/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
[modify] https://crrev.com/eb11cf1d4b67c01c458dba9cad5746faa3cba57a/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.h
[modify] https://crrev.com/eb11cf1d4b67c01c458dba9cad5746faa3cba57a/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/eb11cf1d4b67c01c458dba9cad5746faa3cba57a/third_party/blink/renderer/modules/media_controls/media_controls_impl.h
[modify] https://crrev.com/eb11cf1d4b67c01c458dba9cad5746faa3cba57a/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

Status: Fixed (was: Assigned)
Issue 839112 has been merged into this issue.

Sign in to add a comment