Modern Media Controls: Enable download when preload=none |
|||||||||
Issue descriptionhttps://gallery.googleplex.com/projects/MCHbtQVoQ2HCZZIx9p6vbtpx/files/MCHtA7U1iMGr69laPZDCC2xNn8G12BWoPZA This also means we'll need to show the overflow menu before preload. We will only show the overflow menu before preload if download is enabled (since we'll only show it if something is enabled).
,
Feb 22 2018
Do we want to show the timeline even if the user can't interact with it?
,
Mar 16 2018
Here are screenshots from patchset 3. It removes the thumb and has updated scrim/timeline. This still does not show disabled fullscreen/mute buttons or other disabled overflow options, but those will be taken care of in later CLs.
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5787b01ca784633e937c7f0cdef5dc93d236035a commit 5787b01ca784633e937c7f0cdef5dc93d236035a Author: Tommy Steimel <steimel@chromium.org> Date: Mon Mar 19 19:12:27 2018 Show the timeline and overflow menu before preload This CL changes the CSS to show the timeline and overflow button before preload on the modern media controls. This exposes the download button so that the user can download a video without preloading. Bug: 814509 Change-Id: I7993204dc6d0bc38ef77e18a14ae1cfa07ab3ca8 Reviewed-on: https://chromium-review.googlesource.com/930334 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#544103} [modify] https://crrev.com/5787b01ca784633e937c7f0cdef5dc93d236035a/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css
,
Mar 19 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by steimel@chromium.org
, Feb 22 2018Status: Started (was: Assigned)
9.7 KB
9.7 KB View Download
12.5 KB
12.5 KB View Download
11.0 KB
11.0 KB View Download