New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814501 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 814497



Sign in to add a comment

Mojo StartPhishingDetection and PhishingDetectionDone in safebrowsing_messages.h

Project Member Reported by evem@chromium.org, Feb 21 2018

Issue description

Convert StartPhishingDetection and PhishingDetectionDone to use mojo.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e7bfde250c76c54d41319df68cc3c3261314dc6

commit 2e7bfde250c76c54d41319df68cc3c3261314dc6
Author: Eve Martin-Jones <evem@chromium.org>
Date: Wed Feb 21 23:41:29 2018

Convert StartPhishingDetection and PhishingDetectionDone to mojo.

- Remove SafeBrowsingHostMsg_PhishingDetectionDone and
SafeBrowsingMsg_StartPhishingDetection from safebrowsing_messages.h
and implement corresponding interfaces/methods in
safe_browsing.mojom

- Update corresponding classes (phishing_classifier_delegate.h/cc,
client_side_detection_host.h/cc) + tests to reflect these changes

- Add provides to chrome/browser/chrome_content_manifest_overlay
and chrome/browser/chrome_content_renderer_overlay as required

- Add #if defined to chrome_content_renderer_client.h/cc and
chrome_render_frame_observer.cc to only include/define
phishing related things when FULL_SAFE_BROWSING is enabled

Bug:  814501 
Change-Id: I3e82577097a861c535c4e3551d773575c017fde2
Reviewed-on: https://chromium-review.googlesource.com/923248
Commit-Queue: Eve Martin-Jones <evem@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538256}
[modify] https://crrev.com/2e7bfde250c76c54d41319df68cc3c3261314dc6/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/2e7bfde250c76c54d41319df68cc3c3261314dc6/chrome/browser/chrome_content_renderer_manifest_overlay.json
[modify] https://crrev.com/2e7bfde250c76c54d41319df68cc3c3261314dc6/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/2e7bfde250c76c54d41319df68cc3c3261314dc6/chrome/browser/safe_browsing/client_side_detection_host.h
[modify] https://crrev.com/2e7bfde250c76c54d41319df68cc3c3261314dc6/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/2e7bfde250c76c54d41319df68cc3c3261314dc6/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/2e7bfde250c76c54d41319df68cc3c3261314dc6/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/2e7bfde250c76c54d41319df68cc3c3261314dc6/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/2e7bfde250c76c54d41319df68cc3c3261314dc6/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc
[modify] https://crrev.com/2e7bfde250c76c54d41319df68cc3c3261314dc6/chrome/renderer/safe_browsing/phishing_classifier_delegate.h
[modify] https://crrev.com/2e7bfde250c76c54d41319df68cc3c3261314dc6/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc
[modify] https://crrev.com/2e7bfde250c76c54d41319df68cc3c3261314dc6/components/safe_browsing/common/BUILD.gn
[modify] https://crrev.com/2e7bfde250c76c54d41319df68cc3c3261314dc6/components/safe_browsing/common/safe_browsing.mojom
[modify] https://crrev.com/2e7bfde250c76c54d41319df68cc3c3261314dc6/components/safe_browsing/common/safebrowsing_messages.h

Comment 2 by evem@chromium.org, Feb 22 2018

Status: Fixed (was: Assigned)

Sign in to add a comment