New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 814498 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 814497



Sign in to add a comment

Mojo SetPhishingModel in safebrowsing_messages.h

Project Member Reported by evem@chromium.org, Feb 21 2018

Issue description

Convert SetPhishingModel in safebrowsing_messages.h to a mojo interface + message.
 

Comment 1 by evem@chromium.org, Feb 21 2018

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6059c242d2291030a2a77a7c2afc871f98ffdd03

commit 6059c242d2291030a2a77a7c2afc871f98ffdd03
Author: Eve Martin-Jones <evem@chromium.org>
Date: Thu Feb 22 06:06:06 2018

Convert SetPhishingModel to use mojo.

- Remove SafeBrowsingHostMsg_SetPhishingModel from safebrowsing_messages.h
and implement corresponding interface/methods in
safe_browsing.mojom

- Update corresponding classes (phishing_classifier_delegate.h/cc)
+ tests to reflect these changes

- Add provides to chrome/app/chrome_renderer_manifest as required

Bug:  814498 
Change-Id: I8574f3d846a4a52d931f0d706e683491ac2e07eb
Reviewed-on: https://chromium-review.googlesource.com/925221
Commit-Queue: Eve Martin-Jones <evem@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538362}
[modify] https://crrev.com/6059c242d2291030a2a77a7c2afc871f98ffdd03/chrome/app/chrome_renderer_manifest.json
[modify] https://crrev.com/6059c242d2291030a2a77a7c2afc871f98ffdd03/chrome/browser/safe_browsing/client_side_detection_service.cc
[modify] https://crrev.com/6059c242d2291030a2a77a7c2afc871f98ffdd03/chrome/browser/safe_browsing/client_side_model_loader.cc
[modify] https://crrev.com/6059c242d2291030a2a77a7c2afc871f98ffdd03/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/6059c242d2291030a2a77a7c2afc871f98ffdd03/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/6059c242d2291030a2a77a7c2afc871f98ffdd03/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc
[modify] https://crrev.com/6059c242d2291030a2a77a7c2afc871f98ffdd03/chrome/renderer/safe_browsing/phishing_classifier_delegate.h
[modify] https://crrev.com/6059c242d2291030a2a77a7c2afc871f98ffdd03/components/safe_browsing/common/BUILD.gn
[modify] https://crrev.com/6059c242d2291030a2a77a7c2afc871f98ffdd03/components/safe_browsing/common/safe_browsing.mojom
[delete] https://crrev.com/5e70c27817a18bf99c31ef3d1dae29f605e601c1/components/safe_browsing/common/safebrowsing_message_generator.cc
[delete] https://crrev.com/5e70c27817a18bf99c31ef3d1dae29f605e601c1/components/safe_browsing/common/safebrowsing_message_generator.h
[delete] https://crrev.com/5e70c27817a18bf99c31ef3d1dae29f605e601c1/components/safe_browsing/common/safebrowsing_messages.h
[modify] https://crrev.com/6059c242d2291030a2a77a7c2afc871f98ffdd03/tools/ipc_fuzzer/message_lib/all_messages.h

Comment 3 by evem@chromium.org, Feb 22 2018

Status: Fixed (was: Assigned)

Sign in to add a comment