[downloads + offline pages] find common namespace for utilities |
|||
Issue descriptionCurrently the FileExistenceChecker exists in the offline_pages namespace. Since it is a utility used by both downloads and offline pages, move it to a namespace that is shared by both.
,
Feb 27 2018
The offline_items_collection namespace looks good. We can move the file to components/offline_items_collection/core/utilities
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aac651a0a4135c9eb97bf0ab12926657311c709c commit aac651a0a4135c9eb97bf0ab12926657311c709c Author: Pete Williamson <petewil@chromium.org> Date: Thu Mar 08 01:28:45 2018 Move File Existence Checker to a better location Since it is used by both downloads and offline_pages, moving it to a common namespace and directory Bug: 814492 Change-Id: I8781730c3025087ff0ab0a5473f1ae4231dbf775 Reviewed-on: https://chromium-review.googlesource.com/939701 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by: Joy Ming <jming@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#541677} [modify] https://crrev.com/aac651a0a4135c9eb97bf0ab12926657311c709c/components/offline_items_collection/core/BUILD.gn [add] https://crrev.com/aac651a0a4135c9eb97bf0ab12926657311c709c/components/offline_items_collection/core/utilities/BUILD.gn [rename] https://crrev.com/aac651a0a4135c9eb97bf0ab12926657311c709c/components/offline_items_collection/core/utilities/file_existence_checker.h [rename] https://crrev.com/aac651a0a4135c9eb97bf0ab12926657311c709c/components/offline_items_collection/core/utilities/file_existence_checker_unittest.cc [modify] https://crrev.com/aac651a0a4135c9eb97bf0ab12926657311c709c/components/offline_pages/core/BUILD.gn
,
May 8 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by petewil@chromium.org
, Feb 27 2018