Issue 814485 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	sky@chromium.org
Closed:	Jan 10
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Rename buildflag_header targets (and gni) to buildflag

Project Member Reported by sky@chromium.org, Feb 21 2018

Issue description

See thread here: https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/rename$20buildflag_header$20%7Csort:date/chromium-dev/Hrx1j4CjHMA/LWA8KVWuAAAJ .

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4416579b311cc64b476335b5d46ddbfa6131ed0e

commit 4416579b311cc64b476335b5d46ddbfa6131ed0e
Author: Scott Violet <sky@chromium.org>
Date: Thu Feb 22 02:08:08 2018

Rename buildflag_header targets in base for consistency

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Change-Id: Ib936c2840991902fa33c040b381b8ffc98a3c532
Reviewed-on: https://chromium-review.googlesource.com/930033
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538310}
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/BUILD.gn
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/allocator/BUILD.gn
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/allocator/allocator_check.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/allocator/allocator_interception_mac.mm
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/allocator/allocator_shim_unittest.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/android/jni_android.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/android/jni_android.h
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/android/library_loader/anchor_functions.h
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/android/library_loader/library_loader_hooks.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/android/library_loader/library_prefetcher.h
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/android/library_loader/library_prefetcher_unittest.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/debug/profiler.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/debug/stack_trace.h
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/debug/stack_trace_posix.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/debug/stack_trace_unittest.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/debug/thread_heap_usage_tracker.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/debug/thread_heap_usage_tracker.h
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/debug/thread_heap_usage_tracker_unittest.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/location.h
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/memory/protected_memory.h
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/memory/protected_memory_cfi.h
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/memory/protected_memory_unittest.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/process/memory_linux.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/process/memory_mac.mm
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/process/memory_unittest.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/sampling_heap_profiler/sampling_heap_profiler.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/security_unittest.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/synchronization/lock_impl_posix.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/tools_sanity_unittest.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/trace_event/heap_profiler_allocation_context_tracker.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/trace_event/malloc_dump_provider.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/trace_event/trace_event.h
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/win/BUILD.gn
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/win/scoped_handle_test_dll.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/base/win/scoped_handle_verifier.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/build/buildflag_header.gni
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/chrome/browser/BUILD.gn
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/chrome/browser/profiling_host/BUILD.gn
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/chrome/browser/profiling_host/memlog_browsertest.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/chrome/browser/profiling_host/profiling_process_host.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/chrome/browser/profiling_host/profiling_process_host_unittest.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/chrome/browser/ui/toolbar/app_menu_model.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/chrome/browser/ui/webui/memory_internals_ui.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/chrome/common/profiling/BUILD.gn
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/chrome/common/profiling/memlog_allocator_shim.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/chrome/installer/setup/BUILD.gn
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/chrome/installer/setup/memory_unittest.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/chrome/test/base/memory_tracing_browsertest.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/content/app/content_main_runner.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/content/browser/tracing/background_memory_tracing_observer_unittest.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/content/test/BUILD.gn
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/media/base/BUILD.gn
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/media/base/media.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/remoting/host/BUILD.gn
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/remoting/host/security_key/BUILD.gn
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/services/service_manager/embedder/BUILD.gn
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/services/service_manager/embedder/main.cc
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/4416579b311cc64b476335b5d46ddbfa6131ed0e/tools/gn/bootstrap/bootstrap.py

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62f6388754e2d36ea003119b0a7f2533c3f62bc1

commit 62f6388754e2d36ea003119b0a7f2533c3f62bc1
Author: Scott Violet <sky@chromium.org>
Date: Fri Feb 23 19:25:17 2018

Rename buildflag_headers for consistency

This renames targets in chrome, chromecast and chromeos.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build
TBR=dcheng@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:mac_chromium_10.10_macviews
Change-Id: I9e93ff7bfd088b93678ce4a2814a1dbf6e36f091
Reviewed-on: https://chromium-review.googlesource.com/932544
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538856}
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/build/linux/unbundle/ffmpeg.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/app/chrome_main.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/about_flags.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/devtools/device/devtools_android_bridge.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/download/chrome_download_manager_delegate.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/download/download_path_reservation_tracker.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/download/download_target_determiner_unittest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/extensions/component_loader.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/extensions/extension_service_sync_unittest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/extensions/extension_sync_service.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/extensions/external_component_loader.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/interstitials/chrome_metrics_helper.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/interstitials/chrome_metrics_helper.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/io_thread.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/lifetime/application_lifetime.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/lifetime/browser_close_manager.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/lifetime/browser_close_manager_browsertest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/media/router/discovery/mdns/dns_sd_registry.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/metrics/chrome_metrics_service_accessor.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/metrics/tab_stats_tracker.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/notifications/notification_display_service_factory.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/notifications/notification_platform_bridge_mac.mm
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/platform_util.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/plugins/plugin_info_host_impl.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/plugins/plugin_infobar_delegates.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/plugins/plugin_infobar_delegates.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/plugins/plugin_observer.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/plugins/plugin_observer.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/profiles/avatar_menu.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/profiles/avatar_menu.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/profiles/off_the_record_profile_impl.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/profiles/profile_info_cache.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/profiles/profile_manager.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/push_messaging/push_messaging_browsertest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/push_messaging/push_messaging_service_impl.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/push_messaging/push_messaging_service_impl.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/sessions/better_session_restore_browsertest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/sessions/session_tab_helper.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/shell_integration_linux.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/shell_integration_linux.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/signin/chrome_signin_client.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/speech/tts_android.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ssl/captive_portal_blocking_page.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ssl/ssl_error_assistant.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ssl/ssl_error_handler.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ssl/ssl_error_handler_unittest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/supervised_user/supervised_users.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/sync/supervised_user_signin_manager_wrapper.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/themes/theme_properties.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/themes/theme_service.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/themes/theme_service.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/themes/theme_service_unittest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/apps/app_info_dialog.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/browser_window.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/cocoa/browser_window_cocoa.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/libgtkui/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/print_preview/print_preview_handler.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/print_preview/printer_handler.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/print_preview/printer_handler.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/signin/md_user_manager_ui.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/signin/md_user_manager_ui.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/signin/signin_create_profile_handler.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/child/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/common/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/common/chrome_content_client.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/common/chrome_features.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/common/chrome_paths.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/common/chrome_switches.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/common/pref_names.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/common/pref_names.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/common/render_messages.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/common/url_constants.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/common/webui_url_constants.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/renderer/plugins/chrome_plugin_placeholder.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/renderer/plugins/chrome_plugin_placeholder.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/test/base/test_browser_window.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/DEPS
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/android/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/app/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/app/cast_main_delegate.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/base/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/base/cast_paths.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/base/init_command_line_shlib.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/browser/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/browser/cast_browser_main_parts.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/browser/cast_content_browser_client.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/browser/cast_media_blocker_browsertest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/browser/cast_web_contents_manager.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/browser/cast_web_view_default.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/browser/cast_web_view_factory.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/browser/pref_service_helper.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/browser/test/cast_navigation_browsertest.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/common/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/common/cast_content_client.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/media/cma/backend/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/media/cma/backend/alsa/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/media/cma/backend/alsa/alsa_wrapper.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/media/cma/backend/android/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/media/cma/backend/android/cast_media_android.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/media/cma/backend/android/volume_control_android.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/media/cma/backend/audio_decoder_for_mixer.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/media/cma/backend/media_pipeline_backend_manager.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/media/cma/backend/volume_control.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/media/cma/pipeline/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/media/cma/pipeline/media_pipeline_impl.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/net/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/net/connectivity_checker_impl.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/renderer/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/renderer/cast_content_renderer_client.h
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/renderer/media/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromecast/renderer/media/key_systems_cast.cc
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/chromeos/assistant/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/ui/ozone/platform/cast/BUILD.gn
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/ui/ozone/platform/cast/DEPS
[modify] https://crrev.com/62f6388754e2d36ea003119b0a7f2533c3f62bc1/ui/ozone/platform/cast/ozone_platform_cast.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837

commit 9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837
Author: Ian Clelland <iclelland@chromium.org>
Date: Fri Feb 23 19:46:21 2018

Revert "Rename buildflag_headers for consistency"

This reverts commit 62f6388754e2d36ea003119b0a7f2533c3f62bc1.

Reason for revert: Breaks Linux x64 build

See https://ci.chromium.org/buildbot/chromium/Linux%20x64/59320


Original change's description:
> Rename buildflag_headers for consistency
> 
> This renames targets in chrome, chromecast and chromeos.
> 
> Targets go from foo_features to foo_buildflags
> And similarly the header now has buildflags in the name.
> 
> BUG=814485
> TEST=covered by build
> TBR=dcheng@chromium.org
> 
> Cq-Include-Trybots: master.tryserver.chromium.mac:mac_chromium_10.10_macviews
> Change-Id: I9e93ff7bfd088b93678ce4a2814a1dbf6e36f091
> Reviewed-on: https://chromium-review.googlesource.com/932544
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#538856}

TBR=sky@chromium.org,dcheng@chromium.org,thakis@chromium.org

Change-Id: Ie087d5e711feb3d2ac127b78f0c019ae18bcdaed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 814485
Cq-Include-Trybots: master.tryserver.chromium.mac:mac_chromium_10.10_macviews
Reviewed-on: https://chromium-review.googlesource.com/935361
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538865}
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/build/linux/unbundle/ffmpeg.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/app/chrome_main.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/about_flags.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/devtools/device/devtools_android_bridge.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/download/chrome_download_manager_delegate.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/download/download_path_reservation_tracker.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/download/download_target_determiner_unittest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/extensions/component_loader.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/extensions/extension_service_sync_unittest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/extensions/extension_sync_service.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/extensions/external_component_loader.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/interstitials/chrome_metrics_helper.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/interstitials/chrome_metrics_helper.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/io_thread.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/lifetime/application_lifetime.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/lifetime/browser_close_manager.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/lifetime/browser_close_manager_browsertest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/media/router/discovery/mdns/dns_sd_registry.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/metrics/chrome_metrics_service_accessor.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/metrics/tab_stats_tracker.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/notifications/notification_display_service_factory.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/notifications/notification_platform_bridge_mac.mm
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/platform_util.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/plugins/plugin_info_host_impl.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/plugins/plugin_infobar_delegates.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/plugins/plugin_infobar_delegates.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/plugins/plugin_observer.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/plugins/plugin_observer.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/profiles/avatar_menu.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/profiles/avatar_menu.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/profiles/off_the_record_profile_impl.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/profiles/profile_info_cache.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/profiles/profile_manager.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/push_messaging/push_messaging_browsertest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/push_messaging/push_messaging_service_impl.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/push_messaging/push_messaging_service_impl.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/sessions/better_session_restore_browsertest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/sessions/session_tab_helper.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/shell_integration_linux.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/shell_integration_linux.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/signin/chrome_signin_client.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/speech/tts_android.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ssl/captive_portal_blocking_page.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ssl/ssl_error_assistant.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ssl/ssl_error_handler.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ssl/ssl_error_handler_unittest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/supervised_user/supervised_users.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/sync/supervised_user_signin_manager_wrapper.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/themes/theme_properties.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/themes/theme_service.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/themes/theme_service.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/themes/theme_service_unittest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/apps/app_info_dialog.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/browser_window.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/cocoa/browser_window_cocoa.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/libgtkui/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/print_preview/print_preview_handler.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/print_preview/printer_handler.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/print_preview/printer_handler.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/signin/md_user_manager_ui.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/signin/md_user_manager_ui.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/signin/signin_create_profile_handler.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/child/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/common/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/common/chrome_content_client.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/common/chrome_features.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/common/chrome_paths.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/common/chrome_switches.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/common/pref_names.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/common/pref_names.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/common/render_messages.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/common/url_constants.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/common/webui_url_constants.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/renderer/plugins/chrome_plugin_placeholder.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/renderer/plugins/chrome_plugin_placeholder.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/test/base/test_browser_window.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/DEPS
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/android/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/app/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/app/cast_main_delegate.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/base/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/base/cast_paths.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/base/init_command_line_shlib.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/browser/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/browser/cast_browser_main_parts.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/browser/cast_content_browser_client.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/browser/cast_media_blocker_browsertest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/browser/cast_web_contents_manager.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/browser/cast_web_view_default.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/browser/cast_web_view_factory.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/browser/pref_service_helper.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/browser/test/cast_navigation_browsertest.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/common/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/common/cast_content_client.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/media/cma/backend/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/media/cma/backend/alsa/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/media/cma/backend/alsa/alsa_wrapper.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/media/cma/backend/android/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/media/cma/backend/android/cast_media_android.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/media/cma/backend/android/volume_control_android.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/media/cma/backend/audio_decoder_for_mixer.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/media/cma/backend/media_pipeline_backend_manager.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/media/cma/backend/volume_control.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/media/cma/pipeline/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/media/cma/pipeline/media_pipeline_impl.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/net/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/net/connectivity_checker_impl.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/renderer/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/renderer/cast_content_renderer_client.h
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/renderer/media/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromecast/renderer/media/key_systems_cast.cc
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/chromeos/assistant/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/ui/ozone/platform/cast/BUILD.gn
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/ui/ozone/platform/cast/DEPS
[modify] https://crrev.com/9c8fb6d024c5e6f1f0c8aa259a24f7a411da2837/ui/ozone/platform/cast/ozone_platform_cast.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6200d332518cd781f87ab86554bc71ff7a01ec4e

commit 6200d332518cd781f87ab86554bc71ff7a01ec4e
Author: Scott Violet <sky@chromium.org>
Date: Fri Feb 23 21:29:23 2018

reland: Rename buildflag_headers for consistency

This renames targets in chrome, chromecast and chromeos.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build
TBR=thakis@chromium.org,dcheng@chromium.org

Change-Id: I35f82bb244d2f8bd745d3157f266bae99f21f888
Reviewed-on: https://chromium-review.googlesource.com/935296
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538905}
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/build/linux/unbundle/ffmpeg.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/app/chrome_main.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/about_flags.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/browsing_data/navigation_entry_remover.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/devtools/device/devtools_android_bridge.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/download/chrome_download_manager_delegate.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/download/download_path_reservation_tracker.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/download/download_target_determiner_unittest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/extensions/component_loader.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/extensions/extension_service_sync_unittest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/extensions/extension_sync_service.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/extensions/external_component_loader.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/interstitials/chrome_metrics_helper.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/interstitials/chrome_metrics_helper.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/io_thread.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/lifetime/application_lifetime.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/lifetime/browser_close_manager.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/lifetime/browser_close_manager_browsertest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/media/router/discovery/mdns/dns_sd_registry.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/metrics/chrome_metrics_service_accessor.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/metrics/tab_stats_tracker.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/notifications/notification_display_service_factory.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/notifications/notification_platform_bridge_mac.mm
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/platform_util.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/plugins/plugin_info_host_impl.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/plugins/plugin_infobar_delegates.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/plugins/plugin_infobar_delegates.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/plugins/plugin_observer.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/plugins/plugin_observer.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/profiles/avatar_menu.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/profiles/avatar_menu.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/profiles/off_the_record_profile_impl.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/profiles/profile_info_cache.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/profiles/profile_manager.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/push_messaging/push_messaging_browsertest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/push_messaging/push_messaging_service_impl.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/push_messaging/push_messaging_service_impl.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/sessions/better_session_restore_browsertest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/sessions/session_tab_helper.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/shell_integration_linux.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/shell_integration_linux.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/signin/chrome_signin_client.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/speech/tts_android.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ssl/captive_portal_blocking_page.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ssl/ssl_error_assistant.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ssl/ssl_error_handler.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ssl/ssl_error_handler_unittest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/supervised_user/supervised_users.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/sync/supervised_user_signin_manager_wrapper.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/themes/theme_properties.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/themes/theme_service.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/themes/theme_service.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/themes/theme_service_unittest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/apps/app_info_dialog.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/browser_window.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/cocoa/browser_window_cocoa.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/libgtkui/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/print_preview/print_preview_handler.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/print_preview/printer_handler.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/print_preview/printer_handler.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/signin/md_user_manager_ui.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/signin/md_user_manager_ui.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/signin/signin_create_profile_handler.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/child/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/common/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/common/chrome_content_client.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/common/chrome_features.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/common/chrome_paths.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/common/chrome_switches.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/common/pref_names.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/common/pref_names.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/common/render_messages.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/common/url_constants.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/common/webui_url_constants.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/renderer/plugins/chrome_plugin_placeholder.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/renderer/plugins/chrome_plugin_placeholder.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/test/base/test_browser_window.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/DEPS
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/android/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/app/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/app/cast_main_delegate.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/base/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/base/cast_paths.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/base/init_command_line_shlib.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/browser/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/browser/cast_browser_main_parts.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/browser/cast_content_browser_client.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/browser/cast_media_blocker_browsertest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/browser/cast_web_contents_manager.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/browser/cast_web_view_default.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/browser/cast_web_view_factory.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/browser/pref_service_helper.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/browser/test/cast_navigation_browsertest.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/common/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/common/cast_content_client.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/media/cma/backend/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/media/cma/backend/alsa/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/media/cma/backend/alsa/alsa_wrapper.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/media/cma/backend/android/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/media/cma/backend/android/cast_media_android.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/media/cma/backend/android/volume_control_android.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/media/cma/backend/audio_decoder_for_mixer.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/media/cma/backend/media_pipeline_backend_manager.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/media/cma/backend/volume_control.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/media/cma/pipeline/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/media/cma/pipeline/media_pipeline_impl.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/net/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/net/connectivity_checker_impl.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/renderer/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/renderer/cast_content_renderer_client.h
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/renderer/media/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromecast/renderer/media/key_systems_cast.cc
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/chromeos/assistant/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/ui/ozone/platform/cast/BUILD.gn
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/ui/ozone/platform/cast/DEPS
[modify] https://crrev.com/6200d332518cd781f87ab86554bc71ff7a01ec4e/ui/ozone/platform/cast/ozone_platform_cast.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ae8289311df9e757b723ee944f6baca1f754585

commit 9ae8289311df9e757b723ee944f6baca1f754585
Author: Scott Violet <sky@chromium.org>
Date: Thu Mar 01 18:38:12 2018

Rename buildflag_headers for consistency

This renames most of components. There are still a couple left, but
this patch started getting big.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build
TBR=tsepez@chromium.org

Change-Id: I321403895df9ddc988491c70a78507ec51434783
Reviewed-on: https://chromium-review.googlesource.com/943600
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540227}
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/android/java_sources.gni
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/app/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/about_flags.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/bookmarks/chrome_bookmark_client.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/bookmarks/chrome_bookmark_client.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/browsing_data/counters/cache_counter.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/content_settings/content_settings_browsertest.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/download/download_service_factory.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/extensions/app_background_page_apitest.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/extensions/lazy_background_page_apitest.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/extensions/plugin_manager.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/gcm/gcm_profile_service_factory.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/net/net_error_tab_helper.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/page_load_metrics/observers/offline_page_previews_page_load_metrics_observer.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/plugins/plugin_info_host_impl.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/renderer_host/chrome_navigation_ui_data.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/task_manager/sampling/task_group.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/task_manager/sampling/task_manager_impl.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ui/tabs/tab_strip_model.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ui/task_manager/task_manager_columns.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ui/task_manager/task_manager_table_model.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ui/toolbar/chrome_toolbar_model_delegate.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ui/views/tabs/new_tab_button.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/common/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/common/DEPS
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/common/all_messages.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/common/chrome_content_client.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/common/pref_names.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/common/render_messages.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/install_static/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/install_static/DEPS
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/install_static/install_util.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/test/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/test/base/javascript_browser_test.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/test/ppapi/ppapi_browsertest.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/chrome/test/ppapi/ppapi_test.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/feature_engagement/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/feature_engagement/public/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/feature_engagement/public/event_constants.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/feature_engagement/public/event_constants.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/feature_engagement/public/feature_constants.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/feature_engagement/public/feature_constants.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/feature_engagement/public/feature_list.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/feature_engagement/public/feature_list.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/gcm_driver/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/gcm_driver/gcm_profile_service.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/gcm_driver/instance_id/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/gcm_driver/instance_id/instance_id_driver_unittest.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/nacl/browser/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/nacl/browser/nacl_host_message_filter.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/nacl/common/BUILD.gn
[rename] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/offline_pages/buildflags/BUILD.gn
[rename] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/offline_pages/buildflags/features.gni
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/reading_list/features/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/reading_list/features/reading_list_switches.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/sync/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/components/sync/base/model_type.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/content/browser/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/content/browser/DEPS
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/content/renderer/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/content/renderer/pepper/DEPS
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/content/renderer/pepper/plugin_module.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/content/test/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/extensions/common/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/extensions/common/DEPS
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/extensions/common/common_manifest_handlers.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/extensions/shell/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/extensions/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/extensions/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/extensions/shell/browser/shell_browser_main_parts.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/extensions/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/extensions/shell/common/shell_content_client.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/extensions/shell/renderer/shell_content_renderer_client.cc
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/tools/ipc_fuzzer/message_lib/BUILD.gn
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/tools/ipc_fuzzer/message_lib/all_messages.h
[modify] https://crrev.com/9ae8289311df9e757b723ee944f6baca1f754585/tools/ipc_fuzzer/message_tools/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7983c5387fe85f5d96af194c0df3cc8b9ee17df

commit d7983c5387fe85f5d96af194c0df3cc8b9ee17df
Author: Scott Violet <sky@chromium.org>
Date: Sat Mar 03 00:24:41 2018

Rename buildflag_headers for consistency

This finishes components.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build
TBR=dcheng@chromium.org

Change-Id: I109f65c850229fc381ee70db2a6075f7fea05f31
Reviewed-on: https://chromium-review.googlesource.com/946519
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540696}
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/android_webview/BUILD.gn
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/android_webview/DEPS
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/android_webview/lib/aw_main_delegate.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/android_webview/renderer/aw_content_renderer_client.h
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/BUILD.gn
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/about_flags.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/chrome_service.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/chrome_site_per_process_browsertest.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/renderer_context_menu/spelling_menu_observer.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/signin/account_consistency_mode_manager.h
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/signin/account_consistency_mode_manager_unittest.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/signin/account_reconcilor_factory.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/signin/chrome_signin_client.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/signin/chrome_signin_helper.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/signin/chrome_signin_helper_unittest.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/signin/signin_ui_util.h
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/signin/unified_consent_helper.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/spellchecker/spell_check_panel_host_impl.h
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/spellchecker/spellcheck_mac_view_browsertest.mm
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/spellchecker/spellcheck_service.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/ui/views/passwords/password_sign_in_promo_view.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/browser/ui/webui/settings/people_handler.h
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/renderer/BUILD.gn
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/test/BUILD.gn
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/chrome/test/base/chrome_render_view_test.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/omnibox/browser/BUILD.gn
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/signin/core/browser/BUILD.gn
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/signin/core/browser/account_reconcilor.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/signin/core/browser/profile_management_switches.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/signin/core/browser/profile_management_switches_unittest.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/signin/core/browser/scoped_account_consistency.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/signin/core/browser/signin_header_helper.h
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/signin/core/browser/signin_header_helper_unittest.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/signin/core/browser/signin_switches.h
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/BUILD.gn
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/browser/BUILD.gn
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/browser/spell_check_host_impl.h
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/common/BUILD.gn
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/common/spellcheck.typemap
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/common/spellcheck_features.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/common/spellcheck_features.h
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/common/spellcheck_switches.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/common/spellcheck_switches.h
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/renderer/BUILD.gn
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/renderer/hunspell_engine.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/renderer/spellcheck.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/renderer/spellcheck.h
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/renderer/spellcheck_panel.h
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/renderer/spellcheck_provider.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/renderer/spellcheck_provider.h
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/spellcheck/renderer/spellcheck_provider_test.cc
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/toolbar/BUILD.gn
[modify] https://crrev.com/d7983c5387fe85f5d96af194c0df3cc8b9ee17df/components/toolbar/toolbar_model_impl.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3e42b746f309641620a68ca2e3df07185c5132e

commit b3e42b746f309641620a68ca2e3df07185c5132e
Author: Scott Violet <sky@chromium.org>
Date: Mon Mar 05 20:33:51 2018

Rename buildflag_headers for consistency

This updates content.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Change-Id: I42c4e6d6fd102d923575a0a3eccf77ec3b0e3276
Reviewed-on: https://chromium-review.googlesource.com/949091
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540919}
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/chrome/browser/BUILD.gn
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/chrome/browser/about_flags.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/chrome/browser/media/webrtc/webrtc_browsertest.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/chrome/browser/media/webrtc/webrtc_desktop_capture_browsertest.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/chrome/test/BUILD.gn
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/components/nacl/broker/BUILD.gn
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/components/nacl/browser/BUILD.gn
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/app/content_main_runner.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/browser/BUILD.gn
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/browser/accessibility/browser_accessibility_manager.h
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/browser/accessibility/browser_accessibility_position.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/browser/browser_main_loop.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/browser/child_process_launcher_helper.h
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/browser/renderer_host/render_view_host_delegate_view.h
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/browser/utility_process_host_impl.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/browser/web_contents/web_contents_view_aura.h
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/common/BUILD.gn
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/common/frame_messages.h
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/common/native_types.typemap
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/public/common/BUILD.gn
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/public/common/feature_h264_with_openh264_ffmpeg.h
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/public/common/sandboxed_process_launcher_delegate.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/public/common/sandboxed_process_launcher_delegate.h
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/public/common/zygote_handle.h
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/public/renderer/BUILD.gn
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/renderer/BUILD.gn
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/renderer/external_popup_menu.h
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/renderer/media_recorder/h264_encoder.h
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/renderer/media_recorder/video_track_recorder.h
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/renderer/render_frame_impl.h
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/renderer/render_widget.h
[modify] https://crrev.com/b3e42b746f309641620a68ca2e3df07185c5132e/content/test/BUILD.gn

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1e683bdef9a76125c2fd4e4e82e100d364f921d

commit c1e683bdef9a76125c2fd4e4e82e100d364f921d
Author: Scott Violet <sky@chromium.org>
Date: Mon Mar 05 22:49:43 2018

Revert "Rename buildflag_headers for consistency"

This reverts commit b3e42b746f309641620a68ca2e3df07185c5132e.

Reason for revert: I just had a failure in the nacl side of things that I believe is related to this. I'm going to revert.

Original change's description:
> Rename buildflag_headers for consistency
> 
> This updates content.
> 
> Targets go from foo_features to foo_buildflags
> And similarly the header now has buildflags in the name.
> 
> BUG=814485
> TEST=covered by build
> 
> Change-Id: I42c4e6d6fd102d923575a0a3eccf77ec3b0e3276
> Reviewed-on: https://chromium-review.googlesource.com/949091
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540919}

TBR=sky@chromium.org,dcheng@chromium.org

Change-Id: I9f6a9ef5b6299bf9656b24db5eed63bbfa474f49
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 814485
Reviewed-on: https://chromium-review.googlesource.com/949983
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540966}
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/chrome/browser/BUILD.gn
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/chrome/browser/about_flags.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/chrome/browser/media/webrtc/webrtc_browsertest.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/chrome/browser/media/webrtc/webrtc_desktop_capture_browsertest.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/chrome/test/BUILD.gn
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/components/nacl/broker/BUILD.gn
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/components/nacl/browser/BUILD.gn
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/app/content_main_runner.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/browser/BUILD.gn
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/browser/accessibility/browser_accessibility_manager.h
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/browser/accessibility/browser_accessibility_position.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/browser/browser_main_loop.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/browser/child_process_launcher_helper.h
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/browser/renderer_host/render_view_host_delegate_view.h
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/browser/utility_process_host_impl.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/browser/web_contents/web_contents_view_aura.h
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/common/BUILD.gn
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/common/frame_messages.h
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/common/native_types.typemap
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/public/common/BUILD.gn
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/public/common/feature_h264_with_openh264_ffmpeg.h
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/public/common/sandboxed_process_launcher_delegate.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/public/common/sandboxed_process_launcher_delegate.h
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/public/common/zygote_handle.h
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/public/renderer/BUILD.gn
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/renderer/BUILD.gn
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/renderer/external_popup_menu.h
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/renderer/media_recorder/h264_encoder.h
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/renderer/media_recorder/video_track_recorder.h
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/renderer/render_frame_impl.h
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/renderer/render_widget.h
[modify] https://crrev.com/c1e683bdef9a76125c2fd4e4e82e100d364f921d/content/test/BUILD.gn

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c

commit c78fef73842a9043f2f6e4e6d23b3b40aeaa106c
Author: Scott Violet <sky@chromium.org>
Date: Tue Mar 06 17:42:53 2018

reland: Rename buildflag_headers for consistency

I reverted my first patchset because I saw a compile error on a windows bot.
Specifically nacl_broker_listener.cc includes nacl_broker_listener.h, which
includes sandboxed_process_launcher_delegate.h. The nacl target
"content_dummy" lists a couple of content header files directly, with no deps
on other content files. This means if "content_dummy" is used, content's
zygote_buildflags was not necessarily generated. The fix is to add a dep
from content_dummy to zygote_buildflags.

This is likely a long standing issue that you would only see on clean builds.

This updates content.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Change-Id: I37c12091781d48a9eab0fb43797a53a2fcccaa87
Reviewed-on: https://chromium-review.googlesource.com/950133
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541139}
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/chrome/browser/BUILD.gn
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/chrome/browser/about_flags.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/chrome/browser/media/webrtc/webrtc_browsertest.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/chrome/browser/media/webrtc/webrtc_desktop_capture_browsertest.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/chrome/test/BUILD.gn
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/components/nacl/broker/BUILD.gn
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/components/nacl/browser/BUILD.gn
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/app/content_main_runner.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/browser/BUILD.gn
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/browser/accessibility/browser_accessibility_manager.h
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/browser/accessibility/browser_accessibility_position.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/browser/browser_main_loop.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/browser/child_process_launcher_helper.h
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/browser/renderer_host/render_view_host_delegate_view.h
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/browser/utility_process_host_impl.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/browser/web_contents/web_contents_view_aura.h
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/common/BUILD.gn
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/common/frame_messages.h
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/common/native_types.typemap
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/public/common/BUILD.gn
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/public/common/feature_h264_with_openh264_ffmpeg.h
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/public/common/sandboxed_process_launcher_delegate.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/public/common/sandboxed_process_launcher_delegate.h
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/public/common/zygote_handle.h
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/public/renderer/BUILD.gn
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/renderer/BUILD.gn
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/renderer/external_popup_menu.h
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/renderer/media_recorder/h264_encoder.h
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/renderer/media_recorder/video_track_recorder.h
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/renderer/render_frame_impl.h
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/renderer/render_widget.h
[modify] https://crrev.com/c78fef73842a9043f2f6e4e6d23b3b40aeaa106c/content/test/BUILD.gn

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8240b0983944f87549b454f4282869bdb578744

commit c8240b0983944f87549b454f4282869bdb578744
Author: Scott Violet <sky@chromium.org>
Date: Thu Mar 08 22:03:59 2018

Rename buildflag_headers for consistency

This updates device, extensions and one new one in components.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build
TBR=dcheng@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8f935cf88795b11a57728da10e830ffd88ce4885
Reviewed-on: https://chromium-review.googlesource.com/956006
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541891}
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/android_webview/test/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/apps/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/apps/ui/views/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/base/android/jni_generator/jni_exception_list.gni
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/android/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/app/android/DEPS
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/app/android/chrome_jni_onload.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/DEPS
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/about_flags.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/android/DEPS
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/android/vr/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/apps/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/autocomplete/autocomplete_classifier_factory.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/autocomplete/keyword_extensions_delegate_impl.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/autocomplete/shortcuts_backend_factory.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/autocomplete/shortcuts_provider_extension_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/browser_about_handler.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/browsing_data/browsing_data_file_system_helper.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/browsing_data/browsing_data_helper_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_factory.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/browsing_data/cookies_tree_model.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/browsing_data/cookies_tree_model.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/browsing_data/cookies_tree_model_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/browsing_data/counters/browsing_data_counter_factory.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/browsing_data/counters/browsing_data_counter_utils_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/browsing_data/counters/downloads_counter_browsertest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/chrome_notification_types.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/content_settings/host_content_settings_map_factory.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/devtools/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/download/chrome_download_manager_delegate.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/download/chrome_download_manager_delegate.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/download/download_core_service.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/download/download_core_service_impl.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/download/download_core_service_impl.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/download/download_history.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/download/download_history_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/download/download_target_determiner.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/download/download_target_determiner_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/extensions/extension_service.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/geolocation/geolocation_permission_context_extensions.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/geolocation/geolocation_permission_context_extensions.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/history/profile_based_browsing_history_driver.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/interstitials/chrome_metrics_helper.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/interstitials/chrome_metrics_helper.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/io_thread.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/io_thread.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/media/router/media_router_feature.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/media/webrtc/media_stream_capture_indicator.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/memory_details.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/metrics/chrome_metrics_service_client_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/metrics/chrome_stability_metrics_provider.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/metrics/process_memory_metrics_emitter.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/metrics/renderer_uptime_tracker.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/nacl_host/nacl_browser_delegate_impl.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/nacl_host/nacl_browser_delegate_impl.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/net/chrome_extensions_network_delegate.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/net/chrome_extensions_network_delegate.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/net/chrome_network_delegate_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/net/net_export_helper.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/notifications/notifier_state_tracker.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/notifications/notifier_state_tracker.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/performance_monitor/performance_monitor.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/permissions/permission_manager_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/plugins/chrome_content_browser_client_plugins_part.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/plugins/plugin_info_host_impl.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/plugins/plugin_info_host_impl.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/policy/policy_conversions.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/policy/policy_helpers.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/prerender/prerender_link_manager.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/prerender/prerender_manager_factory.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/prerender/prerender_util.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/printing/print_view_manager_common.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/profiles/off_the_record_profile_impl.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/profiles/profile_impl.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/profiles/profile_window.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/renderer_context_menu/context_menu_content_type_factory.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/renderer_context_menu/render_view_context_menu.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/renderer_host/chrome_navigation_ui_data.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/renderer_host/chrome_navigation_ui_data.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/renderer_host/chrome_render_message_filter.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/renderer_host/chrome_render_message_filter.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/renderer_host/pepper/pepper_isolated_file_system_message_filter.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/safe_browsing/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/safe_browsing/incident_reporting/extension_data_collection.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/safe_browsing/safe_browsing_controller_client.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/sessions/chrome_tab_restore_service_client.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/sessions/session_tab_helper.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/site_details.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ssl/ssl_blocking_page.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/supervised_user/supervised_user_service.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/supervised_user/supervised_user_service.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/supervised_user/supervised_user_service_factory.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/supervised_user/supervised_user_service_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/supervised_user/supervised_user_url_filter.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/supervised_user/supervised_user_url_filter_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/sync/glue/extensions_activity_monitor.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/tab_contents/tab_util.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/task_manager/providers/render_process_host_task_provider.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/task_manager/providers/web_contents/extension_tag.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/task_manager/web_contents_tags.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/themes/theme_service.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/themes/theme_service.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/android/usb_chooser_dialog_android.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/blocked_content/popunder_preventer.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/bookmarks/bookmark_utils.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/browser.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/browser.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/browser_close_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/browser_navigator.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/fast_unload_controller.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/login/login_handler.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/omnibox/chrome_omnibox_edit_controller.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/prefs/prefs_tab_helper.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/unload_controller.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/webui/constrained_web_dialog_ui.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/webui/cookies_tree_model_util.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/webui/log_web_ui_url.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/webui/log_web_ui_url_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/webui/net_export_ui.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/webui/policy_ui_handler.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/ui/webui/policy_ui_handler.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/vr/features.gni
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/vr/service/vr_device_manager.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/vr/vr_tab_helper.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/browser/web_applications/web_app_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/chrome_paks.gni
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/chrome_repack_locales.gni
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/common/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/common/DEPS
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/common/chrome_features.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/common/chrome_features.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/common/common_message_generator.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/common/extensions/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/common/features.gni
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/common/pref_names.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/common/pref_names.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/common/stack_sampling_configuration.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/renderer/BUILD.gn
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/renderer/DEPS
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/renderer/chrome_content_renderer_client_unittest.cc
[modify] https://crrev.com/c8240b0983944f87549b454f4282869bdb578744/chrome/renderer/chrome_render_thread_obse

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a35f9a482b7071c7951e867d7d84347060ada282

commit a35f9a482b7071c7951e867d7d84347060ada282
Author: Scott Violet <sky@chromium.org>
Date: Thu Mar 22 22:00:44 2018

Rename buildflag_headers for consistency

This updates media and a couple of other minor ones.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build
TBR=xhwang@chromium.org (for third_party)

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2349230b278e3f6e163196fcf03b9b5fa1367e5d
Reviewed-on: https://chromium-review.googlesource.com/975990
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545268}
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/android_webview/DEPS
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/android_webview/lib/aw_main_delegate.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/cc/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/DEPS
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/about_flags.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/browser_process.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/chrome_browser_field_trials_desktop.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/chrome_content_browser_client_unittest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/extensions/api/preference/preference_apitest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/icon_loader_chromeos.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/load_library_perf_test.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/media/DEPS
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/media/cdm_storage_id.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/media/cdm_storage_id_key.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/media/encrypted_media_browsertest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/media/encrypted_media_supported_types_browsertest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/media/platform_verification_impl.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/plugins/plugin_info_host_impl.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/renderer_host/pepper/pepper_platform_verification_message_filter.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/renderer_preferences_util.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/ui/browser_ui_prefs.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/ui/prefs/prefs_tab_helper.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/common/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/common/chrome_paths.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/common/common_message_generator.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/common/logging_chrome.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/common/pref_names.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/common/pref_names.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/common/render_messages.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/common/webui_url_constants.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/renderer/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/renderer/media/chrome_key_systems.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/renderer/pepper/pepper_uma_host.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/renderer/plugins/plugin_uma_unittest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/services/media_gallery_util/media_metadata_parser.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/services/media_gallery_util/media_parser.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/test/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chrome/test/base/testing_browser_process.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chromecast/renderer/DEPS
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/chromecast/renderer/media/key_systems_cast.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/cdm/DEPS
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/cdm/browser/DEPS
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/cdm/browser/cdm_message_filter_android.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/cdm/common/widevine_drm_delegate_android.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/cdm/renderer/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/cdm/renderer/android_key_systems.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/cdm/renderer/external_clear_key_key_system_properties.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/cdm/renderer/external_clear_key_key_system_properties.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/cdm/renderer/widevine_key_system_properties.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/cdm/renderer/widevine_key_system_properties.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/nacl/common/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/nacl/loader/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/pdf/DEPS
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/viz/common/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/viz/common/gpu/vulkan_in_process_context_provider.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/viz/common/gpu/vulkan_in_process_context_provider.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/viz/service/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/viz/service/display/display.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/viz/service/display/output_surface.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/viz/service/display/skia_renderer.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/components/viz/service/main/viz_main_impl.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/app/content_main_runner.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/browser_main_loop.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/browser_main_loop.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/compositor/gpu_browser_compositor_output_surface.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/compositor/offscreen_browser_compositor_output_surface.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/compositor/software_browser_compositor_output_surface.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/gpu/compositor_util.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/media/encrypted_media_browsertest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/media/media_browsertest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/media/media_canplaytype_browsertest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/media/media_color_browsertest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/media/media_interface_proxy.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/media/media_interface_proxy.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/media/media_redirect_browsertest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/media/media_source_browsertest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/renderer_host/render_process_host_browsertest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/webrtc/webrtc_capture_from_element_browsertest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/webrtc/webrtc_internals.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/webrtc/webrtc_internals.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/browser/webui/content_web_ui_controller_factory.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/child/child_thread_impl.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/common/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/common/content_ipc_logging.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/common/content_message_generator.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/gpu/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/gpu/gpu_main.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/gpu/gpu_sandbox_hook_linux.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/gpu/gpu_service_factory.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/ppapi_plugin/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/ppapi_plugin/ppapi_thread.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/public/browser/browser_ipc_logging.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/public/browser/content_browser_client.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/public/browser/gpu_utils.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/public/browser/render_process_host.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/public/browser/webrtc_log.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/public/common/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/public/common/content_switches.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/public/common/content_switches.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/public/common/feature_h264_with_openh264_ffmpeg.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/public/gpu/content_gpu_client.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/public/test/mock_render_process_host.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/public/test/mock_render_process_host.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/renderer/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/renderer/media/audio_decoder.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/renderer/media/media_factory.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/renderer/media/media_factory.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/renderer/media/webrtc/rtc_certificate_generator.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/renderer/media/webrtc/rtc_video_encoder_factory.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/renderer/pepper/content_renderer_pepper_host_factory.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/renderer/pepper/pepper_media_device_manager.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/renderer/pepper/resource_converter.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/renderer/pepper/video_decoder_shim.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/renderer/render_thread_impl.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/renderer/render_view_impl.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/renderer/renderer_main.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/shell/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/shell/browser/shell.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/shell/renderer/layout_test/test_media_stream_renderer_factory.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/shell/renderer/shell_content_renderer_client.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/utility/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/utility/utility_service_factory.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/content/zygote/zygote_main_linux.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/gpu/command_buffer/service/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/gpu/command_buffer/service/DEPS
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/gpu/command_buffer/service/gpu_preferences.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/gpu/ipc/common/gpu_preferences.typemap
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/gpu/vulkan/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/ipc/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/ipc/ipc_logging.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/ipc/ipc_message.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/base/BUILD.gn
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/base/cdm_context.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/base/decode_capabilities.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/base/eme_constants.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/base/ipc/media_param_traits_macros.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/base/key_system_properties.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/base/key_systems.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/base/key_systems.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/base/key_systems_unittest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/base/localized_strings.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/base/media.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/base/media_switches.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/base/mime_util_internal.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/base/mime_util_unittest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/base/video_codecs.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/blink/webcontentdecryptionmodulesession_impl.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/cast/sender/h264_vt_encoder_unittest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/cdm/aes_decryptor.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/cdm/aes_decryptor_unittest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/cdm/cdm_adapter_unittest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/cdm/cdm_module.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/cdm/library_cdm/clear_key_cdm/clear_key_cdm.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/ffmpeg/ffmpeg_common.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/filters/audio_decoder_unittest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/filters/audio_file_reader_unittest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/filters/audio_video_metadata_extractor_unittest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/filters/chunk_demuxer_unittest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/filters/demuxer_perftest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/filters/ffmpeg_demuxer.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/filters/ffmpeg_demuxer.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/filters/ffmpeg_demuxer_unittest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/filters/media_file_checker_unittest.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/filters/stream_parser_factory.cc
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/formats/mp2t/es_parser_adts.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/formats/mp2t/es_parser_h264.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/formats/mp2t/mp2t_stream_parser.h
[modify] https://crrev.com/a35f9a482b7071c7951e867d7d84347060ada282/media/formats/mp2t/mp2t

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0caaaf430f7c6021727c2f6972df2f6964714874

commit 0caaaf430f7c6021727c2f6972df2f6964714874
Author: Scott Violet <sky@chromium.org>
Date: Sat Mar 24 00:43:59 2018

Rename buildflag_headers for consistency

This updates mojo, net and pdf.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Change-Id: I279223aa2bdfc375288eee485a77bfad9b6db3d4
Reviewed-on: https://chromium-review.googlesource.com/978372
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545650}
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/browser/io_thread.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/browser/local_discovery/service_discovery_shared_client.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/browser/net/system_network_context_manager.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/browser/printing/cloud_print/privet_notifications.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/browser/printing/cloud_print/privet_notifications.h
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/browser/profiles/off_the_record_profile_io_data.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/browser/profiles/profile_browsertest.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/common/BUILD.gn
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/content/renderer/loader/ftp_directory_listing_response_delegate.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/content/shell/browser/shell_url_request_context_getter.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/mojo/public/cpp/bindings/BUILD.gn
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/mojo/public/cpp/bindings/lib/connector.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/BUILD.gn
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/cert/x509_util_win.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/disk_cache/blockfile/mapped_file.h
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/http/transport_security_state.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/http/transport_security_state_unittest.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/proxy_resolution/pac_file_fetcher_impl_unittest.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/url_request/url_request.h
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/url_request/url_request_context.h
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/url_request/url_request_context_builder.h
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/url_request/url_request_context_storage.h
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/url_request/url_request_http_job.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/url_request/url_request_http_job.h
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/url_request/url_request_http_job_unittest.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/url_request/url_request_job_manager.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/0caaaf430f7c6021727c2f6972df2f6964714874/pdf/BUILD.gn

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9ec3a6d0f8e60ca6390ae6f0d5c0114f273f4fc

commit d9ec3a6d0f8e60ca6390ae6f0d5c0114f273f4fc
Author: Scott Violet <sky@chromium.org>
Date: Tue Mar 27 03:08:56 2018

Rename buildflag_headers for consistency

This updates ios.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7a59eb0e91b3813855e79352a6146f4d1410c85a
Reviewed-on: https://chromium-review.googlesource.com/981322
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545932}
[modify] https://crrev.com/d9ec3a6d0f8e60ca6390ae6f0d5c0114f273f4fc/ios/chrome/browser/ui/qr_scanner/BUILD.gn
[modify] https://crrev.com/d9ec3a6d0f8e60ca6390ae6f0d5c0114f273f4fc/ios/chrome/browser/ui/qr_scanner/camera_controller.mm
[modify] https://crrev.com/d9ec3a6d0f8e60ca6390ae6f0d5c0114f273f4fc/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[modify] https://crrev.com/d9ec3a6d0f8e60ca6390ae6f0d5c0114f273f4fc/ios/chrome/browser/ui/tab_switcher/tab_switcher_cache.mm
[modify] https://crrev.com/d9ec3a6d0f8e60ca6390ae6f0d5c0114f273f4fc/ios/chrome/common/BUILD.gn
[modify] https://crrev.com/d9ec3a6d0f8e60ca6390ae6f0d5c0114f273f4fc/ios/chrome/common/app_group/BUILD.gn
[modify] https://crrev.com/d9ec3a6d0f8e60ca6390ae6f0d5c0114f273f4fc/ios/chrome/common/app_group/app_group_constants.mm
[modify] https://crrev.com/d9ec3a6d0f8e60ca6390ae6f0d5c0114f273f4fc/ios/net/BUILD.gn
[modify] https://crrev.com/d9ec3a6d0f8e60ca6390ae6f0d5c0114f273f4fc/ios/net/cookies/cookie_store_ios.mm
[modify] https://crrev.com/d9ec3a6d0f8e60ca6390ae6f0d5c0114f273f4fc/ios/net/cookies/system_cookie_store.mm

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02e38b93c3483d0b64ececde6d44e79c50f951ca

commit 02e38b93c3483d0b64ececde6d44e79c50f951ca
Author: Scott Violet <sky@chromium.org>
Date: Tue Mar 27 23:42:14 2018

Rename buildflag_headers for consistency

This updates ppapi.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build
TBR=xhwang@chromium.org

Change-Id: I25f990ebd1e7f8530ddd0cee24dba31c88a45fae
Reviewed-on: https://chromium-review.googlesource.com/980921
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546312}
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/DEPS
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/app/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/about_flags.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/browsing_data/counters/media_licenses_counter.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/browsing_data/counters/site_data_counting_helper.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/content_settings/content_settings_browsertest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/download/chrome_download_manager_delegate.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/download/download_target_determiner.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/download/download_target_determiner.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/download/download_target_determiner_unittest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/extensions/component_loader.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/extensions/extension_garbage_collector_unittest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/metrics/chrome_metrics_service_client.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/metrics/chrome_stability_metrics_provider.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/metrics/metrics_memory_details.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/plugins/pdf_iframe_navigation_throttle.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/plugins/pdf_iframe_navigation_throttle_unittest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/plugins/pdf_plugin_placeholder_observer.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/plugins/plugin_info_host_impl.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/profiles/off_the_record_profile_impl.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/profiles/profile_io_data.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/renderer_context_menu/render_view_context_menu.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/renderer_host/chrome_render_message_filter.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/renderer_host/chrome_render_message_filter.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/ui/page_info/page_info_ui.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/ui/page_info/page_info_unittest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/ui/page_info/permission_menu_model.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/ui/webui/settings/site_settings_handler.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/browser/ui/webui/version_handler.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/common/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/common/chrome_content_client.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/common/chrome_content_client_unittest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/common/chrome_features.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/common/chrome_features.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/common/chrome_switches.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/common/chrome_switches.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/common/features.gni
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/common/pref_names.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/common/pref_names.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/common/render_messages.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/common/url_constants.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/renderer/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/renderer/pepper/pepper_uma_host.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/renderer/plugins/plugin_uma_unittest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/test/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/test/base/test_switches.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/chrome/test/base/test_switches.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/components/autofill/DEPS
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/components/autofill/content/browser/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/components/autofill/content/browser/risk/fingerprint.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/components/cdm/DEPS
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/components/content_settings/core/browser/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/components/plugins/renderer/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/components/renderer_context_menu/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/components/renderer_context_menu/DEPS
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/components/renderer_context_menu/render_view_context_menu_base.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/components/renderer_context_menu/render_view_context_menu_base.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/components/strings/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/app/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/app/content_main_runner.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/android/browser_startup_controller.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/browser_main_loop.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/browsing_data/browsing_data_remover_impl.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/browsing_data/browsing_data_remover_impl_unittest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/frame_host/data_url_navigation_browsertest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/frame_host/debug_urls.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/frame_host/render_frame_message_filter.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/frame_host/render_frame_message_filter.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/loader/mime_sniffing_resource_handler.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/loader/mime_sniffing_resource_handler_unittest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/net/accept_header_browsertest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/plugin_private_storage_helper.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/plugin_service_impl.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/renderer_host/pepper/browser_ppapi_host_impl.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/storage_partition_impl_unittest.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/child/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/child/font_warmup_win.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/common/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/common/all_messages.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/common/frame_messages.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/common/native_types.typemap
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/common/pepper_file_util.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/common/pepper_plugin_list.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/common/pepper_renderer_instance_data.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/common/plugin_list.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/common/view_messages.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/ppapi_plugin/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/public/child/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/public/common/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/public/common/pepper_plugin_info.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/public/renderer/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/public/renderer/render_frame.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/renderer/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/renderer/render_frame_impl.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/renderer/render_view_impl.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/renderer/render_widget.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/renderer/render_widget.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/renderer/renderer_main.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/renderer/text_input_client_observer.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/renderer/text_input_client_observer.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/shell/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/shell/browser/layout_test/layout_test_browser_main_parts.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/shell/browser/layout_test/layout_test_browser_main_parts.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/shell/renderer/shell_content_renderer_client.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/test/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/content/zygote/zygote_main_linux.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/extensions/browser/BUILD.gn
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/extensions/browser/DEPS
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/extensions/browser/guest_view/web_view/web_view_permission_helper.cc
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/extensions/browser/guest_view/web_view/web_view_permission_helper.h
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/ppapi/BUILD.gn
[rename] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/ppapi/buildflags/BUILD.gn
[rename] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/ppapi/buildflags/buildflags.gni
[modify] https://crrev.com/02e38b93c3483d0b64ececde6d44e79c50f951ca/third_party/widevine/cdm/DEPS

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5

commit 318a55fc28aa04351073f5e08fbd6c1fd6b05ae5
Author: Scott Violet <sky@chromium.org>
Date: Fri Mar 30 19:08:19 2018

Rename buildflag_headers for consistency

This updates printing.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Change-Id: I455c5638ef9bcd98f669fc7117b4699a34292fd0
Reviewed-on: https://chromium-review.googlesource.com/988132
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547228}
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/app/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/about_flags.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/apps/app_browsertest.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/browser_shutdown.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/extensions/api/chrome_extensions_api_client.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/extensions/component_loader.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/printing/cloud_print/cloud_print_proxy_service.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/printing/cloud_print/privet_http_impl.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/printing/cloud_print/privet_http_impl.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/printing/cloud_print/privet_http_unittest.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/printing/print_view_manager.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/printing/print_view_manager.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/printing/print_view_manager_base.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/printing/print_view_manager_base.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/printing/print_view_manager_common.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/printing/print_view_manager_common.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/printing/printer_manager_dialog.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/printing/printing_init.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/printing/printing_message_filter.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/printing/printing_message_filter.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/renderer_context_menu/render_view_context_menu.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/task_manager/web_contents_tags.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/apps/chrome_app_delegate.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/browser.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/browser_commands.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/cocoa/accelerators_cocoa.mm
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/libgtkui/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/libgtkui/gtk_ui.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/views/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/views/accelerator_table.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/webui/print_preview/print_preview_handler.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/webui/print_preview/print_preview_ui.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/browser/ui/webui/settings/printing_handler.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/common/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/common/all_messages.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/common/chrome_features.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/common/chrome_switches.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/common/chrome_switches.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/common/chrome_utility_printing_messages.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/common/common_message_generator.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/common/features.gni
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/common/webui_url_constants.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/renderer/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/service/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/test/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/test/base/testing_browser_process.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/test/base/web_ui_browser_test.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/utility/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/utility/chrome_content_utility_client.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/utility/printing_handler.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/chrome/utility/printing_handler.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/printing/common/print_messages.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/printing/common/print_messages.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/printing/renderer/print_render_frame_helper.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/printing/renderer/print_render_frame_helper.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/printing/renderer/print_render_frame_helper_linux.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/printing/renderer/print_render_frame_helper_mac.mm
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/printing/service/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/printing/test/print_mock_render_thread.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/printing/test/print_mock_render_thread.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/printing/test/print_render_frame_helper_browsertest.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/printing/test/print_test_content_renderer_client.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/pwg_encoder/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/renderer_context_menu/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/renderer_context_menu/DEPS
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/renderer_context_menu/context_menu_content_type.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/resources/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/strings/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/components/test/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/content/browser/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/content/browser/renderer_host/pepper/pepper_print_settings_manager.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/content/renderer/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/headless/BUILD.gn
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/headless/DEPS
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/headless/lib/browser/headless_devtools_manager_delegate.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/headless/lib/browser/headless_printing_unittest.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/headless/lib/browser/headless_web_contents_impl.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/headless/lib/headless_web_contents_browsertest.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/headless/lib/renderer/headless_content_renderer_client.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/headless/lib/utility/headless_content_utility_client.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/printing/BUILD.gn
[rename] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/printing/buildflags/BUILD.gn
[rename] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/printing/buildflags/buildflags.gni
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/printing/print_job_constants.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/printing/print_job_constants.h
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/printing/printing_context.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/printing/printing_context_win.cc
[modify] https://crrev.com/318a55fc28aa04351073f5e08fbd6c1fd6b05ae5/skia/BUILD.gn

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5f7ba11e697a35e34212829e25c5b54461257b1

commit a5f7ba11e697a35e34212829e25c5b54461257b1
Author: Scott Violet <sky@chromium.org>
Date: Mon Apr 02 22:03:40 2018

Rename buildflag_headers for consistency

This updates rlz.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I802e3e09554fc8564c265d6bb6a9df08ec368081
Reviewed-on: https://chromium-review.googlesource.com/990240
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547535}
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/BUILD.gn
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/browser_shutdown.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/chromeos/login/login_utils_browsertest.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/extensions/api/music_manager_private/device_id_win.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/extensions/api/music_manager_private/music_manager_private_browsertest.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/extensions/install_signer.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/media/cdm_storage_id.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/renderer_host/pepper/device_id_fetcher.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/rlz/chrome_rlz_tracker_delegate.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/search_engines/template_url_service_factory.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/search_engines/ui_thread_search_terms_data.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/ui/app_list/app_list_controller_delegate.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/common/BUILD.gn
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/common/DEPS
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/common/pref_names.h
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/installer/util/BUILD.gn
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/installer/util/master_preferences.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/installer/util/master_preferences_unittest.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/test/BUILD.gn
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/test/DEPS
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/chrome/test/ppapi/ppapi_browsertest.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/components/BUILD.gn
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/ios/chrome/browser/DEPS
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/ios/chrome/browser/ios_chrome_main_parts.mm
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/ios/chrome/browser/search_engines/BUILD.gn
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/ios/chrome/browser/search_engines/template_url_service_factory.cc
[modify] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/ios/chrome/browser/search_engines/ui_thread_search_terms_data.cc
[rename] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/rlz/buildflags/BUILD.gn
[rename] https://crrev.com/a5f7ba11e697a35e34212829e25c5b54461257b1/rlz/buildflags/buildflags.gni

Project Member

Comment 17 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73634e321c32238ebd7c33ba292fe637fddd32d7

commit 73634e321c32238ebd7c33ba292fe637fddd32d7
Author: Scott Violet <sky@chromium.org>
Date: Wed Apr 04 21:05:02 2018

Rename buildflag_headers for consistency

This updates webkit, services and sandbox.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
Change-Id: If082636e3f84033a3345d135847d5847436b6814
Reviewed-on: https://chromium-review.googlesource.com/992999
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548194}
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/DEPS
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/DEPS
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/android/DEPS
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/android/contextualsearch/unhandled_tap_web_contents_observer.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/android/photo_picker_sandbox_bridge.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/android/seccomp_support_detector.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/devtools/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/devtools/device/port_forwarding_controller.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/devtools/devtools_window.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/devtools/remote_debugging_server.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/renderer_preferences_util.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/browser/ui/webui/devtools_ui.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/test/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/test/chromedriver/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/chrome/test/chromedriver/net/adb_client_socket.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/components/nacl/loader/DEPS
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/components/nacl/loader/sandbox_linux/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/content/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/content/browser/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/content/browser/DEPS
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/content/child/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/content/child/blink_platform_impl.h
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/content/common/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/content/renderer/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/content/renderer/render_view_impl.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/content/renderer/renderer_main_platform_delegate_android.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/content/shell/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/sandbox/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/sandbox/linux/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/sandbox/linux/seccomp-bpf-helpers/seccomp_starter_android.h
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/services/service_manager/sandbox/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/services/service_manager/sandbox/linux/sandbox_linux.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/services/service_manager/sandbox/linux/sandbox_linux.h
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/services/service_manager/sandbox/linux/sandbox_seccomp_bpf_linux.cc
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/third_party/WebKit/Source/core/DEPS
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/third_party/WebKit/Source/core/input/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/third_party/WebKit/Source/core/input/GestureManager.cpp
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.h
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/third_party/WebKit/Source/platform/heap/BUILD.gn
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/third_party/WebKit/Source/platform/heap/HeapAllocator.h
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/third_party/WebKit/Source/platform/heap/IncrementalMarkingTest.cpp
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/third_party/WebKit/Source/platform/heap/Member.h
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/third_party/WebKit/Source/platform/heap/ThreadState.cpp
[modify] https://crrev.com/73634e321c32238ebd7c33ba292fe637fddd32d7/third_party/WebKit/public/BUILD.gn

Project Member

Comment 18 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ac4f597f3a298990edf25c7fa68ab96476d5ce5

commit 3ac4f597f3a298990edf25c7fa68ab96476d5ce5
Author: Scott Violet <sky@chromium.org>
Date: Wed Apr 18 21:56:44 2018

Rename buildflag_headers for consistency

This updates third_party/libaom

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iefb7b76b23b4b21d5706f0f054cc21eeca313ccb
Reviewed-on: https://chromium-review.googlesource.com/1017760
Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551841}
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/chrome/browser/BUILD.gn
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/chrome/browser/DEPS
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/chrome/browser/about_flags.cc
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/content/browser/DEPS
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/content/browser/media/media_canplaytype_browsertest.cc
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/content/test/BUILD.gn
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/media/base/BUILD.gn
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/media/base/decode_capabilities.cc
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/media/base/mime_util_internal.cc
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/media/filters/BUILD.gn
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/media/filters/stream_parser_factory.cc
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/media/formats/BUILD.gn
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/media/formats/mp4/box_definitions.cc
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/media/formats/mp4/fourccs.h
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/media/formats/webm/webm_video_client.cc
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/media/renderers/BUILD.gn
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/media/renderers/default_renderer_factory.cc
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/media/test/BUILD.gn
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/media/test/pipeline_integration_test.cc
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/media/test/pipeline_integration_test_base.cc
[modify] https://crrev.com/3ac4f597f3a298990edf25c7fa68ab96476d5ce5/third_party/libaom/BUILD.gn

Comment 19 by thakis@chromium.org, Jan 9

What's the status here?

Project Member

Comment 20 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b46ff10c3a5ab98167fc92468e346476fe333ee8

commit b46ff10c3a5ab98167fc92468e346476fe333ee8
Author: Scott Violet <sky@chromium.org>
Date: Wed Jan 09 22:06:25 2019

Rename buildflag_headers for consistency

This updates ios/

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Change-Id: I9d40ab7d8e6f3fb7c7167ec04786bfe3403ef897
Reviewed-on: https://chromium-review.googlesource.com/c/1403344
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621308}
[modify] https://crrev.com/b46ff10c3a5ab98167fc92468e346476fe333ee8/ios/public/provider/chrome/browser/BUILD.gn
[modify] https://crrev.com/b46ff10c3a5ab98167fc92468e346476fe333ee8/ios/web_view/BUILD.gn
[modify] https://crrev.com/b46ff10c3a5ab98167fc92468e346476fe333ee8/ios/web_view/internal/app/application_context.cc
[modify] https://crrev.com/b46ff10c3a5ab98167fc92468e346476fe333ee8/ios/web_view/internal/cwv_preferences.mm
[modify] https://crrev.com/b46ff10c3a5ab98167fc92468e346476fe333ee8/ios/web_view/internal/cwv_web_view.mm
[modify] https://crrev.com/b46ff10c3a5ab98167fc92468e346476fe333ee8/ios/web_view/internal/cwv_web_view_configuration.mm
[modify] https://crrev.com/b46ff10c3a5ab98167fc92468e346476fe333ee8/ios/web_view/internal/web_view_browser_state.mm
[modify] https://crrev.com/b46ff10c3a5ab98167fc92468e346476fe333ee8/ios/web_view/internal/web_view_web_main_parts.mm

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b72577df26f5213842f98368a9e4d3626a48dbbb

commit b72577df26f5213842f98368a9e4d3626a48dbbb
Author: Scott Violet <sky@chromium.org>
Date: Wed Jan 09 22:18:18 2019

Rename buildflag_headers for consistency

This updates ui/base/ui_features

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Change-Id: Ia06811589cbaf18daab4c67048096875fb25cf3e
Reviewed-on: https://chromium-review.googlesource.com/c/1403088
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621329}
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/extensions/dev_mode_bubble_delegate.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/global_keyboard_shortcuts_mac_unittest.mm
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/media/router/media_router_feature.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/notifications/notification_display_service_tester.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/safe_browsing/chrome_password_protection_service.h
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/ui/hung_renderer/hung_renderer_interactive_uitest.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/ui/startup/startup_browser_creator_impl.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/ui/views/confirm_bubble_views.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/ui/views/download/download_danger_prompt_views.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/ui/views/global_error_bubble_view.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/ui/views/hats/hats_bubble_view.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/ui/views/importer/import_lock_dialog_view.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/ui/views/page_info/page_info_bubble_view_base.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/ui/views/relaunch_notification/relaunch_recommended_bubble_view.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/ui/views/session_crashed_bubble_view.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/ui/views/session_crashed_bubble_view_browsertest.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/browser/ui/views/ssl_client_certificate_selector_mac.mm
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/common/BUILD.gn
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/common/chrome_features.h
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/common/chrome_switches.h
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/test/base/interactive_test_utils_views.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/utility/BUILD.gn
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/components/exo/wayland/server.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/components/exo/wayland/wayland_keyboard_delegate.h
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/components/test/components_test_suite.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/content/browser/BUILD.gn
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/content/browser/browser_main_loop.h
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/content/ppapi_plugin/ppapi_thread.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/content/public/test/test_launcher.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/content/test/content_test_launcher.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/extensions/test/extensions_unittests_main.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/accessibility/platform/ax_platform_node.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/accessibility/platform/ax_platform_node_base.h
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/aura/BUILD.gn
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/aura/test/aura_test_suite_setup.h
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/base/BUILD.gn
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/base/material_design/material_design_controller.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/base/resource/resource_bundle.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/base/ui_base_features.h
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/events/keycodes/BUILD.gn
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/events/keycodes/DEPS
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/events/keycodes/xkb_keysym.h
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/ozone/platform/drm/DEPS
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/ozone/platform/drm/ozone_platform_gbm.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/ozone/platform/wayland/BUILD.gn
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/ozone/platform/wayland/DEPS
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/ozone/platform/wayland/ozone_platform_wayland.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/ozone/platform/wayland/wayland_keyboard.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/ozone/platform/wayland/wayland_test.h
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/ozone/platform/wayland/wayland_touch.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/views/accessibility/view_accessibility.cc
[modify] https://crrev.com/b72577df26f5213842f98368a9e4d3626a48dbbb/ui/views/style/platform_style_mac.mm

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd6ee1143ba55b99a627f158ef61bb80b898fe97

commit fd6ee1143ba55b99a627f158ef61bb80b898fe97
Author: Scott Violet <sky@chromium.org>
Date: Thu Jan 10 19:05:32 2019

Rename buildflag_headers for consistency

This updates the remaining targets in ui/ and url/.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Change-Id: I746dee03434f9bf593ea19f4868f67fa2482f14b
Reviewed-on: https://chromium-review.googlesource.com/c/1405493
Commit-Queue: Scott Violet <sky@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621679}
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/chrome/browser/BUILD.gn
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/chrome/browser/about_flags.cc
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/chrome/browser/ui/views/BUILD.gn
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/chrome/browser/ui/views/nav_button_provider.h
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/components/cronet/android/BUILD.gn
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/components/cronet/android/cronet_library_loader.cc
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/content/browser/BUILD.gn
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/gpu/config/BUILD.gn
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/gpu/config/gpu_util.cc
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/gpu/ipc/service/BUILD.gn
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/ios/net/BUILD.gn
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/ios/net/protocol_handler_util.mm
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/net/BUILD.gn
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/net/test/run_all_unittests.cc
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/ui/gl/BUILD.gn
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/ui/gl/gl_image_io_surface.mm
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/ui/gl/gl_implementation.cc
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/ui/gl/init/BUILD.gn
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/ui/gl/init/gl_factory_mac.cc
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/ui/gl/init/gl_initializer_android.cc
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/ui/gl/init/gl_initializer_mac.cc
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/ui/gl/init/gl_initializer_win.cc
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/ui/gl/init/gl_initializer_x11.cc
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/ui/ozone/common/BUILD.gn
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/ui/ozone/common/egl_util.cc
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/ui/views/BUILD.gn
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/ui/views/linux_ui/linux_ui.h
[modify] https://crrev.com/fd6ee1143ba55b99a627f158ef61bb80b898fe97/url/BUILD.gn

Project Member

Comment 23 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acf114464a4d296b497ad0766c1eb046fe4b0091

commit acf114464a4d296b497ad0766c1eb046fe4b0091
Author: Scott Violet <sky@chromium.org>
Date: Thu Jan 10 20:33:59 2019

Rename buildflag_headers for consistency

This updates chrome/browser/vr

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Change-Id: I89654d8c4db03d86bb96c63b18dfd0bd89b5be3c
Reviewed-on: https://chromium-review.googlesource.com/c/1403515
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621728}
[modify] https://crrev.com/acf114464a4d296b497ad0766c1eb046fe4b0091/chrome/browser/component_updater/vr_assets_component_installer.cc
[modify] https://crrev.com/acf114464a4d296b497ad0766c1eb046fe4b0091/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/acf114464a4d296b497ad0766c1eb046fe4b0091/chrome/browser/vr/assets_loader.cc

Comment 24 by sky@chromium.org, Jan 10

Status: Fixed (was: Started)

I'm calling this done. There is one build file that does not follow the convention: build/linux/unbundle/ffmpeg.gn. I had updated that one, but it was reverted. I believe the reason it was reverted is it has to stay in sync with third_party/ffmpeg/BUILD.gn (pulled in via deps). It looks like Nico has contributed to the ffmpeg repo, maybe he wants to update it? I'm moving this to fixed for now.

►

Issue 814485 link

Issue metadata

Rename buildflag_header targets (and gni) to buildflag

Issue description

Comment 1 by bugdroid1@chromium.org, Feb 22 2018

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Feb 23 2018

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Feb 23 2018

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Feb 23 2018

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Mar 1 2018

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Mar 3 2018

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Mar 5 2018

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Mar 5 2018

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Mar 6 2018

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Mar 8 2018

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Mar 22 2018

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Mar 24 2018

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Mar 27 2018

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Mar 27 2018

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Mar 30 2018

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Apr 2 2018

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Apr 4 2018

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Apr 18 2018

Comment 18 Deleted

Comment 19 by thakis@chromium.org, Jan 9

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Jan 9

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Jan 9

Comment 21 Deleted

Comment 22 by bugdroid1@chromium.org, Jan 10

Comment 22 Deleted

Comment 23 by bugdroid1@chromium.org, Jan 10

Comment 23 Deleted

Comment 24 by sky@chromium.org, Jan 10

Comment 24 Deleted

Sign in to add a comment